unyonsys / puppet-module-keepalived Goto Github PK

Hi,

This module resource keepalived::instance has a "notify" parameter, which overlaps with same name metaparameter.

notify is a metaparam; this value will inherit to all contained resources in the keepalived::instance definition

It should be renamed to something else as it is used for configuration option "notify".
Same remark in sync_group.

Patch is attached.
puppet-keepalived-notify_any.diff.txt

With the most recent changes to keepalived_instance.erb, I'm getting an error when running puppet on a client tagged with keepalived

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Failed to parse template keepalived/keepalived_instance.erb:
  Filepath: /etc/puppet/modules/keepalived/templates/keepalived_instance.erb
  Line: 19
  Detail: undefined method `uniq' for "10.3.1.143":String
 at /etc/puppet/modules/keepalived/manifests/instance.pp:41 on node cmgmt01p1.corp.sharpcast.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

The yaml data that is used on this host

  keepalived::instance:
    "52":
      interface: "eth0"
      virtual_ips: "%{::vip_ip}"
      state: %{::vip_state}
      priority: %{::vip_priority}

The variable, vip_ip is a custom fact that is generated with this code

Facter.add("vip_ip") do
    setcode do
      Facter::Util::Resolution.exec("dig +short `hostname -f | sed 's/p[1,2]//g'`")
    end

So the value of the variable is coming out as a string, and you can't apply a uniq operator to it. If I remove the uniq operator, things work again. Am I missing something here?

The version on http://forge.puppetlabs.com/unyonsys/keepalived is missing a lot of the new features, if the release date there is accurate.

Looking for something in the form of git tag X.Y.Z a number of the other puppet modules use 0.y.0 scheme. Just trying to improve packaging for RDO (https://www.rdoproject.org/)