Comments (6)
@yuriydzobak Thanks very much for further details!
I have created a PR for fixing this. We will look to get this merged in the coming days, and cut a new patch release right after π
from merge-gatekeeper.
Hi @yuriydzobak, thanks for raising the issue! π
Merge Gatekeeper looks at the GitHub Action status, and is specifically looking for a state called error
in the current implementation. How do you have your atlantis/plan
job configured / triggered, and do you see some other status with it?
For further investigation, we may need to add an external flag for verbose logging, so that we can pinpoint what's happening with the actual job input. I believe the actual fix for this would be simply to catch other statuses, so that should be straightforward. We will look to see what we can do from our end, but if you can help fill in some details above, it would allow us to get a patch release for your specific use case quickly π
from merge-gatekeeper.
Hi @rytswd
Hi @yuriydzobak, thanks for raising the issue! π
Merge Gatekeeper looks at the GitHub Action status, and is specifically looking for a state called
error
in the current implementation. How do you have youratlantis/plan
job configured / triggered, and do you see some other status with it?
webhook configuration -> link
For further investigation, we may need to add an external flag for verbose logging, so that we can pinpoint what's happening with the actual job input. I believe the actual fix for this would be simply to catch other statuses, so that should be straightforward. We will look to see what we can do from our end, but if you can help fill in some details above, it would allow us to get a patch release for your specific use case quickly π
If i understand correct it sends this and you are validating this one
from merge-gatekeeper.
I've reproduced the issue
if the status of commit is failure
then gatekeeper doesn't see it
If the status of commit is error
then all works
doc: https://docs.github.com/en/rest/commits/statuses#create-a-commit-status
The state of the status. - Can be one of: error, failure, pending, success
gatekeeper doesn't have logic to check failure
from merge-gatekeeper.
I've checked from your branch and all works as expected
Thank you very much
from merge-gatekeeper.
Thanks for testing! v1.1.1
has been released with the above fix
We will update the relevant major and minor version tags (v1
and v1.1
) in the coming days as well.
from merge-gatekeeper.
Related Issues (20)
- Add support to specify list of jobs rather than waiting for all jobs HOT 2
- wrong default interval in README and docs HOT 1
- How do you handle GitHub rate limit HOT 3
- Add support for retry merge-gatekeeper failure HOT 3
- Increase limit job HOT 6
- Support spaces and newlines in ignored jobs
- Add regex support for ignored jobs HOT 7
- Better processing log format HOT 7
- Unable to detect jobs. HOT 1
- Feature request: support for `[ci skip]`-type functionality HOT 3
- Multiple jobs with the same name are treated as one job. HOT 2
- Update docs to enumerate the specific permissions needed by merge-gatekeeper HOT 1
- Handling/retrying transient network failures HOT 4
- merge gatekeeper failed when pr is opened HOT 2
- Hitting Docker rate limit and ways to avoid that HOT 2
- Add Support for Merge Queues HOT 2
- Failure on self-hosted runners
- Support GitHub Enterprise Instances
- Provide build binaries with the GitHub release to side-step needing Docker (+ build)?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merge-gatekeeper.