Comments (6)
@yuriydzobak Sorry for getting back to you late!
Understood, we will do further testing on our side. Merge Gatekeeper aims to be a drop-in solution without any extra configurations for most standard monorepo use cases, so we would like it to handle cases where there are so many jobs running at the same time. We will check and get back to you as soon as we can!
from merge-gatekeeper.
Hi @rytswd
could you help with it?
from merge-gatekeeper.
Hi @yuriydzobak, thanks for raising the issue!
We will certainly need to look at this more closely, as this is new to me at least. Let us dive deep and figure out what's possibly causing this - depending on that, we may be able to ensure Merge Gatekeeper works with any number of jobs, or we may introduce another field, with which you can configure based on your requirements π
from merge-gatekeeper.
Hi @yuriydzobak, thanks for raising the issue!
βΊοΈ
We will certainly need to look at this more closely, as this is new to me at least. Let us dive deep and figure out what's possibly causing this - depending on that, we may be able to ensure Merge Gatekeeper works with any number of jobs, or we may introduce another field, with which you can configure based on your requirements π
Would be nice if MG works with any number, because I have repos with 20-30 jobs, some repo has 70 jobs(matrix) and for example, users don't care about any limits in MG
for me, any solution would be great π
Thank you
from merge-gatekeeper.
Sorry for the delay in getting back to this, just a quick update on this.
We have found that the GitHub API we use indeed only gives us 30 results, and this can be increased to 100. However, this is more of a pagination handling by GitHub, and in order to fully support any number of jobs, we would need to adjust our API usages in a bit more complicated manner (i.e. ensure pagination is taken into account). We think we have an implementation idea to fix this, but please bear with us until we work out the solution with proper tests in place π
from merge-gatekeeper.
Given the above fix #48 is in, this should now be handled without any extra configurations. Merge Gatekeeper will simply follow the pagination to ensure we get the full list of jobs. Thanks to @Jrc356 for contributing a fix! π
from merge-gatekeeper.
Related Issues (20)
- Merge Gatekeeper considering previous failed runs and failing unexpectedly HOT 3
- Gatekeeper misses failures in matrix jobs HOT 9
- Add support to specify list of jobs rather than waiting for all jobs HOT 2
- wrong default interval in README and docs HOT 1
- Gatekeeper does not fail if the webhook job fails HOT 6
- How do you handle GitHub rate limit HOT 3
- Add support for retry merge-gatekeeper failure HOT 3
- Support spaces and newlines in ignored jobs
- Add regex support for ignored jobs HOT 7
- Better processing log format HOT 7
- Unable to detect jobs. HOT 1
- Feature request: support for `[ci skip]`-type functionality HOT 3
- Multiple jobs with the same name are treated as one job. HOT 2
- Update docs to enumerate the specific permissions needed by merge-gatekeeper HOT 1
- Handling/retrying transient network failures HOT 4
- merge gatekeeper failed when pr is opened HOT 2
- Hitting Docker rate limit and ways to avoid that HOT 2
- Add Support for Merge Queues HOT 2
- Failure on self-hosted runners
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merge-gatekeeper.