upstartdeveloper / cs-1.3-core-data-structures Goto Github PK

1. Sets:

• All implementations are right. Clean and descriptive code as usual.

2. Word Jumble

• Great work, it is running really fast.

1. Hash Table - (Passes all tests)

• It looks good, the only I would say change this line to make it more pythonic.

for pair in key_value_pairs:
    self.set(pair[0], pair[1])

to this

for key, value in key_value_pairs:
            self.set(key, value)

2. Article

• Great read. you might want to change your title to make it unique. because there are so many articles has the same title. but its is just a recommendation

1. Number bases:
   Excellent work. Good documentation and comments.
2. Binary search:
   Your code looks good and working all well. But I recommend you look at how your peers implemented binary search, seems like your implementation a bit too complicated. You are using a little more checks: if clause in your code.

Good work, everything looks really good. But it seems you tried to write a test for deque, as of now it is failing, but it is not required to pass the submission. So you are good.

1. Palindrome:
   Good work. Make sure you annotate your functions with runtime.
2. String Algorithm:
   Great work. All of the runtime annotations are accurate and clean code.

• Everything looks good, you have all (DFS) traversals are implemented recursively, try to do them iteratively. Great work on all the docstring and helper function implementations.