Giter VIP home page Giter VIP logo

Comments (2)

jpopelka avatar jpopelka commented on July 3, 2024 1

The proposed solution is acceptable, but I'd rather change get_from_frambo_config - it's AFAICT not used outside frambo so we can do that.

What about:

def get_from_frambo_config(module: str, key: str, default: Any = "", raises: bool = True):
    if key not in frambo_config().get(module, {}) and raises:
        raise ValueError(f"{module}:{key} not set in {CONFIG_DIR / 'config.yml'}")
    return frambo_config().get(module, {}).get(key, default)

and then just

PAGURE_PORT = get_from_frambo_config("pagure", "port", raises=False)

from frambo.

phracek avatar phracek commented on July 3, 2024

Your proposed solution works properly in open sourced betka.

from frambo.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.