The frambo from user-cont

frambo's People

Contributors

Stargazers

Watchers

frambo's Issues

Replace PersistentDict with already existing lib

Did I forget to use Google before implementing the PersistentDict?

persistent-dict, repo
Durabledict, repo

Metod for sending events to sentry

For cases we want to report something without trace-backing the bot.

Inspiration:

client = raven.Client(dsn, install_logging_hook=True)
client.capture(event_type, tags=tags, fingerprint=fingerprint, **kwargs)

Copy pasted from internal Gitlab (reported by @dhodovsk )

src.fedoraproject.org does not need PAGURE_PORT

betka bot clones dist-git repositories by clone SSH URL.
For src.osci.redhat.com we use PAGURE_PORT.
But src.fedoraproject.org does not use it.

https://github.com/user-cont/frambo/blob/master/frambo/pagure.py#L4

The Pull request which fixes it will follow soon.

I would suggest, in case of get_from_frambo_config("pagure", "port") fails with KeyError, then initiated as PAGURE_PORT = ""

See configuration file for pagure.io https://github.com/user-cont/frambo/blob/master/frambo/data/conf.d/config.yml#L12

try:
   PAGURE_PORT = get_from_frambo_config("pagure", "port")
except ValueError:
  PAGURE_PORT = ""

See betka output:

betka_1      |   File "/usr/local/lib/python3.7/site-packages/betka/core.py", line 18, in <module>
betka_1      |     from frambo.pagure import PAGURE_HOST, PAGURE_PORT, PAGURE_URL
betka_1      |   File "/usr/local/lib/python3.7/site-packages/frambo/pagure.py", line 4, in <module>
betka_1      |     PAGURE_PORT = get_from_frambo_config("pagure", "port")
betka_1      |   File "/usr/local/lib/python3.7/site-packages/frambo/config.py", line 58, in get_from_frambo_config
betka_1      |     raise ValueError(f"{module}:{key} not set in {CONFIG_DIR / 'config.yml'}")
betka_1      | ValueError: Couldn't import 'tasks': pagure:port not set in /usr/local/lib/python3.7/site-packages/frambo/data/conf.d/config.yml