vaeth / bookmarkdupes Goto Github PK

Hi!

Would it be possible to add a new expert mode? Current one has kinda high learning curve with all it's text fields. As someone who knows JS I would like to have expert mode where that instead of 66 edit boxes would have just one. And in that one I wish to paste my own JS function that takes 2 bookmarks as arguments and returns true if they are dupes. This way I can write my custom logic with no complexity limit and then just throw it in existing addon without having to write one myself.

For example for filtering by url only I would paste in this edit box something like:

function(bookmarkA, bookmarkB){
  return bookmarkA.url == bookmarkB.url;
}

And that example code could be below box to help people get started quickly. Optionally you could add checkbox to save all or nothing - that if at any point function throws then changes will not be saved. Or maybe even display preview of changes where user has to click save button in order to write changes.

Syntax highlighting is not importent for js. I can write my function in some IDE and when it is done paste it text box.

Hi, I've been using this extension for a long time, in the last few days I don't know why but by clicking on "Dupes" a series of NOT duplicate links appear, but it seems that they are considered in non-existent subfolders, with the same name as a parent folder.

example:

1- Sites | gaming sites | xxx sites | link to page
2- Sites | gaming sites | xxx sites | xxx sites | link to page
3- Sites | gaming sites | xxx sites | xxx sites | xxx sites | link to page
11- ... for exactly 11 lines of dupes for each link I have in bookmarks subfolders.

So the folder "xxx sites" exists only once, there are no other real subfolders with the same name.

Tried reinstalling the extension.
Never touched "expert mode".

If I click on "select a folder to get corresponding...", folders are all correct, no doubled subfolders.

I want to do a simple search for a term like "car" (removed all default filters). I've tried in the name matches or URL matches. In either case, it shows bookmarks that do not have car anywhere in the name or URL.

???

FF 61.0 (64bit) Win7

Hi,
I tried to install Bookmark Dupes v4.2 or v4.1 at https://addons.mozilla.org/zh-CN/firefox/addon/bookmark-dupes/ , but it failed and return the following error message: "The add-on downloaded from this site could not be installed because it appears to be corrupt."
I downloaded the xpi file "bookmark_dupes-4.2-fx.xpi", and the filesize is 39014 bytes, the md5sum is 0972e813bdf4c88c4a99ce1530badfa4. Is something error with Mozilla or the add-on ?

I propose to change the method of selection bookmarks, if it's possible.

from
Mark all but first in each group (by position in list)
to
Mark all except first in each group - by time of adding (i.e. except one, oldest bookmark)

from
Mark all but last in each group (by position in list)
to
Mark all except last in each group - by time of adding (i.e. except one, newest bookmark)

It would be really useful to add a button to bookmarkdupes to keep deleting empty folders until no empty folders are left. That way, if there are 4 empty folders nested in one another (ex. folder 1 (empty) > folder 2 (empty) > folder 3 (empty) > folder 4 empty, folder 1 (empty) > folder 2 (empty) & folder 3 (empty) > folder 4 (empty)), all 4 folders would be deleted.

Halo
I have some thousands of bookmarks in my Firefox on Ubuntu, Windows (2 devices), Mac and Android devices.
All with sync enabled.
But for the DupeDeleting I disabled Sync in FF 111.0.1 (Ubuntu 22.04 at the moment).

Many dupes because of wrong sync I guess.
I tried this Add-On to delete the duplicates, but it is incredibly slow.
After half an hour I read:
(3 %) 74 von 2566 Lesezeichen entfernt
Is this normal or can I enhance it somehow?

Like this it will be finished tomorrow, slowing down FF as well, so I cannot use it.
Thanks.
frank

EDIT: maybe I could run the SQL command directly on the places.sqlite DB?
Then I would quit FF and run that command it in e.g. DBeaver or on command line, but there is no visible logfile in the add-on, where I could see what is done in background.

Here a screenshot before deleting:

Here when I start deleting:

And here after about 10 minutes deleting, makes FF very slow:

Thanks for this nice extension.
When I wanted to delete some marked bookmarks in the "All Bookmarks" view I could not find a button "Remove Marked Bookmarks" . Maybe I overlooked it otherwise would it be nice if there is a "Remove Marked Bookmarks" in the "All Bookmarks" view.
Thanks.

Is it possible to reload favicons of all bookmark itmes during check? Thank you.

This isn't really a bug, more of a question. How do I match a tailing slash (a slash on the end of a URL) so it can detect https://google.com and https://google.com/ as dupes?

Right now, my rules look like this:

Hello,

First best wishes for 2018 and thanks a lot for your great work and your extension Bookmarks Dupes which is very useful : I wait since years that a developer (I don't know coding myself) adds a feature to detect similar bookmarks, not only exact dupes (I manage more than 12.000 bookmarks with lots of them to sort).

And version 4.2 improves a lot the design !

I have some suggestions and needs regarding the "similar" function, if it is possible to add them, and of course if you find it suitable :

I have many "duplicates" which do not have exactly the same URL but are the same page, or just another page of the same site, not detected by the extension because the different links don't have the "?" inside ; so Bookmark Dupes could also verify :

Bookmarks similar with https SSL encryption :
http://www.xxxxx.com
https://www.xxxxx.com

Bookmarks similar with or without www or ww2... :
http://www.xxxxx.com
http://ww2.xxxxx.com
http://xxxxx.com

Bookmarks with sub-domain (other characters before main domain), with or without www :
http://www.yyy.xxxxx.com
http://yyy.xxxxx.com
http://xxxxx.com

Combination of SSL and no www :
https://www.xxxxx.com
http://xxxxx.com

Bookmarks similar with or without / at the end :
http://www.xxxxx.com
http://www.xxxxx.com/

Bookmarks similar with same domain but different addresses :
http://www.xxxxx.com
http://www.xxxxx.com/index.html
http://www.xxxxx.com/article1.htm
http://www.xxxxx.com/forum.php/p=1&sid=zzzzzzzzzzz

Results would be displayed in addition to Duplicates in the "Similar" screen, like now with the parent folder, possibility to compare and suppress one (some) of them - because sometimes I want to have the main page of a site and also a sub-page as two separate bookmarks, and sometimes not : it's just a duplicate.

With option to whitelist some domains : because sometimes there are plenty of sites on a same main domain (wordpress.com ; github.com ; youtube.com ...) but they are all well different and the results list would be too long with them.

Is it an idea which seems you interesting ? I'd like to help but don't know any programming, I tried to look on the source code without understanding how to do this, but I can made a donation...

Thanks in advance. Best regards,

Xavier

Doesn't appear to be available. Addons like Dark Reader can't function on moz-extension:// pages from what I know.

Enhancement/extension to test valid/invalid links?

1. is this being considered?

2. is this app still being supported?

3. fyi, as per some other reports, i have had no probs with finding deleting dups (that i know of) in library of ~6,000 BM;
   but i stay well away from 'Expert' - way above my paygrade, even for an ex-programmer long ago, and i see no real need

Hello
I am not a professional and I can not use Expert Mode.
The problem is:

Three different URLs:

1. https://gist.github.com/kennwhite/1f3bc4d889b02b35d8aa#gistcomment-1854294
2. https://gist.github.com/kennwhite/1f3bc4d889b02b35d8aa#gistcomment-1930733
3. https://gist.github.com/kennwhite/1f3bc4d889b02b35d8aa#gistcomment-1931470

they are recognized as one:
https://gist.github.com/kennwhite/1f3bc4d889b02b35d8aa

Please help me how to fix it.

• Graphic buttons "Insert a new rule." looks like a "Delete" or "Close".
  I propose to replace it with "+".

• Perhaps, it makes sense to use one "Insert a new rule." button instead of a few.

• When the radio button "Filter" is enabled, all parameters of radio button "Modify" are blocked.
  So, it may also make sense to block "Filter" parameters when the radio button "Modify" is active ?
  Anyway, a "Filter" parameters doesn't work when "Modify" button is active.

• Now, I'm trying to fix my translations more carefully, by modifying a Options page (saved html).
  In this connection, I have a request - can I try to use Alt+255 blank space in some names of the buttons - for more precise alignment of the tables?
  I really like the result.

Before:

After:

fixed

This is a good app. It has helped me to remove unwanted bookmarks pretty easily. However, it would help if each group of bookmarks shown in the dupes category had a button that when checked would check all bookmarks within only that group of bookmarks that was shown beneath the button. Each group of bookmarks would have it's own button such that when the button for that particular group of bookmarks was checked, that all the bookmarks within that group would then be checked. And if you unchecked the button for that group of bookmarks, then all the bookmarks for that group would then be unchecked.

我想找到文件夹名称完全相同的所有重复的文件夹

请问我该怎么填？在哪儿填？

After doing a search I get "134 (of 753) dupes in 66 groups". I'm just assuming that it means "134 dupes of 753 total bookmarks in 66 groups".

The current wording makes it sound like I'm just viewing 134 out of a total of 753 dupes.

The list of duplicated bookmarks is illegible as it is black text on a dark grey background. I guess the extension is specifying one color and using a default for the other.

I learnt of this plugin a month or so ago. It is very useful and much appreciated.

It would be even more useful if there were the option to print out the "Non-Duplicates". This way, I can see the difference between an old and a new bookmark set, and manually decide for each bookmark "Have I deleted it from the local bookmarks deliberately" -> I delete the singlet; or "Have I added it to the imported bookmarks (from another operating system)?" -> I keep the singlet.

From there I can go back to printing the Dupes and delete them.

It would save a lot of time in correcting my Bookmarks.

Thank you

http://site.com/
https://site.com/
http://www.site.com/
https://www.site.com/

The Sites mentioned above, they are duplicates. But the program does not recognize that.

I have a butt-ton of bookmarks. Several times I've switched browsers, importing bookmarks and things end up duplicated. When bookmarkdupes searches for exact dupes, it takes forever (multiple days I suspect) - I have never seen it display the list of duplicate bookmarks!
(I don't know if it's starting a new search when I click 'exact dupes' again...)

Please add a button to stop the search and show the currently-found results! Then I can delete a lot of the duplicates and search again.

1- I'm finding I have to close Firefox and restart in order to do another task. If I delete Empty Folders... And then I want to do a Dupe Search, I have to close/reopen before it will do so.

2- For some reason the dupes checking will not include the main Bookmarks Menu. I had to make a temp folder on the Bookmarks Toolbar and move everything from the main Bookmarks Menu to this temp Toolbar folder in order for the add-on to "see them" It doesn't detect anything that exists in the Main Bookmarks Menu.

3- I also receive an error: " Error after removing 946 bookmarks. Error: transaction timeout, most likely caused by unresolved pending work.
** (This extension has been a lifesaver after a particular synchronization app duplicated my bookmarks in exponential numbers. There do, however seem to be a couple of glitches. I'll forward more detail to the developer... ) **

"Empty Folders" doesn't consider folders empty is they contain one or more "Separator".

It would be nice if "Separators" were considered as "nothing" since they exist only to provide an enhancement to the UX.

• feature request: merge duplicate folders (case insensitive)
• feature request: find duplicate URL's (Seemingly bookmarkdupes only finds duplicate title's, unless i'm mistaken)

reference: https://addons.mozilla.org/en-US/firefox/addon/bookmarks-clean-up/

Looks like the "star" button doesn't work in Firefox 55.0.3 (x64).
When I click on it - nothing happens.
Also, I tried to launch a browser with disabled addons (except Bookmark Dupes).

Since the 6.1 update, "Move marked bookmarks to dupe" doesn't work, when started it will just hang and not do anything, everything else is working.

The problem is here for the bookmarks and the folders.

6.0 is working perfectly.

Browser: Icecat (Firefox 60.7.0esr) (since it wasn't reported before I'm guessing that it's not happening in later version of Firefox)

Gif of the issue:

1
I thought "stripping descriptions" means something like "deleting descriptions",
but it doesn't occur (in my case).

2
The addon freezes when this cleanup is complete (gray buttons, aren't clicked),
so you need to turn off/on addon - to restore functionality.

my Firefox - 55.0.3 (x64).

Would be cool to sort bookmarks by criteria after deleting them. I know it's kinda off topic for this addon but just in case you are interested in extending it int more general bookmarks manager.
Update: FF has implemented it already.

Second thing I would like to see is limit this extension only for one directory.

FF 60.0b4 (x64)
bookmarkdupes v5.6

The buttons become inactive after clicking on them.
Also, the addon doesn't find my bookmarks.

Hello,
Thank you for the great extension!

I would like to request making it a little easier to exclude multiple folders. Right now I have to manually type the path with the correct '\0' in the folder tree, which gets tedious when excluding several folders.

Maybe there is an easier method of entering the paths which I don't know. It would be nice to have a more interactive UI menu, e.g. a Browse button, where we select the folders with the mouse directly from the tree. I'm sure that requires a lot more work, so I'm not expecting much.

Thank you for the consideration.

it happen after importing the bookmark from modified html file, it seem when i click the dupes button there seem like there are nothing happen even after i waited for few hour. does bookmarkdupes have a max number of bookmark that it can handle? and i did try to limit the search only the specific folder using expert mode but the result is the same

Thank you for your hard work. But sometimes it'd be useful to have duplicates. So could you pls add a function to allow that? By that I mean allowing adding the same url in different folders at the same time. Now it is impossible. Best wishes!

The second issue mentioned in #8 should be discussed here separately.

Problem: When stripping a description, a new bookmark is created (and then the old one removed). The index where this bookmark is created was in <bookmarkdupes-2.4 calculated as the child number obtained from browser.bookmarks.getTree().

It might be more reliable to use the index stored in the node itself.
If that index exists, this is used instead in bookmarksdupes-2.4.

I don't understand if this is possible. It seems like the rule would be

“Replace URL matches” .+ “by” $URL$TITLE

But it says "this special meaning is only active if this is the full replacement text", so they can't be combined like that? But then how would they be combined? It says "one can combine several rules to work around that limitation if necessary" but how to combine them if they both completely replace the text?

When pressing any of the main buttons "Dupes", "Empty Folders", or "All bookmarks", bookmark dupes hangs forever on Android. Since there is no "about:debugging" option on android, I don't have an idea how to check what is actually causing this.

In the moment, I will disable the whole extension for android.

As mentioned in another issue, I've got a lot of bookmarks with a ton of duplicates.

I would like a button to delete all the duplicates in the same folder.

(I have so many bookmarks and duplicates, the only messages I've seen are 'Searching' and 'Searching 80255) exact dupes in 21412 groups' - which gives an idea of how many bookmarks and dupes I have.

I've folded a lot of the duplicate folders together (e.g., instead of 5 folders of 'python' I now have one, with 5 of each entry).

I did manually delete exact duplicate folders, but many folders are "all bookmarks at (some date)" - so include some of yesterday's bookmarks with some added and/or deleted. Which means many duplicates...

Being able to delete all the duplicates in the same folder would be awesome - that would take care of the majority of my duplicates.

Starting with Firefox 43, add-on extensions and multi-item add-ons that include extensions need to be signed by Mozilla before they can install in release and beta versions of Firefox.

More info on mozilla's site

In Linux Mint Cinnamon 1.23, and Firefox 128.0, I tried to access this site but in my resolution, which is less than 1920x1080 pixels, but 16:9 display, the window scroll bar springs back to the top, and I am unable access the lower part of the "manage" page.

Unmark all from “$TITLE$
In groups containing “$TITLE$” mark all but these
Mark all from “$TITLE$”
In groups with “$TITLE$” mark only these

Maybe it makes sense to hide these 12 new buttons by default?
E.g. make them available in the addon options by clicking on the checkbox.

In that bug, I will regularly announce if something notably changed.

In the moment, there are two announcements necessary:

1. In order to fix leakage of private data, I had to rebase just now. If you had pulled within the last 24 hours or so, please rebase, too. (I suppose you will have to use something along git fetch, git reset --hard ... and then later push with git push --force; perhaps github provides also other options). I am sorry about that, and I hope that this rebase of the main repository will be the sole exception.

2. Two new buttons were added. I added the new messages (untranslated) to all _locale/*/messages.json files. Please drop me a note if you prefer that I do this differently in the future. (E.g. if you prefer to not have modified that files when new messages are added.)

I try to merge my updated bookmarks between Firefox Pale Moon and Firefox Quantum.
I exported my bookmarks in HTML format from Pale Moon 27.8.1.
I imported them in Firefox 59.0.1.
(both browsers contain about 2,5k bookmarks)
I used de-dupe with option (delete all but oldest). It removed the dupes.
Then I used action to search for empty dirs.
It deleted some. I searched for empty dirs again. It deleted some. And again. And again.
See screenshots in unlisted IMGUR gallery.
https://imgur.com/a/Xm7MB
What info can help you isolate the issue?

https://bugzilla.mozilla.org/show_bug.cgi?id=1402890
Importance: P2 normal

P2 - Fix in the next release or iteration:
https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md

Hello, may you please consider adding an option that allows us to detect those both as a duplicate:
http://www.google.com/
https://www.google.com/

This bug is opened as a reaction on a review on mozilla.

For some not yet clarified reason, with many duplicate bookmarks and "automatic" selection more than only duplicates have been reported to be removed.

It was conjectured that the number of bookmarks is related, but I tested with huge numbers; therefore, it is unlikely that the number alone is the reason.

I consider it also very unlikely that bookmark dupes instructed firefox to remove a bookmark which was not marked. This leaves the following possible causes for the bug:

1. Too many bookmarks have been marked. I consider it very likely that the code for marking is correct. So very likely this could happen only if none-duplicates had been displayed in one group. Possible reasons.

   • Perhaps "similiar dupes" were selected by accident instead of "exact dupes"?
   • A bug in the code for calculating or displaying the groups of duplicates.
     So far, I have not been able to detect such a bug. If somebody finds an example please inform me (e.g. by emailing me a bookmark file where the problem occurs).

2. The firefox code for removing a certain bookmark id removes might be buggy and remove the wrong (or more than 1) bookmark (e.g. the bookmark id is not unique as it should be). Possible, but I consider this also quite unlikely.

Edit: For testing 1 (b), it might be useful to use bookmark-dupes-2.4, because this version displays the number of marked bookmarks (you do not have to actually remove bookmarks for counting...).

This version is currently only in the master branch (and you have to load it with about:debugging), because I will wait some days for the spanish and chinese translation before publishing it on mozilla.

"Empty Folders" doesn't consider as empty, folders containing empty folders, the only way to detect them is to first remove/move the folders inside first.

It would be nice if it was recursive.