Giter VIP home page Giter VIP logo

ksp-planetshine's Introduction

ksp-planetshine's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

ksp-planetshine's Issues

Settings handling need rework

Settings loading and saving need more error checking, and handling of value not previously present in the settings file.

Rename or move README.txt

This mod can be extracted into the top-level directory since everything writes to GameData -- except Alternate Colors and README.txt. The README.txt should go in the GameData/PlanetShine directory along with the LICENSE -- or at the very least be renamed to PlanetShine-README.txt to avoid collisions with other mods.

Complete overhaul of the atmospheric ambient light system

right now it's only controlled by two simple gradient, one for the atmospheric light, and one for the PlanetShine.

There should be more options, and we might want a stronger atmospheric light on low altitude than on the ground.

Possible issue with Kopernicus rings

See forum post: http://forum.kerbalspaceprogram.com/threads/109753-1-0-2-SKY-Scale-up-Kerbalism-for-You-Includes-a-2nd-Gas-Giant-v1-5-beta?p=1919557&viewfull=1#post1919557 :

http://imgur.com/a/GQR1H#0

THIS is an album showing quickly what's going on for me with the non-EVE syterion rings. It's possible it's a result of planetshine? I havn't snipped out my mods yet and troubleshot to figure out the exact result, i had originally just presumed it was a known issue.
You can see the essence of what happens: The rings are only visible from certain camera angles, and fade away or are even invisible at certain angles. The other rings are the EVE rings

PlanetShine tries/fails to parse DistantObject configs

I assume this is some legacy code. PlanetShine tries parsing the CelestialBodyColor nodes used by DistantObjectEnhancement, and it logs a lot of errors (trapped exceptions from a try/catch block). I realize these are handled exceptions, and they're not really errors, but I think it'd be better not to try to parse CelestialBodyColor nodes so the log doesn't clutter with

[ERR 09:32:28.927] [PlanetShine] An exception occured reading CelestialBodyColor node:
CelestialBodyColor
{
    name = Bop
    color = 100,86,76
}

The exception was:
System.ArgumentNullException: Argument cannot be null.
Parameter name: s
  at System.Double.Parse (System.String s, NumberStyles style, IFormatProvider provider) [0x00000] in <filename unknown>:0 
  at System.Single.Parse (System.String s) [0x00000] in <filename unknown>:0 
  at PlanetShine.ConfigManager.LoadBody (.ConfigNode bodySettings) [0x00000] in <filename unknown>:0 

(and so forth, once per world).

Settings presets, supporting Module Manager

I want to provide a convenient way for the user to switch between different presets according to his needs (streaming/recording, realistic).

Presets will be provided by individual preset config files and loaded across the whole GameData folder, allowing other mods/plugins to provide their own presets.

Whenever an external mod/plugin provides a new preset, the user will be prompted to ask if he wants to switch to this new one or keep his previous one.

Purple Cubes in 1.9

In the latest version - 1.9, random purple cubes and squares appear in the game. They normally stay where they spawn, with the exception of the squares which seem stuck to kerbals and obscure most of the IVA view.

Icon does not display during flight

I am running 1.1.0 now and I get a white square in my toolbar instead of the icon which I saw in 1.0.5.

The app appears to work fine, just some missing art.

Incorrect use of vacuumAmbientColor for atmospheric ambient

vacuumAmbientColor should be used strictly for vacuum ambient color: currently it's used while landed or in low altitude to provide global atmospheric illumination.

The issue is that when switching in map view, all celestial bodies are affected by this same vacuumAmbientColor.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.