Comments (5)
Let's put this behind a new option for backwards compatibility. Some projects might use both for user input and then they expect a boolean returned instead of an error.
So isHash would get an option bag which consists of validateAlgorithm
. I would recommend setting the default to true, and then people can set it to false if they don't want this new validation
from validator.js.
Let's put this behind a new option for backwards compatibility. Some projects might use both for user input and then they expect a boolean returned instead of an error.
So isHash would get an option bag which consists of
validateAlgorithm
. I would recommend setting the default to true, and then people can set it to false if they don't want this new validation
Can you please add an enhancement label to this issue and assign it to me?
from validator.js.
Let's put this behind a new option for backwards compatibility. Some projects might use both for user input and then they expect a boolean returned instead of an error.
So isHash would get an option bag which consists of
validateAlgorithm
. I would recommend setting the default to true, and then people can set it to false if they don't want this new validation
so, if validateAlgorithm is set to true, should the function throw an error saying "Invalid algorithm" and return false?
from validator.js.
If it's set to true it should throw an Error, if it's set to false it will return false (the current behaviour)
from validator.js.
@WikiRik
PR for enhancement suggested. Please review.
#2296
from validator.js.
Related Issues (20)
- isLocale doesn't work anymore (returns true on wrong locals) HOT 4
- Add support uuid v7 for `isUUID` HOT 3
- isURL() returns false for long urls HOT 6
- The isDate function returns false for some timezones (e.g. North American time zones) HOT 2
- fix: Date is not validated as expected HOT 3
- Email validator accepts special character "ΒΈ" which should not be valid HOT 7
- Enhance assertion check for function "equals" HOT 2
- readme.md toBoolean function documentation typo HOT 4
- No Active Maintainers? New Maintainers Needed? How to Proceed? HOT 11
- `isISO8601` doesn't support duration HOT 3
- isEmail accepts &@<domain> HOT 3
- Inconsistent isSlug results with "." in the inputs HOT 2
- "Cannot find module" error for lib or es/lib modules HOT 4
- isDate returns false for all strings HOT 10
- extended ascii passed isEmail validation HOT 1
- isEmail does not reject emails when blacklisted_chars includes quote
- get list of supported countries for passports HOT 2
- Invalid URL get validated HOT 2
- "Cannot find module './util/assertString'" since 13.12.0 HOT 2
- π§: Stale Prs HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from validator.js.