isLocale doesn't work anymore (returns true on wrong locals) about validator.js HOT 4 OPEN

This is due to #2189
With that, can you figure out why it accepts those strings and what we need to change to fix it if that behaviour is incorrect?

from validator.js.

I'm not an expert on regexp.
But your 'language' rule seems way too permissive :

const language = (([a-zA-Z]{2,3}(-${extlang})?)|([a-zA-Z]{5,8}));

I admire the fact you want to manage these locales with regexp, but I've got the feeling rules are too complex to handle it like that. Result is that isLocale returns true for many strings that are not locale at all...

Storing all locales (at least some part to build them) in an array could seem ugly and absurd at first, but well, it handles every specific rules and edge cases... that you don't manage with regexp.

from validator.js.

as mentioned by @WikiRik , it seems that the #2189 changes seem to have included language with generic language acceptance, as you mentioned, so if this need to be changed, will be happy to help regarding this. @sbatezat

from validator.js.

Obviously it needs to be changed.
To fix the fact isLocal() calls was not working with every good string (#2100) you made it working for almost every bad string...

from validator.js.