Giter VIP home page Giter VIP logo

harbourmaster-sso-drupal8-plugin's People

Contributors

chrfritsch avatar chriskcu avatar delic-r avatar hereandnow avatar

Stargazers

avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

radovandelic burdamagazinorg

harbourmaster-sso-drupal8-plugin's Issues

Failing configuration check

Before Drupal tests are executed active site configuration is validated. Since latest released version (8.1.1-beta4) of harbourmaster module has broken schema definition, all Drupal tests with enabled module are failing.

Here is stacktrace:

    There was 1 error:
    
    1)
    Drupal\Tests\[awesome_tests]\Functional\InstalledConfigurationTest::testInstalledConfiguration
    Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
    harbourmaster.settings with the following errors:
    harbourmaster.settings:sso_cookie_lifetime missing schema
    
    /.../core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:95
    /.../core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
    /.../core/lib/Drupal/Core/Config/Config.php:227
    /.../core/lib/Drupal/Core/Config/ConfigInstaller.php:334
    /.../core/lib/Drupal/Core/Config/ConfigInstaller.php:134
    /.../core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
    /.../core/lib/Drupal/Core/Extension/ModuleInstaller.php:248
    /.../core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /.../core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:419

I have found that there is commit that fixes problem (23e9f87), but it's not pushed to drupal.org and it's not released (tagged).

Can you please push mentioned commit to drupal.org and make new release of module? So that tests on Drupal project with enabled harbourmaster module can be executed.

Incompatible with Drupal 8.4

It seems that the upgrade of Drupal's libraries break the functionality of the current Harbourmaster integration. For example, Drupal 8.4 uses a different major version of jQuery than Drupal 8.3 does.

We receive the following errors on the login page since the upgrade to Drupal 8.4:

This page was loaded non-securely in an incognito mode browser. A warning has been added to the URL bar. For more information, see https://goo.gl/y8SRRv.
libs.js:2611 Uncaught TypeError: Cannot set property 'dragstart' of undefined
    at libs.js:2611
    at Array.forEach (<anonymous>)
    at n (libs.js:2605)
    at libs.js:2611
    at t (libs.js:2603)
    at t (libs.js:2603)
    at t (libs.js:2603)
    at t (libs.js:2603)
    at libs.js:2613
    at libs.js:2613
app.js:22 Uncaught TypeError: Cannot set property 'confirmation/confirmation' of undefined
    at app.js:22
jquery.min.js?v=3.2.1:2 jQuery.Deferred exception: Cannot read property 'translations' of undefined TypeError: Cannot read property 'translations' of undefined
    at HTMLDocument.<anonymous> (http://msg.dev/modules/contrib/harbourmaster/js/loginLauncher.js?oyuiz2:318:90)
    at j (http://msg.dev/core/assets/vendor/jquery/jquery.min.js?v=3.2.1:2:29999)
    at k (http://msg.dev/core/assets/vendor/jquery/jquery.min.js?v=3.2.1:2:30313) undefined
r.Deferred.exceptionHook @ jquery.min.js?v=3.2.1:2
jquery.min.js?v=3.2.1:2 Uncaught TypeError: Cannot read property 'translations' of undefined
    at HTMLDocument.<anonymous> (loginLauncher.js?oyuiz2:318)
    at j (jquery.min.js?v=3.2.1:2)
    at k (jquery.min.js?v=3.2.1:2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.