vaskivskyi / asusrouter Goto Github PK

How to use this? there are no examples or README has very limited information

Newer devices (e.g. RT-AX88U) have a different limit on traffic count than 4 GB, as it was before (e.g. RT-AC66U)

Either a list of known devices should be implemented, or this data should be fetched from the device automatically

If not implemented, this will result in large spikes in the calculated speeds when the value overflows

Bug reported in Vaskivskyi/ha-asusrouter#16

CPU temperature is not working on Netgear R6300V2 router running Merlin 380.70

^Above does not match what I have from my router's /ajax_coretmp.asp:

curr_coreTmp_2_raw = "44°C";
curr_coreTmp_2 = (curr_coreTmp_2_raw.indexOf("disabled") > 0 ? 0 : curr_coreTmp_2_raw.replace("°C", ""));
curr_coreTmp_5_raw = "47°C";
curr_coreTmp_5 = (curr_coreTmp_5_raw.indexOf("disabled") > 0 ? 0 : curr_coreTmp_5_raw.replace("°C", ""));
curr_coreTmp_cpu = "58";

It's actually curr_coreTmp_cpu rather than curr_cpuTemp

I have not checked whether this applies to: (a) stock Asus, or (b) Merlin specific or (c) customization specifically made for Netgear devices. Although (c) seems highly unlikely.

Thanks for your awesome ha integration anyway!

I was looking for a way to post a change to the router login with this API and saw there is not support for submitting a GET to chpass.cgi which allows for changing username and password for the router login.

Hi,

Thank you for this wonderful library. I tried running the example script and enabling/disabling parental controls, and everything worked like a charm with my Asus-Merlin AXE-16000.

I am trying to toggle internet access to the whole network and there is a setting for it in parental controls, called 'Enable block all devices", however, I do not see any way of toggling it through this project. Is there a way this functionality can be supported?

The device returns a value that is not yet implemented. Probably, 2.5G WAN/LAN

From Vaskivskyi/ha-asusrouter#15

Hello @Vaskivskyi,
I really like your library, as I want to do some automation with it (specifically switching back 5GHz Channels to DSF >100 if Radar-Detection swaps it with something like 36 / 40 and the like).

However I think I bumped into an error
data= loop.run_until_complete(router.async_get_data(AsusData.CLIENTS)
if I do the following

json.dumps(data)


Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.11/json/__init__.py", line 231, in dumps
    return _default_encoder.encode(obj)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/encoder.py", line 200, in encode
    chunks = self.iterencode(o, _one_shot=True)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/encoder.py", line 258, in iterencode
    return _iterencode(o, 0)
           ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/json/encoder.py", line 180, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type AsusClient is not JSON serializable

Any clues? Did I miss something?
Thank you,
Joachim

Hello!

I noticed when running examples from the documentation, that after calling router.async_disconnect(), there is a message printed to stdout:

async def gather_data(host, username, password, use_ssl):
    """Method to gether the known data"""
    # async with aiohttp.ClientSession() as session:
        # Initialize
    router = AsusRouter(
        hostname=host, username=username, password=password,
        use_ssl=use_ssl,
    )

    # Connect
    await router.async_connect()

    # Get the client list
    clients = await router.async_get_data(AsusData.CLIENTS)
    for client in clients.items():
        print(client)

    # Disconnect
    await router.async_disconnect()



if __name__ == '__main__':
    _host = "asusrouter.com"
    _username = "USERNAME"
    _passwsord = "PASSWORD"
    _use_ssl = False
    loop = asyncio.new_event_loop()
    loop.run_until_complete(gather_data(_host, _username, _password, _use_ssl))


>> Unclosed client session
>> client_session: <aiohttp.client.ClientSession object at 0x10ae37990>

Digging into it, it does not look like aiohttp.client.ClientSessions created by asusrouter.connection.Connectionfunctions are ever expressly closed.

This could be fine if the API required the user to explicitly create a new Session themselves in a context manager and pass that reference to the AsusRouter constructor, but the signature for AsusRouter shows session as being Optional with a default of None.

This also crops up if a user defined ClientSession is passed and then closed before another API call is made. For example, in Connection._make_post_request a new ClientSession is created if none exists or is closed,

        # Check if a session is available
        if self._session is None or self._session.closed:
            # If no session is available, we cannot be connected to the device
            _LOGGER.debug("No session available. Creating a new one")
            # We will create a new session and retry the request
            self.reset_connection()
            self._session = self._new_session()
            # Reconnect
            await self.async_connect()
            # Retry the request
            return await self._make_post_request(endpoint, payload, headers)

but this Session is outside of a user's control to close themselves and Connection does not close that session.

I might have missed some function that makes this a non-issue, in which case I would just ask that the documentation reflect this as an example :)

Hi,

Is there a way to use this to fetch usage information? This is the type of things in the "Traffic Analyzer" section of the webui:

Right now I'm doing some sketchy logic where I ssh to the router, fetch the /jffs/.sys/TrafficAnalyzer/TrafficAnalyzer.db file then locally fudge with it. Though was wondering if a more legit API exists.

Thanks!