The vavr-gson from vavr-io

vavr-gson's Issues

Project setup

great to have you onboard :)

In a first step we should setup the javaslang-gson repository first an initial commit.

You may take the javaslang-jackson project as template. It is a Maven layout. Or you may choose Gradle for the build - your call.

Please ask on any questions - I will assist you whenever possible.

Greets

- Daniel

When a class contains a field with a vavr interface type, e.g. Map, Gson can't deserialize it, as it needs a certain implementation of Map. Often a particular implementation (like HashMap) would be a good default for the majority of classes, so one could just register a TypeHierarchyAdapter using a HashMap to deserialize a Map field. Such TypeHierarchyAdapters could be part of the library (but not registered in VavrGson, just as additional helpers).

Serialization fails with Seq members

hi!

Serializing an object with Seq members serializes that object as empty list, even when the sequence has items in it:

import io.vavr.API.List
import io.vavr.collection.List
import io.vavr.collection.Seq
import io.vavr.gson.VavrGson
import org.junit.Test
import kotlin.test.assertEquals

class HelloTest {
    private val expected: String = "{\"ints\":[1,2,3]}"

    data class DataWithSeq(val ints: Seq<Int>)
    data class DataWithList(val ints: List<Int>)

    @Test
    fun testWithSeq() { // <- fails
        val data = DataWithSeq(List(1, 2, 3))
        assertEquals(expected, toJson(data))
    }

    @Test
    fun testWithList() {
        val data = DataWithList(List(1, 2, 3))
        assertEquals(expected, toJson(data))
    }

    private fun toJson(any: Any): String {
        val builder = GsonBuilder()
        VavrGson.registerAll(builder)
        return builder.create().toJson(any)
    }
}

testWithSeq fails with

org.junit.ComparisonFailure: 
Expected :{"ints":[1,2,3]}
Actual   :{"ints":{}}

i only tested it in kotlin not in java but since Seq seems not to be among the registered factories in Gson.factories it is probably not different there.

tested with

        <dependency>
            <groupId>io.vavr</groupId>
            <artifactId>vavr</artifactId>
            <version>0.9.2</version>
        </dependency>
        <dependency>
            <groupId>io.vavr</groupId>
            <artifactId>vavr-gson</artifactId>
            <version>0.9.2</version>
        </dependency>
        <dependency>
            <groupId>com.google.code.gson</groupId>
            <artifactId>gson</artifactId>
            <version>2.3.1</version>
        </dependency>

vavr-io / vavr-gson Goto Github PK

vavr-gson's People

Contributors

Stargazers

Watchers

Forkers

vavr-gson's Issues

Project setup

Add TypeHierarchyAdapters?

Serialization fails with Seq members

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent