vbartacek / audao Goto Github PK

Allow INSERT...SELECT... statements

INSERT INTO MyNewKind SELECT ... FROM MyOldKind WHERE ...

Keys with ids must be explicitly defined, otherwise new ids are generated:

INSERT INTO MyNewKind SELECT KEY('MyNewKind',KEY_ID(__key__)) as __key__ ...

What steps will reproduce the problem?
1. Create abstract class having enum type
2. Generate DAO impl
3. DAO Impl class cannot be compiled:

- no import for the DTO class
- the private enum mapping is present

What is the expected output? What do you see instead?
- the private enum mapping should not be present as it is not used

Inheritance works partially only for DTO classes,
but not for DAOs.

<table name="xy" extends="yz".../>

Reason: preprocess.xml - supercolumns do not work as expected.

Batch insert can speed-up applications especially for GAE.

Iterable<MyDto> dtos = ...;
Iterable<Long> ids = dao.insertAll( dtos );

ant test:
 [javac] /home/vaclav/work/gaudao/trunk/modules/distro/src/test/com/spoledge/audao/test/gae/GaeTest.java:886: findAllSblob(java.util.List<byte[]>) in com.spoledge.audao.test.gae.dao.GaeGqlSimpleDao cannot be applied to (java.util.List<<nulltype>[]>)
    [javac]         assertEquals( "sblob 1, 2", 2, dao.findAllSblob( Arrays.asList( sblob1, sblob2 )).length); 
    [javac]                                           ^
    [javac] 1 error

line 886:
assertEquals( "sblob 1, 2", 2, dao.findAllSblob( Arrays.asList( sblob1, sblob2 
)).length);

This error occusrs only when using Java 1.5, when using Java 1.6, then it is 
compiled ok.

java version "1.5.0_15"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_15-b04)
Java HotSpot(TM) Server VM (build 1.5.0_15-b04, mixed mode)

What steps will reproduce the problem?
1. abstract table A, normal table B having ref to A
2. create/drop tables script lists the foreign key B->A

What is the expected output? What do you see instead?
No foreign key created/dropped.

Currently all finders (findMany) return arrays.
Add an options to the config/dao to suport Lists.

Source:

  <table name="dto_issue_14">
      <comment>issue#14 - DaoImpl cannot be compiled - custom pk auto column</comment>
      <columns>
        <column name="custom_id" java="id">
          <type>int</type>
          <auto/>
          <pk/>
        </column>
      </columns>
    </table>

Generated as:
   ...
   dto.setId( rs.getInt( 1 ));

   return dto.getCustomId();


Expected:
   ...
   dto.setId( rs.getInt( 1 ));

   return dto.getId();

By changin order of checking for modifications and fetching the entity we can 
save one get call to the datastore.

GAE only issue.

<method>
  <delete>
    <pk/>
  </delete>
</method>

int count = dao.deleteByPrimaryKey( id );

Unit tests in distro/ module fail for GAE under GAE 1.6 (unknown exact first 
version when started to fail).

Using of deprecated API in GAE implementation - caching.

Cannot compile generated DAO/DAOImpl when setting Java name for column and 
using it in methods:

     <columns>
        ...
        <column name="i_vlogin" java="vendorLoginId">
          <ref table="VendorLogin"/>
          <not-null/>
        </column>
      </columns> 
     <indexes>
        <index name="inx_VendorTarget_login">
          <unique/>
          <columns>
            <column name="i_vlogin"/>
          </columns>
        </index>
      </indexes>
      <methods>
        <find name="byVendorLoginId">
          <index name="inx_VendorTarget_login"/>
        </find>
      </methods>

generated code:

    public VendorTarget findByVendorLoginId( int iVlogin ) {
        return findOne( "i_vlogin=?", vendorLoginId);
    }

What steps will reproduce the problem?
1. Generate mysql DAO from table with following column:
<column name="bondOrder">
<type max-length="1">String</type>
<enum>
<value>S</value>
<value>D</value>
<value>T</value>
</enum>
<not-null/>
</column>


What is the expected output? What do you see instead?
In DTO impl it creates 
    public enum BondOrder {
        S,
        D,
        T
    }
with getter 
    public MoleculeBond.BondOrder getBondOrder() {
        return bondOrder;
    }

and in insert DAO method adds 
stmt.setString( 4, dto.getBondOrder().ordinal() + 1 );
instead of 
stmt.setString( 4, dto.getBondOrder().toString() );
in select DAO method
dto.setBondOrder( _MoleculeBond_BondOrders[ rs.getString( 5 ) ]);
instead of
dto.setBondOrder( BondOrder.valueOf(rs.getString( 5 )));

What version of the product are you using? On what operating system?
1.5

Please provide any additional information below.
Either documentation should be updated and this bug renamed to feature, or 
support for enum sql datatype implemented.

Currently the default conversion is:

  XML: my_table_or_column_name

  Java: MyTableOrColumnName
  SQL (MySQL or Oracle database): my_table_or_column_name
  GQL (GAE datastore): MyTableOrColumnName

The Java name can be explicitly set now, but nobody can set the GAE datastore's 
name. The problem is with special names like "_ah_session"