unimplemented keywords: 'flags' and 'nlink' (for tar archives) about go-mtree HOT 10 OPEN

why closed?

On Mon, Jul 25, 2016 at 10:27 PM, Stephen Chung [email protected]
wrote:

Closed #40 #40.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#40 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEF6bRDiaBb1RoU1JpX4Eum7E35lzFkks5qZXB5gaJpZM4JUp6x
.

from go-mtree.

I realized there's a lot of other keywords not implemented, so I thought it'd make more sense to discuss which unimplemented keywords need attention, rather than just pointing out one.

from go-mtree.

I could re-open and edit this issue accordingly if you want

from go-mtree.

With regard to "important" keywords, and to align with upstream mtree, 'flags' and 'nlink' (tar archive only) are keywords that should be looked at next.

from go-mtree.

sure thing. It's a good thing to implement these keywords. Though having them be included in the default set may not be needed. Especially ones like nlink, as technology like ostree use hardlinks heavily, so the nlink on disk will almost always be different on anything given host.

from go-mtree.

nlink is already implemented

from go-mtree.

yeah but for tar archives we would have to manually keep track of links

from go-mtree.

oh i see. yeah, keeping track of hardlinks in tar archives is more work

from go-mtree.

nlink keyword implemented for tar archives, although nlink for directory Entry's have not been implemented.

from go-mtree.

I've just stubbed flags, but we can hold on these still.

from go-mtree.