[bug] digest validation only happening when specified about go-mtree HOT 5 CLOSED

need to make sure all keywords found in a manifest are evaluated, unless the caller uses the -k flag option to reduce keywords to check

from go-mtree.

This is something I was considering while writing in #48. The other issue is if we have -k set to something which doesn't already exist in the manifest. IMO we should be defaulting to the set of keywords in the spec rather than the Default{Tar,}Keywords if -f is set.

from go-mtree.

fair. Perhaps we can use the logic from the -list-keywords flag to detect
keywords first.

On Tue, Nov 1, 2016 at 9:00 PM, Aleksa Sarai [email protected]
wrote:

This is something I was considering while writing in #48
#48. The other issue is if we
have -k set to something which doesn't already exist in the manifest. IMO
we should be defaulting to the set of keywords in the spec rather than the
Default{Tar,}Keywords.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#64 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEF6YTCOgapRhGszWtveIAs5p-o2w94ks5q5-DCgaJpZM4JiYmJ
.

from go-mtree.

I've done something like that in #48: https://github.com/vbatts/go-mtree/pull/48/files#diff-e8b2d04ec2884011801582c86d040d36R188. But I can make a new PR where we default to CollectUsedKeywords and then make modifications to the default as per usual?

from go-mtree.

This was fixed by #92

from go-mtree.