Comments (2)
would an individual check for the "time" keyword in check.go be too ugly? based off of how we actually test the file spec keyval against the actual file, it doesn't seem like string comparison can fully resolve this issue.
this also brings me to the idea of defining/implementing KeyVal checks for each keyword, so that instead of doing if string(kv) != curKeyVal
, we can call something along the lines of checkKeywordFunc(kv,curKeyVal)
. I'm not sure how most KeyVal checks would differ from a string comparison, though, but this would avoid cluttering in check.go if we need to do some specific testing on keywords and possibly allow for flexibility and more accurate validation. thoughts?
from go-mtree.
@Stephen679 i think string comparison is fine. The issue here was fairly simple.
from go-mtree.
Related Issues (20)
- [BUG] xattr: new xattrs are not noticed in Compare
- [BUG] xattr: spaces in extended attribute keys fail
- SElinux xattrs are context sensitive
- Vis and Unvis break on UTF-8 HOT 6
- vis: move govis to library and rewrite it HOT 9
- `type=device` should be `type=block` HOT 1
- chokes on `gname=` HOT 1
- the time and tar_time keyword funcs can be collapsed together.
- mtree no longer detects xattr changes HOT 5
- simple plain code api to create DirectoryHierarchy HOT 4
- InodeDelta comparison of FullType doesn't line up HOT 5
- release? HOT 2
- The option of specifying the option `-f` twice is not implemented HOT 2
- SIGSEGV: segmentation violation code
- ACL changes failed veification
- [RFE] switch flag parser to `github.com/urfave/cli/v2`
- bug: listing keywords for a hierarchy from stdin
- USAGE description requires command while it isn't requirement HOT 2
- update description
- FR: Ability to manipulate mtrees HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-mtree.