Giter VIP home page Giter VIP logo

Comments (2)

imsteev avatar imsteev commented on June 12, 2024

would an individual check for the "time" keyword in check.go be too ugly? based off of how we actually test the file spec keyval against the actual file, it doesn't seem like string comparison can fully resolve this issue.

this also brings me to the idea of defining/implementing KeyVal checks for each keyword, so that instead of doing if string(kv) != curKeyVal, we can call something along the lines of checkKeywordFunc(kv,curKeyVal). I'm not sure how most KeyVal checks would differ from a string comparison, though, but this would avoid cluttering in check.go if we need to do some specific testing on keywords and possibly allow for flexibility and more accurate validation. thoughts?

from go-mtree.

vbatts avatar vbatts commented on June 12, 2024

@Stephen679 i think string comparison is fine. The issue here was fairly simple.

from go-mtree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.