Combine the editor instances about editor HOT 10 CLOSED

Yeah, maybe. The issue is that react will re-create the component instead of reusing the editor we already have. This is one of the most important issues we have right now. I would love to support undo across different modes for example.

from editor.

Just to explain this a bit more. The problem is that react recreates components when a subtree of the dom changes. This means we recreate the monaco editor instance in some case and erase the (undo) history.

from editor.

We have fixed the issue when the Vega editor instance is opened side by side with Vega-Lite. However, switching from Vega to Vega-Lite and vice versa or opening examples still creates a new editor.

from editor.

@domoritz On switching from vega to vega-lite, we can just change the editorString right? This is how this issue can be solved right?

from editor.

Oh okay. You mean undo can be done even if we switch editors?

from editor.

It can't right now because we create a new Monaco instance.

from editor.

Yeah right. I'll try to fix this issue.
What I am thinking is that we just change editorStrings. This will prevent from creating a new instance and also undoing will be possible. I'll look into it and let you know the progress soon

from editor.

Great. It's a bit tricky to do but shouldn't be impossible.

from editor.

I have unassigned this issue to myself so others can also take a look.

from editor.

We support undo/redo across modes now.

from editor.