• Don't rely on a service.
• Clean up the validation. The regexes are too complicated and not accurate (suggested by @zhirzh).

It would be nice to have a searchable tree-structure of the documentation within the Vega editior.

Sometimes wish to have detailed information next to the spec while playing around.

Using https://github.com/facebookincubator/create-react-app

Submitting the 'add by gist' form with empty field causes this error

Also, there's no validation on it currently to check whether the submitted data is actually an URL.

Since Vega 3.2 now ships typings with them. We don't need to import them anymore.

[at-loader] ./node_modules/vega-lite/build/src/index.d.ts:26:25
TS2307: Cannot find module './package.json'.

Press tab while not focused on the editor:

Too often, we accidentally navigate back and lose the work. We should either make sure to not immediately save to local storage or show a warning.

From vega/vega-lite#1811

This is a very minor issue, but it nevertheless trips me up when I'm reading JSON generated by Vega-Lite: why does the Vega JSON generated by Vega-Lite drop spaces between object attributes? The current scheme causes visual grouping of unrelated things.

Instead of this: {"type": "filter","expr": "datum.year == 2000"}
I would expect output like this: {"type": "filter", "expr": "datum.year == 2000"}

Note that this is a bug in a stringify method that I modified from JSON3 three years ago!

After vega/vega-embed#66.

See vega/vega-lite#3603

See https://docs.google.com/document/d/1YKBzT-aTrKGxA-G6ktzRSIC-ihc3JCWmNW5k7OL85nA/edit#heading=h.h1iauva9hmtp and look at https://twitter.com/mathisonian/status/973628667854123009 for an idea of what this could be like.

@mathisonian might have some suggestions for how we can implement this.

See vega/vega#1192 for a bug report indicating that Vega's pivot transform is not accessible in the current editor. This sounds like an error in which modules may not have been properly updated before creating a deployed bundle.

Depends on #36

From https://github.com/vega/vega-editor/issues/184

Instead of taking gist type directly from the user, we can get its type from $schema (or any method) then render according to it. I think we should remove gist type.
OR
Let's take gist type input, now if we select different type than the actual gist then it should show error on modal itself.

Looking forward to any suggestions, which one should be implemented?

This will allow users to easily create high-def graphics by printing a PDF of the page.

We could improve the UI based on some inspiration from https://webassembly.studio/.

Made in https://app.moqups.com/[email protected]/lkfmF6icEv/edit/page/aa1276c8b

The editor re-formats specs in some situations. That is not good if the user customized the format.

Probably introduced with #40

This example does not show hover effects (highlighting objects in red):

https://vega.github.io/editor/#/examples/vega/bar-chart

When creating a new viz, the user should be redirected to /custom/:mode and the editor should reset, except if the user is on /edited.

However, when the user is on /edited, the editor does not reset but does get redirected. This is inconsistent with the behaviour of creating a new viz.

Should we stop redirecting the user? Thoughts?

From https://github.com/vega/vega-editor/issues/191

We would like

• Better error messages
• Links to the editor from an error

When we toggle Tooltips option vega.View gets re-initialized thus loses interaction states.

P.S: I would like to self-assign this issue.

Look at https://github.com/tajo/react-portal. I'd like our modals to close on esc and click outside.

Right now every time I run git pull on this repo, I run into this kind of error:

error: Your local changes to the following files would be overwritten by merge:
	public/data/gapminder-health-income.csv
	public/data/income.json
	public/spec/vega-lite/index.json
	public/spec/vega-lite/interactive_panzoom_vconcat_shared.vl.json
	public/spec/vega-lite/layer_area_ci.vl.json
	public/spec/vega-lite/layer_bar_labels.vl.json
	public/spec/vega-lite/layer_candlestick.vl.json
	public/spec/vega-lite/layer_connected_scatterplot.vl.json
	public/spec/vega-lite/layer_error_bars.vl.json
	public/spec/vega-lite/layer_error_bars_dev.vl.json
	public/spec/vega-lite/layer_falkensee.vl.json
	public/spec/vega-lite/layer_global_mean_dev.vl.json
	public/spec/vega-lite/layer_histogram_global_mean.vl.json
	public/spec/vega-lite/layer_ranged_dot.vl.json
	public/spec/vega-lite/layer_rect_extent.vl.json
	public/spec/vega-lite/layer_text_heatmap.vl.json
	schema/vl.schema.json
Please commit your changes or stash them before you merge.
error: The following untracked working tree files would be overwritten by merge:
	public/spec/vega-lite/bar_aggregate_transform.vl.json
	public/spec/vega-lite/bar_color_disabled_scale.vl.json
	public/spec/vega-lite/bar_custom_sort_full.vl.json
	public/spec/vega-lite/bar_custom_sort_partial.vl.json
	public/spec/vega-lite/circle_natural_disasters.vl.json
	public/spec/vega-lite/geo_choropleth.vl.json
	public/spec/vega-lite/geo_circle.vl.json
	public/spec/vega-lite/geo_layer.vl.json
	public/spec/vega-lite/geo_layer_line_london.vl.json
	public/spec/vega-lite/geo_line.vl.json
	public/spec/vega-lite/geo_point.vl.json
	public/spec/vega-lite/geo_repeat.vl.json
	public/spec/vega-lite/geo_rule.vl.json
	public/spec/vega-lite/geo_text.vl.json
	public/spec/vega-lite/geo_trellis.vl.json
	public/spec/vega-lite/interactive_multi_line_tooltip.vl.json
	public/spec/vega-lite/layer_bar_annotations.vl.json
	public/spec/vega-lite/layer_line_co2_concentration.vl.json
	public/spec/vega-lite/line_inside_domain_using_clip.vl.json
	public/spec/vega-lite/line_inside_domain_using_transform.vl.json
	public/spec/vega-lite/line_outside_domain.vl.json
	public/spec/vega-lite/point_invalid_color.vl.json
Please move or remove them before you merge.
Aborting

and have to manually reset the repo before pulling again.

See vega/vega#1099

Ideally --hot --inline should work but it's not apparently.

Right now we create new monaco instances when we open the vega spec in vl mode. This prevents undo/redo.

Maybe using https://github.com/lyft/react-javascript-to-typescript-transform

We should do this after #2

This could be useful

The project was built assuming it is hosted at /editor/.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
To publish it at http://vega.github.io/editor, run:

  yarn add --dev gh-pages

Add the following script in your package.json.

    // ...
    "scripts": {
      // ...
      "predeploy": "npm run build",
      "deploy": "gh-pages -d build"
    }

Then run:

  yarn run deploy

Find out more about deployment here:

  http://bit.ly/2vY88Kr

Currently, most users won't know how to use the console to debug unless they read https://vega.github.io/vega/docs/api/debugging/.

Providing some affordance that this documentation exists is probably helpful.

It appears whenever there is an error in the console, which sounds like a good idea.

But this means it disrupt my typing flow all the time! (When I'm typing a spec, esp. expression, it would lead to console error all the time.)

From https://github.com/vega/vega-editor/issues/215

This is probably an issue with monaco.

From https://github.com/vega/vega-editor/issues/190

It can currently be quite difficult to debug Vega and Vega-Lite because the sources are minified. Even with sourcemaps, it is quite tedious.

Ideally, we minifiy all dependencies except for Vega and Vega-Lite.

As of now, the codebase doesn't follow any coding style-guide and isn't consistent in writing. I recommend using something like prettier for automatic code formatting. Once in place, it can be integrated with editors for automatic format checks "on save".

@apollonian11

https://github.com/vega/vega-themes

right now, we hard code which schemas are used for completion. We completely ignore the schema from the spec. This is not good.

To understand this issue, use a specific version of the schema and note how completion doesn't work anymore.

See vega/vega-embed#55

Basically, when we get a spec via post message, we should use try to resolve URLs as a) absolute, b) relative to the editor, c) relative to the caller. This can be implemented by creating a custom vega loader.