veliovgroup / josk Goto Github PK

I have a suggestion:

The finial bit before I can use this library is missing the type declaration file.
The JSDoc is very clear in usage, but TypeScript doesn't pick that up.

I have a question:

1. why update before delete in __clear?

  __clear(uid) {
    this.collection.updateOne({
      uid: uid
    }, {
      $unset: {
        executeAt: '',
        inProgress: ''
      }
    }, (error) => {
      if (error && this.onError) {
        this.onError('[__clear] [updateOne] [error]', {
          description: 'Error in a callback of .updateOne() method of .__clear()',
          error: error,
          uid: uid
        });
      }

      this.collection.deleteOne({
        uid: uid
      }, mongoErrorHandler);
    });

    if (this.tasks && this.tasks[uid]) {
      delete this.tasks[uid];
    }
    return true;
  }

2. how about just delete in __clear?

 __clear(uid) {
  try {
      this.collection.deleteOne({
        uid: uid
      });
  } catch(error) {
      if (error && this.onError) {
        this.onError('[__clear] [updateOne] [error]', {
          description: 'Error in a callback of .updateOne() method of .__clear()',
          error: error,
          uid: uid
        });
      }
  } finally{
    if (this.tasks && this.tasks[uid]) {
      delete this.tasks[uid];
    }
    return true;
  }
}

Hi,

I'd like to update a task that already exists.
As this doesn't seem to be possible, my current workaround is to remove a task if it already exists and recreate it with the new values.

Firstly I wonder why it's necessary to append "setTimeout" / "setInterval" to the task uid?
Wouldn't it be better to be able to access a task with the uid it was actually created with?
Alternatively it would be nice to maybe have something like an exposed generateUid method so that I don't have to append setTimeout manually (for the case this logic might change later)..

Secondly removing a task and recreating it within the same Meteor method doesn't work.
(I think it's what you mean with "Should be called in a separate event loop").
I guess I could trigger the same Meteor method after deleting the task, but I'm not sure if this would even work and it feels kinda error-prone..

It does work if I do it manually, but I'm pretty sure that's bad practice:

const existingJob = job.collection.findOne({uid: `${taskId}setTimeout`});
if (existingJob) job.collection.remove({uid: `${taskId}setTimeout`});
...
job.setTimeout(task, diff, taskId)

Is there a proposed solution to achieving this?

I launch the task within the onLogin handler.
The task logic depends from logged in user.
Is there some way for getting logged-in user within the task?

I have tried do:

Meteor.userId()

and got error

Exception in callback of async function: Error: Meteor.userId can only be invoked in method calls or publications.

Is there some way getting logged in user?

If noway I see the following approach: to set a flag for the user in the Users collection before scheduling the task
Meteor.users.update({_id: loggedInUser._id}, {$set: {updateMeInTask: true}})

and drop this flag within the task?

Or may be is possible to pass a text value to the task?

v3.1.0 causes a big issue with our deployment, josk is a peer dep of mail-time. You should use a major version if you suddenly change its module format.

Installing 3.0.2 fixes my issue

Current version of Josk and so mail-time does not support mongodb v5 and higher. Callbacks for findBy are not supported anymore.