veltman / csvgeocode Goto Github PK

I was looking to geocode a file that contained "Villeneuve d'Ascq, France", and the script found "Strada Villeneuve D' Asq, Gorj, Romania".

For some reason the apostrophe was encoded to an HTML numeric entity and caused this problem and the death of many squirrels 🐿.

I fixed it for this specific case with

url = url.replace(/'/, " ");

but maybe mustache has an option for removing html codes or transcoding them properly to utf8.

I can send a PR if you like, but I'm not sure of he scope of the problem or the best way to fix it.

Would be great if we had an argument for defining a different delimiter, like a semicolon.

Here's the original data:

address
0 JFK AIRPORT JAMAICA 11430
0 jfk airport queens 11430
0 JFK INT'L AIRPORT JAMAICA 11430
0 JFK INTERNATIONAL AIRPOR JAMAICA 11430
0 JFK INTERNATIONAL AIRPORT JAMAICA 11430
0 JFK INTL AIRPORT JAMAICA 11430

Running with: csvgeocode addresses.csv addressesGeo.csv --url="https://maps.googleapis.com/maps/api/geocode/json?address={{address}}" --handler=google --verbose

address,undefined
0 JFK AIRPORT JAMAICA 11430,-74.8987696
0 jfk airport queens 11430,-74.8987696
0 JFK INT'L AIRPORT JAMAICA 11430,-74.8987696

Running with: csvgeocode addresses.csv addressesGeo.csv --url="https://maps.googleapis.com/maps/api/geocode/json?address={{address}}" --handler=google --verbose --lat=lat --lng=lng

address,lat,lng
0 JFK AIRPORT JAMAICA 11430,40.123,-74.8987696
0 jfk airport queens 11430,40.123,-74.8987696
0 JFK INT'L AIRPORT JAMAICA 11430,40.123,-74.8987696

Might be something to do with the single column.

(side note, I got an error without the explicit --handler=google option)

Throttling requests via queue-async concurrency would be a nice alternative/complement to the --delay switch. Maybe could be specified via --concurrency <N>. Will see if I can find time to add it....lib works great, thx @veltman!

Maybe I missed something, but it would be cool to use streams/pipes. And not because they are all the rage. The specific use case is that if I have a file with 5000 addresses and I want to geocode with Google, I'll run into the 24 hour limit. It would be great to do a run that saves what has been done so that I can come back to it later and finish it.

I am pretty sure an = is needed in arguments:

--url=thing

The documentation does not have this. My commands would not work without it.

Also, awesome module!

When used with fields that contain double quotes and therefore are escaped by prepending those with an escaping backslash this backslash gets broken and Excel, Libreoffice and other editors interpret those double quotes as field ends.
This might be more like an issue with dsv but noteworthy nonetheless even if you can't fix it within csvgeocode.

Hi,

I getting this error when using mapbox geocoder.

csvgeocode.js:161
} else if ("lat" in result && "lng" in result) {
^

TypeError: Cannot use 'in' operator to search for 'lat' in undefined
at handleResponse (C:\Users\argenis\AppData\Roaming\npm\node_modules\csvgeocode\src\csvgeocode.js:161:25)
at Request._callback (C:\Users\argenis\AppData\Roaming\npm\node_modules\csvgeocode\src\csvgeocode.js:133:9)
at Request.self.callback (C:\Users\argenis\AppData\Roaming\npm\node_modules\csvgeocode\node_modules\request\request.
js:199:22)
at emitTwo (events.js:87:13)
at Request.emit (events.js:172:7)
at Request. (C:\Users\argenis\AppData\Roaming\npm\node_modules\csvgeocode\node_modules\request\request.js
:1036:10)
at emitOne (events.js:82:20)
at Request.emit (events.js:169:7)
at IncomingMessage. (C:\Users\argenis\AppData\Roaming\npm\node_modules\csvgeocode\node_modules\request\re
quest.js:963:12)
at emitNone (events.js:72:20)

When I use the url in the browser I get.

{"type":"FeatureCollection","query":["maracaibo"],"features":[{"id":"place.15865","type":"Feature","text":"Maracaibo","place_name":"Maracaibo, Zulia, Venezuela","relevance":0.99,"properties":{},"bbox":[-71.7817466,10.582766,-71.586462,10.7688503],"center":[-71.6407,10.6436],"geometry":{"type":"Point","coordinates":[-71.6407,10.6436]},"context":[{"id":"region.5652266462607880","text":"Zulia"},{"id":"country.13795682694360550","text":"Venezuela","short_code":"ve"}]},{"id":"place.15864","type":"Feature","text":"Maracaibo","place_name":"Maracaibo, Valle del Cauca, Colombia","relevance":0.99,"properties":{},"bbox":[-76.5181048,3.4174864,-76.5159618,3.4195548],"center":[-76.517063,3.418486],"geometry":{"type":"Point","coordinates":[-76.517063,3.418486]},"context":[{"id":"region.13115541496430840","text":"Valle del Cauca"},{"id":"country.8835466213820440","text":"Colombia","short_code":"co"}]},{"id":"address.3991858998015520","type":"Feature","text":"Rua Maracaibo","place_name":"Rua Maracaibo, Santo André, São Paulo 09250, Brazil","relevance":0.79,"properties":{},"center":[-46.520427,-23.623473],"geometry":{"type":"Point","coordinates":[-46.520427,-23.623473]},"context":[{"id":"place.24117","text":"Santo André"},{"id":"postcode.1287776102566740","text":"09250"},{"id":"region.6056669612838220","text":"São Paulo"},{"id":"country.17318012316682710","text":"Brazil","short_code":"br"}]},{"id":"address.3219787327733630","type":"Feature","text":"Privada Maracaibo","place_name":"Privada Maracaibo, Ecatepec de Morelos, México, Mexico","relevance":0.79,"properties":{},"center":[-99.016035,19.593392],"geometry":{"type":"Point","coordinates":[-99.016035,19.593392]},"context":[{"id":"place.7221","text":"Ecatepec de Morelos"},{"id":"region.5989025148456720","text":"México"},{"id":"country.11735183656773450","text":"Mexico","short_code":"mx"}]},{"id":"address.9663854498015520","type":"Feature","text":"Rua Maracaibo","place_name":"Rua Maracaibo, Porto Alegre, Rio Grande Do Sul 91225, Brazil","relevance":0.79,"properties":{},"center":[-51.1345179,-30.0127374],"geometry":{"type":"Point","coordinates":[-51.1345179,-30.0127374]},"context":[{"id":"place.20332","text":"Porto Alegre"},{"id":"postcode.11986695081151740","text":"91225"},{"id":"region.4633809344890480","text":"Rio Grande Do Sul"},{"id":"country.17318012316682710","text":"Brazil","short_code":"br"}]}],"attribution":"NOTICE: © 2016 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained."}

Any help?

I'm trying to geocode this file:

street,city,zip,latitude,longitude
123 E. Main St.,Charlottesville,22902,,

With this command:

$ csvgeocode --url "http://geoservices.tamu.edu/Services/Geocode/WebService/GeocoderWebServiceHttpNonParsed_V04_01.aspx?apiKey=abcdefghijklmnopqrstuvwxyz&version=4.01&streetAddress={{street}}&city={{city}}&state=VA" test.csv

It's failing, with this error:

/usr/local/lib/node_modules/csvgeocode/src/csvgeocode.js:161
    } else if ("lat" in result && "lng" in result) {
                        ^
TypeError: Cannot use 'in' operator to search for 'lat' in undefined
    at handleResponse (/usr/local/lib/node_modules/csvgeocode/src/csvgeocode.js:161:25)
    at Request._callback (/usr/local/lib/node_modules/csvgeocode/src/csvgeocode.js:133:9)
    at Request.self.callback (/usr/local/lib/node_modules/csvgeocode/node_modules/request/request.js:344:22)
    at Request.emit (events.js:110:17)
    at Request.<anonymous> (/usr/local/lib/node_modules/csvgeocode/node_modules/request/request.js:1239:14)
    at Request.emit (events.js:129:20)
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/csvgeocode/node_modules/request/request.js:1187:12)
    at IncomingMessage.emit (events.js:129:20)
    at _stream_readable.js:908:16
    at process._tickCallback (node.js:355:11)

I'd figured that result isn't defined because the file can't be opened, but running in verbose mode precedes the above error with this:

123 E. Main St.,Charlottesville,22902,
Parsing error: SyntaxError: Unexpected number

I don't know what's up with the SyntaxError, but the point is that it is retrieving the first data line from the file.

I'm running Node v0.12.0.

Any ideas?

Add a maxFailures option so that if there are more than X consecutive failures, it stops running (so that if, e.g., you're over an API's limit for the day, it doesn't try another 1000 rows).

row handler only seems to run after, not before, geocoding.

Just to confirm that https://geocode.earth/ the drop-in replacement of mapzen† pelias geocoder worked for me

csvgeocode addresses.csv --verbose --url "https://api.geocode.earth/v1/search?api_key=ge-XXXXXXXX&text={{address}}" --handler mapzen

We may want to rename or alias a few things in the documentation and handler's names.

My interwebs dropped in the middle of a batch. Oh no! The whole process is hanging.
Suppose this should also be configurable via a commandline switch.

https://github.com/request/request#timeouts

Instead of formatting/dumping the results at the end, output the results as a stream, line-by-line.

The Google geocoder can return REQUEST_DENIED, which csvgeocode will display if --verbose argument is given, but additional info from the error message returned by Google's API is not being shown.

Adding that information to the output from csvgeocode would make it easier for users to quickly debug why the Google geocoder isn't returning the expected results.

For example, here's what I see now:

$ csvgeocode --verbose --url "https://maps.googleapis.com/maps/api/geocode/json?address={{City}},{{State}}&key=YOUR_KEY_HERE" input.csv output.csv

8/19/00,NM,Carlsbad,Pipeline rupture and explosion; 12 deaths,el paso,

REQUEST_DENIED

Rows geocoded: 0
Rows failed: 1
Time elapsed: 1.3 seconds

If we add a check for REQUEST_DENIED in handlers.js, like so:

    else if (response.status === "REQUEST_DENIED") {
      return "Request denied: " + response.error_message;
    }

we get more useful info when running csvgeocode:

$ csvgeocode --verbose --url "https://maps.googleapis.com/maps/api/geocode/json?address={{City}},{{State}}&key=YOUR_KEY_HERE" input.csv output.csv

8/19/00,NM,Carlsbad,Pipeline rupture and explosion; 12 deaths,el paso,

Request denied: This IP, site or mobile application is not authorized to use this API key. Request received from IP address 200.200.200.201, with empty referer

Rows geocoded: 0
Rows failed: 1
Time elapsed: 1.2 seconds

Which tells me that the request was denied because of an issue with the IP address I'm on, so I know I need to change the settings for the Google Geocoder API key -- much more helpful than just 'request denied'. After updating the allowed IP addresses, it works fine:

$ csvgeocode --verbose --url "https://maps.googleapis.com/maps/api/geocode/json?address={{City}},{{State}}&key=YOUR_KEY_HERE" input.csv output.csv

8/19/00,NM,Carlsbad,Pipeline rupture and explosion; 12 deaths,el paso,32.4206736,-104.2288375

SUCCESS

Rows geocoded: 1
Rows failed: 0
Time elapsed: 1.5 seconds