veltzer / openbook Goto Github PK

It's placement makes it look like it's part of the list of page numbers.

Thanks for this project but I'm not sure I can get off the ground with it. I just wanted to let you know of a few problems I ran into trying to get the build system to work, which may be representative of problems other people have.

I'm running Ubuntu 14.04 which has Python 3.4. Maybe there's something simple I can do, but system is unfamiliar and at this point I really can't tell. It is nice just to have the song pdf's, though, and even if I don't get things going I can find some other way to plumb the mako files for the .ly source (one reason for looking at this is to get up to speed coding jazz standards with Lilypond.

1. The main readme says I can run ./scripts/ubuntu_install.py to install necessary packages, but I was unable to find any script with that name.
2. I eventually discovered that I needed to install the 'templar' module, found that info here at github in issues section but didn't notice it in the docs.
3. After getting some errors, I manually went through install_deps.py, install2_deps.py, and install3_deps.py in templar package. It downloaded a couple of modules. It gave 404 errors for the sample files from the veltzer website, so I ended up commenting out those lines.
4. When I run tdefs.py in /usr/share/templar/templardefs manually I get an empty file. I assume this means something's not right.

5. When I run 'make' examples I get error message below, and checking manually I find that the get_mod_list() function returns an empty list:

Traceback (most recent call last):
File "/usr/bin/templar_cmd", line 15, in
templar.cmdline.cmdline()
File "/usr/lib/python3/dist-packages/templar/cmdline.py", line 97, in cmdline
print(' '.join(templar.api.get_all_deps()))
File "/usr/lib/python3/dist-packages/templar/api.py", line 67, in get_all_deps
for m in get_mod_list():
File "/usr/lib/python3/dist-packages/templar/api.py", line 49, in get_mod_list
m=ml.load_module()
AttributeError: 'NoneType' object has no attribute 'load_module'
doing [out/tools.stamp]
Traceback (most recent call last):
File "/usr/bin/templar_cmd", line 15, in
templar.cmdline.cmdline()
File "/usr/lib/python3/dist-packages/templar/cmdline.py", line 89, in cmdline
d=templar.api.load_and_populate()
File "/usr/lib/python3/dist-packages/templar/api.py", line 54, in load_and_populate
for m in get_mod_list():
File "/usr/lib/python3/dist-packages/templar/api.py", line 49, in get_mod_list
m=ml.load_module()
AttributeError: 'NoneType' object has no attribute 'load_module'

make: *** [out/tools.stamp] Error 1

How do we get it?!?

• count the number of pages in the pdf (some kind of pdf parser?!?).
• count the number of images created when --png is used.

(@veltzer)

Possibly related to #48
I think Lilypond tells you how many pages it has used in it's output. Maybe we could parse that?

I've started this.

From @veltzer's TODO file.

Given the current ideology, this should be a compile-time option right? If so we can merge it into #49

I am unable to locate the templar package on Ubuntu; I installed templar using pip3 install templar, but it seems to be name-coincidence and no what is really needed --

Makefile:1: /usr/share/templar/make/Makefile: No such file or directory

I am running Ubuntu 14.10. Googling /usr/share/templar/make/Makefile only returns pages of this or related projects. What is happening?

I'm trying to compile a single song file with Lilypond. I get the syntax error "unexpected UNSIGNED" for the assignments to youtube variables, e.g.:

idyoutuberemark1="Original from Kind of Blue"
idyoutube1="PoPL7BExSQU"
idyoutuberemark2="Bill Evans in a piano version"
idyoutube2="mW_7gRH7ASE"

The error is caused because my Lilypond (v. 2.16.2) has restrictions on use of numbers in variable names. 2.16.2 is the version available in my Ubuntu repository, so far as I know wouyld require manual installation if I wanted more recent version, and I can't find anything in Openbook docs that says I need more recent version.

Does more recent Lilypond fix this error, or is it in fact due to something else I"m not seeing?

On another note, I've developed a farly simply awk script (180 lines with comments, no outside packages or utilities required, other than Lilypond) that handles the compilation of song files with templates into valid .ly files, requiring just some simple changes to the main template file 'common.ly.mako' and no changes at all to the song files. It seems to be a heck of a lot simpler than the Python system currently being used, and has advantage of being non-confusing and easily installable on Windows, LInux, Mac, if it's not there by default. I'm polishing up a bit and may extend it to do most or all of the file creation stuff that's done in the current Make system.

From @veltzer's TODO file.

Probably the first step here would be to create a test.

From @veltzer's todo

👍 I agree, at least for the composer and poet. This is something that should be very doable with the data we have and would be very valuable.

As per https://github.com/veltzer/openbook/blob/master/Makefile#L1

I don't want to mindlessly submit a PR if it's necessary for you, but at least as an FYI it does block using make out of the box. I can remove the line myself and then make debug_me does show the env, or so it seems. But in any case it's more of an FYI than anything too substantiative.

Feel free to close this.

This repo is nice. Great work, thank you!

From @veltzer's TODO file.

Probably the first step would be to create a test.

You seem to be using a lot of different tools to do things you can do within LilyPond directly.

Have you never seen a multi-directory, multi-file LilyPond project that can be built a number different ways? Here's an example: https://github.com/mrbeany/shipping-containers

It's from an art-album I did a while back. I wanted it to be easy to re-use, so it only depends upon LilyPond. It can be built one of five different ways out-of-the-box (Fakebook, SATB, MIDIs, A4 Songbook and Letter Songbook), plus any of the pieces of sheet music can be built adhoc.

I mean, a basic LilyPond templating/Mako replacement can be done by using LilyPond variables and a common "LilyPondLogic.lyi" include. That common file can check for global variables and adjust things right there.

I've seen the issues users have with some of the dependencies. I'm sure you have other people who would be potential users, but they get frustrated without commenting. You can get rid of all of the dependency issues.

It's a LilyPond project. There's no reason for outside dependencies.

From @veltzer's TODO.

I assume this means to make sure Lillypond warnings are shown when using make. This would help my workflow quite a bit. 👍

I'm working on an adaption of the OpenBook where I render the sheet-music especially for the LinnStrument.
Which looks like this:

Are you interested to include this here, or shall I simply crate a separate repository?

I managed to miss all the docs. It might be worth mentioning them in the README.

Examples:

• Eich Hu Shar/Danny Robas
• As Time Goes By/Herman Hupfeld

I don't understand what's ugly about this.

This is a great project; much thanks for all of the great work. Might you consider adding a symbol key in a future revision? It would help us newer jazz cats.

We disabled the double bar at the end of each section because it was breaking repeats at the end of sections, but we also removed the thick double-bar at the end of each song. Was this interfering with repeats at the end of songs?

If no, we should re-enable them because we need a thick double bar at the end of each tune, if yes, what are our other options?

Note: They were removed in commit e0133b4

Occasionally the \marks can be in a position where it's hard to distinguish them from chord names. Lilypond can easily create rehearsal marks with a circle or square around them, but according to this documentation that's only when you use \mark \default.

The only way I can think to implement this would be to replace every instance of \mark with some user defined function. Maybe someone else has another idea?

Would it be possible (or is it already possible) to compile copies in Bb, Eb, and bass clef? I feel Lilypond should allow this relatively easily, but I'm not familiar enough with the structure of this project to know for sure.

P.S. Thanks for an amazing resource! :-)

Getting the following error on make:

ImportError: cannot import name 'ParamCreator' from 'pytconf.config' 

Looks like the import in wrapper_lilypond.py should be:

from ParamCreator.param import ParamCreator

we don't want to rely on both python and perl - one is enough - @veltzer

A good first step for someone to take would be to compile a list of the current perl scripts.

see this docco http://lilypond.org/doc/v2.18/Documentation/notation/repeats-in-midi

Also thanks for this - it's awesome.

Hi! How I can get musicxml files from openbook?

See notes in #32

Probably not an issue but rather a sign of me being a lilypond newbie. One of the main benefits of openbook for me would be the possibility to easily transpose the songs to other keys. Is that possible, and if so, how?

How I can convert mako file to lilypond for open it in Frescobaldi or in any other editor?

It might be nice to use GitHub issues instead of the TODO text file. This might encourage others to work on these issues and submit pull requests. At the very least it would enable people to comment on the issues with suggestions or votes of encouragement.

I realize that this would increase your dependency on GitHub which you may not be interested in. If that is the case, feel free to dismiss this suggestion.

Some tunes have parenthesized notes at the end, and some just have the turnaround chords in the last few measures. Others have explicit first/second endings.

I think the explicit alternate ending for the first time (turnaround) and the last time (end) is much cleaner. I propose that all tunes that include turnarounds should be notated that way.

If you agree, I would be willing to work on cleaning up those tunes that don't yet fulfil that requirement.

https://sites.google.com/site/jpgzic/home/demonstration
http://lists.gnu.org/archive/html/lilypond-user/2013-03/msg00647.html
https://sites.google.com/site/jpgzic/home
and the email I got from vicent (vincent). - @veltzer

I prefer the current notational style, but I'm not terribly opposed. Would make a great compile time option.

I misunderstood what this did and used it incorrectly. I will check my tunes and remove instances where it's inappropriate.

From @veltzer's TODO file

Probably the first step would be to create a test.

From @veltzer's todo.

This seems to be in conflict with issue #37. Which would you like to do?

I think the chords for the Gershwin tune Summertime could be improved. However, I know this is might be a tricky issue as harmonizations are ultimately a matter of preference. In this particular case the chords would change about twice a measure and I think the new chords would be an obvious improvement.

What is your policy for things like this? Are you interested in pull requests refining and improving harmonizations? I don't want to step on your toes.

Thanks for all your work on this project. As you can probably tell I've become very excited about it and am eager to help. I hope my flood of pull requests has not overwhelmed you.

This project is so exciting. I was actually just looking for a lilypond file of Summertime for a student 'cause I was (or thought I was) in a rush. Came across github.com/tj64/org-bandbook, which lead me here.

I'm on a Mac. Ran under python3 -v Python 3.7.7 with the built-in venv: python3 -m venv openbook, cd openbook, source bin/activate, make. Got the above error somewhere in rendering the rock book:

$ tree docs -L 2
docs
├── build
│   ├── pdf.js
│   ├── pdf.js.map
│   ├── pdf.worker.js
│   └── pdf.worker.js.map
├── drumming.ly
├── drumming.pdf
├── drumming.ps
├── favicon.ico
├── guitar_album.ly
├── guitar_album.pdf
├── guitar_album.ps
├── index.html
├── israeli.ly
├── israeli.pdf
├── israeli.ps
├── openbook.ly
├── openbook.pdf
├── openbook.ps
├── rockbook.ly
├── rockbook.pdf
├── rockbook.ps
└── web
    ├── cmaps
    ├── debugger.js
    ├── images
    ├── locale
    ├── viewer.css
    ├── viewer.html
    ├── viewer.js
    └── viewer.js.map

Rock book TOC:

Ain't No Sunshine / Bill Withers 3 
Baby One More Time / Max Martin 4 
Creep / Radiohead 5 
Days Like This / Van Morrison 6 
Forever Young / Alphaville 7 
I Am Beautiful / Linda Perry 8 
Lucky Man / Greg Lake 9 
Shape of My Heart / Sting, Dominic Miller, Sting 10 
Talkin' Bout A Revolution / Tracy Chapman 11

Here is the full traceback:

Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py", line 179, in <module>
    main()
  File "/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py", line 175, in main
    config_arg_parse_and_launch()
  File "/Users/mikekilmer/Music/Lilypond/openbook/lib/python3.7/site-packages/pytconf/config.py", line 485, in config_arg_parse_and_launch
    launch=launch, args=args, app_name=app_name,
  File "/Users/mikekilmer/Music/Lilypond/openbook/lib/python3.7/site-packages/pytconf/config.py", line 368, in config_arg_parse_and_launch
    function_to_run()
  File "/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py", line 153, in run
    system_check_output(['qpdf', '--linearize', ConfigAll.pdf, t.name])
  File "/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py", line 61, in system_check_output
    pr = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 800, in __init__
    restore_signals, start_new_session)
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 1551, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'qpdf': 'qpdf'
make: *** [docs/rockbook.pdf] Error 1

When I moved the docs directory and ran make again, it errored out sooner:

$ make
doing [docs/openbook.ly]
doing [docs/openbook.pdf]
/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py: stderr is
warning: compressing over-full page by 1.5 staff-spaces
warning: page 16 has been compressed

/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py: return code is [0]
/Users/mikekilmer/Music/Lilypond/openbook/scripts/wrapper_lilypond.py: error in executing ['lilypond', '--loglevel=WARNING', '--ps', '--pdf', '--output=docs', 'docs/openbook.ly']
make: *** [docs/openbook.pdf] Error 1

Using LilyPond 2.19.82. Going to try upgrading and see if that helps.

Store page numbers and have an extract program to extract the right pages from a collection of real books which is out of the git tree. @veltzer

Do you have an idea where the new files would live? Another repo? A web-server? Your local hard-drive?

From @veltzer's TODO file.

From @veltzer's TODO file.

A minor problem, but sometimes I set the terminal LANG to C to print messages in english instead of my locale. This is the error when I run make:

$ make
doing [out/openbook.ly]
Traceback (most recent call last):
  File "scripts/wrapper_mako.py", line 101, in <module>
    raise e
  File "scripts/wrapper_mako.py", line 65, in <module>
    filelist=list(filter(is_ready,filelist))
  File "scripts/wrapper_mako.py", line 16, in is_ready
    for line in open(file):
  File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd7 in position 7024: ordinal not in range(128)
Makefile:390: recipe for target 'out/openbook.ly' failed
make: *** [out/openbook.ly] Error 1

right after a git clone, i am running make in the openbook root directory and get the following error

make
doing [out/openbook.ly]
Traceback (most recent call last):
File "scripts/mako_book.py", line 38, in
template=mako.template.Template(filename=common,lookup=mylookup,output_encoding=output_encoding,input_encoding=input_encoding)
File "/usr/lib/pymodules/python2.6/mako/template.py", line 93, in init
(code, module) = _compile_text(self, file(filename).read(), filename)
File "/usr/lib/pymodules/python2.6/mako/template.py", line 257, in _compile_text
node = lexer.parse()
File "/usr/lib/pymodules/python2.6/mako/lexer.py", line 152, in parse
if self.match_control_line():
File "/usr/lib/pymodules/python2.6/mako/lexer.py", line 304, in match_control_line
raise exceptions.SyntaxException("Invalid control line: '%s'" % text, *self.exception_kwargs)
mako.exceptions.SyntaxException: Invalid control line: '% end verbatim - this comment is a hack to prevent texinfo.tex' in file 'src/include/common.makoi' at line: 2 char: 1
make: ** [out/openbook.ly] Fehler 1

i wonder if this error is related to to the following errors (german ubuntu)

make check_all
doing [check_empty_copyright]
make: [check_empty_copyright] Fehler 1 (ignoriert)
doing [check_ws]
doing [check_and]
make: [check_and] Fehler 1 (ignoriert)
make: [check_and] Fehler 1 (ignoriert)
doing [check_extra_files]
doing [check_min_chords]
make: [check_min_chords] Fehler 1 (ignoriert)
doing [check_uuid]
doing [check_chordChanges]
make: [check_chordChanges] Fehler 1 (ignoriert)
doing [check_bar]
make: [check_bar] Fehler 1 (ignoriert)
doing [check_break]
make: [check_break] Fehler 1 (ignoriert)
doing [check_completion]
doing [check_include]
make: [check_include] Fehler 1 (ignoriert)
doing [check_threeunderscores]
make: [check_threeunderscores] Fehler 1 (ignoriert)

I am not familiar with mako... I suppose some project initialization is missing after git clone, but which?

I noticed that when I generate a single pdf of the Ave Maria I have typeset, it still has your name in the "Typeset by" field in the footer. Is there a field I need to fill in for that?

The song "Cantaloupe Island", though present in the src directory, is not included in the final openbook.pdf file.
After quick inspection, it seems that its mako file has a very specific structure, using part=="Own" instead of "Chords/Lyrics/etc"...
Is this a bug or is it normal (i.e.: should the source file cantaloupe_island be fixed) ?

This looks like a great project with a lot of potential. I am also a big believer in free software and the open source ideals but

I did not want to pay for the overly expensive real or fake books out there.

and

Jazz is a prime example of a free type of art so it's conjunction with free software seems a match made in heaven.

are not good arguments to publish copyrighted music. IANAL but making the melodies of tunes available to the general public without proper licensing is probably a bad idea. So my question is, what is the legal status here? Can I savely fork from your repository and contribute without fearing legal problems myself?

Hi @veltzer

great project, let's see if I can contribute. But before I need to make it.

This is for ubuntu, but I'm using debian jessie stable
https://launchpad.net/~mark-veltzer/+related-packages

I hope that with pip we facilitate the others to run make without problems. I don't know how to get the source to compile myself (if there are requirements), but if templar is a python thing, I propose to have it as a pip package (I never did that, but I think it is very easy) pip3 install templar_openbook (templar is a python package already).

Please, help, this way, we can be more people building openbook

The system will allow users to config which type of tune they want to produce.
They could select:

• scale (C for concert, Bb, Eb for horns etc).
• do they want lyrics?
• font sizes from several configurations and more.
• do they want to produce midi, postscript, pdf, mp3, ogg.
• what tunes do they want to build.
• Display half-dim 7th chords as m7b5 or slashed circles?
• Use a jazz font or traditional font?
• If a tune has more than one version then which version to build?
• ability to select all tunes by a certain composer at one go...
• ability to select all tunes by a certain poet at one go...

(@veltzer)

I know this is something @veltzer is currently very interested in, and I think it's an important part of this project. Have you done any planning on how you would implement this? Are you expecting to have users make it on their own machine? Could we have this be a web interface?

There are a number of other issues that deal with what options should be presented to the user. If we want to merge those issues into this one, I can update this list as it grows.

The make file defaults to using git calls and find calls to get the filenames.

Please consider using $(wildcard) instead. You don't need to fork an external process. (It's a GNU extension, but you're already using ${filter} and ${subst}, so you're already using GNU extensions.)

Right now, you need to check for the .git directory before trying to run the git ls and git grep commands. Since this isn't done, it just totally breaks if you download the ZIP instead of cloning it.

From the todo tunes file.

I've started this

Reduce sizes of staffs, space between staff and more - @veltzer

Could we implement a test that checked which tunes spilled over onto multiple pages? That would be a great way to keep confidence that this important layout issue is take into consideration when making global layout changes like song footers/titles etc.