veqryn / cidr-ip-trie Goto Github PK

Hi,
Thanks for your project. We have built a wrapper of the library to be OSGi compliant. Do you want a PR in your project with this build?
Regards.

hi，I want to know why mask can't be 0
eg, Cidr4 myCIDR1 = new Cidr4("0.0.0.0/0");

Hi，I have two questions:

• The default route seems can be the root node, why filter it out ?
• What's the purpose of not setting the privateKey when the node it is put into the trie firstly ？

I like the idea of keeping multiple CIDRs in a data structure optimized to search it, but what I really need is a fast way to check an IP address against a set of CIDRs. I thought that was the whole point of using a Trie to store CIDRs so you could easily just walk the prefix tree to find the CIDR that an IP address might be within.

However, I don't see any methods like isInRange() on Trie to support that. So does that need to be written or is there another way to check IP membership that I don't see?

Currently it is impossible to access the address field through the getSortableInteger() method because it is protected. It is also impossible to subclass the Ip4 class because it is final.

Hey, I saw that IPv6 support was on your roadmap. I'm attempting to use your library to increase the speed of logstash-filter-cidr, which is currently VERY slow, but does support IPv6. What would it take to add support not just for IPv6, but also generic v4/v6 ip type and trie?

The use case is that the user may provide a list containing both IPv4 and v6 CIDRs to match, and events to be matched may contain addresses of either type as well. We would need to be able to build a trie containing both types, and make queries using address of either type.

Support for IPv4-mapped IPv6 addresses would also be nice (::ffff:192.168.0.0/120 matches 192.168.0.1)