Giter VIP home page Giter VIP logo

nebula-common's People

Contributors

aiee avatar amber1990zhang avatar andychow01 avatar ayyt avatar boshengchen avatar bright-starry-sky avatar cpwstatic avatar critical27 avatar czpmango avatar dangleptr avatar darionyaphet avatar dutor avatar guojun85 avatar jievince avatar laura-ding avatar liuyu85cn avatar monadbobo avatar nevermore3 avatar panda-sheep avatar sherman-the-tank avatar shylock-hg avatar sophie-xie avatar spacewalkman avatar w41ter avatar wadeliuyi avatar yixinglu avatar zhangguoqing avatar zlcook avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nebula-common's Issues

mkdir: cannot create directory '/opt/vesoft/third-party': Permission denied

follow this topic: https://docs.nebula-graph.io/2.0/4.deployment-and-installation/2.compile-and-install-nebula-graph/1.install-nebula-graph-by-compiling-the-source-code/#cmake-variables

to compile source code of the master branch, and an error occurred.

Downloading vesoft-third-party-x86_64-libc-2.17-gcc-7.5.0-abi-11.sh...
mkdir: cannot create directory '/opt/vesoft/third-party': Permission denied
-- CMAKE_INCLUDE_PATH              : 
-- CMAKE_LIBRARY_PATH              : 
-- CMAKE_PROGRAM_PATH              : 
-- GLIBC_VERSION                   : 2.17

CMake Error at modules/common/cmake/FindBzip2.cmake:31 (message):
  Bzip2 doesn't exist
Call Stack (most recent call first):
  modules/common/cmake/nebula/ThirdPartyConfig.cmake:77 (find_package)
  CMakeLists.txt:93 (include)


-- Configuring incomplete, errors occurred!
See also "/home/xxx/nebula-graph/build/CMakeFiles/CMakeOutput.log".

Comparing between time types.

This is not a correct way to compare the time, when the timezone is being considered.

    bool operator==(const DateTime& rhs) const {
        return year == rhs.year &&
               month == rhs.month &&
               day == rhs.day &&
               hour == rhs.hour &&
               minute == rhs.minute &&
               sec == rhs.sec &&
               microsec == rhs.microsec &&
               timezone == rhs.timezone;
    }

Expression could return `Value` directly and don't need to set the eval result to the private data member `result_`(

Currently, eval() of expression returns a const value&. And most expressions store the result that evaled to a result_ and then return it to the caller. The caller most often picks it up with a copy of the value.

virtual const Value& eval(ExpressionContext& ctx) = 0;
 Value val = col->expr()->eval(ctx(iter.get()));

So this caused two copy overhead.
The reason why most of the callers use copy of value to pick the evaled result is some of the expressions don't store the evaled result to result_:

const Value& InputPropertyExpression::eval(ExpressionContext& ctx) {
    return ctx.getInputProp(prop_); // The value returned comes from the valueMap of ExecutionContext, so it shouldn't be moved by the caller
}

Moreover, it is a bit strange to store the evaled result that is only valid for the current row to the expression class.

We could let eval() return a Value and don't need to store the evaled result to result_.
Meanwhile, AggregateExpression is special. It's not stateless, so it should store the evaled result to result_.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.