vgno / coding-standards Goto Github PK

We have https://github.com/vgno/coding-standards/blob/master/javascript/README.md#const-keyword in place now.

Should we not allow the const keyword?

IMHO we should allow more ES6 features now on a general basis. Maybe a separate issue?

In our .eslintrc there is a rule "consistent-return": 2.
http://eslint.org/docs/rules/consistent-return.html

Do have any idea what this kind of code works in our project? :

.catch(err => {
    if (err instanceof NotFoundError) {
        return reply(Boom.notFound(err.message));
    }
    reply(err);
});

Here is more important question: why after upgrading to eslint 2.1.0 it is an error and only changing it to this will work:

.catch(err => {
    if (err instanceof NotFoundError) {
        reply(Boom.notFound(err.message));
        return;
    }
    reply(err);
});

The only thing I found in Eslint changelog (https://github.com/eslint/eslint/blob/master/CHANGELOG.md) is:
Fix: consistent-return checks the last (refs #3530, fixes #3373) for v2.0.0-alpha-1 - December 11, 2015

Update the project to make it support the latest version of ESLint.

ESLint should also probably be added to peerDependencies to make sure it verifies to some extent that it gets the correct version.

Could you update Variable declaration section in https://github.com/vgno/coding-standards/tree/master/javascript#variable-declaration?

First of all you read as close as possible to the place where it's first used., on a new line and then var object = {}, key;. Doesn't make any sense, does it?

To make it faster you can copy recently updated text from: https://github.com/yandex/codestyle/blob/master/javascript.md#variable-declaration ;)

I wanted to send a PR but somehow I don't have permission.