viacominc / router Goto Github PK

@ollieatkinson were you able to run the tests in the swift 2.0 branch in xcode 7 beta 4?

https://github.com/Carthage/Carthage

Lets be able to compile this under cartharge

• Create a iOS Shared target
• Remove Quick & Nimble dependencies?
• Add umbrella header

See my example here:
https://github.com/ollieatkinson/Router/tree/swift-2.0-shared-scheme

The project needs a licence

https://travis-ci.org

This would help prevent branches which do not pass testing enter the codebase.

This will not prevent changes such as Xcode updating and breaking the build after it has been merged.

Since Xcode 7 is no longer in beta can we merge the code onto development?

Hello Viacom team,

Is there a way to deep-link to support section page routing with the below implementation using a link URL like this: /dashboard#section-page2

open func match(_ url: URL) -> DeeplinkRoute? {

        guard let routeComponents = URLComponents(url: url, resolvingAgainstBaseURL: false) else {
            return nil
        }

        // form the host/path url
        let host = routeComponents.host.flatMap({ "/\($0)" }) ?? ""
        let path = routeComponents.path //.flatMap({$0}) ?? ""
        let routeToMatch = "\(host)\(path)"
        let queryParams = routeComponents.queryItems
        var urlParams = [URLQueryItem]()

routerapp://route/one/abc123?string=您好

Create public pod spec

Could you please push a new release (preferably label it 2.0.0 as will include breaking changes) to CocoaPods? Right now I have to explicitly point my Podfile at a specific commit in the repo. Give me a shout if you need a hand, happy to help.