Giter VIP home page Giter VIP logo

Comments (3)

allmarkedup avatar allmarkedup commented on May 21, 2024

Thanks for this @afomera - the navigation and search is definitely high up on the list of things to improve. There is another issue open with some rough thoughts on nav/search improvements, and including example titles in the filter is definitely one of them.

Looking at your example, It would also be nice to be able to specify where in the namespace to start the nav tree from (i.e. skip the Podia::UI part altogether). I'll add that to the list.

However quite why the first item ends up in its own list is an odd one - definitely a bug. I'll try to figure out why that might happen.

from lookbook.

allmarkedup avatar allmarkedup commented on May 21, 2024

Out of interest, would you want the examples for each preview sorted alphabetically too? My preference is to match the order I've defined them in the preview class, but that could quite easily be a configuration option.

from lookbook.

afomera avatar afomera commented on May 21, 2024

Thanks @allmarkedup , sorry I missed that other issue. I'm sorta mixed, if it respected the order it was defined in the preview class that'd work (I may be wrong, but it doesn't seem to do this now), otherwise falling back to alphabetical order by example would be great imo, we can classify stuff ourselves that way.

TBH, we have a ton of namespaces (IE so Podia::UI is not the only one in the Podia tree), so I'm not sure if we'd want to use it, as our team has decided things in Podia::UI are 'dumb' base components we one day when we're a larger team may extract to a new gem, but have other folders and namespaces inside of them.

from lookbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.