first_project's Issues
Layout + styles
-
https://github.com/Viklysx/testrep/blob/588e806661f3d063ab0320f65d554e0326a4b45f/styles/style.css#L122
Вот этот стиль перебивает стиль основного контейнера и у вас слетает центровка блока. -
https://github.com/Viklysx/testrep/blob/588e806661f3d063ab0320f65d554e0326a4b45f/index.html#L45
Хорошее переиспользование стилей, ноsub
- неприемлемое имя для класса. Совершенно непонятно что оно означает. Лучше всего обозначить какbtn-transparent
или типа того -
https://github.com/Viklysx/testrep/blob/588e806661f3d063ab0320f65d554e0326a4b45f/index.html#L47-L51
Следите за форматированием кода. -
https://github.com/Viklysx/testrep/blob/588e806661f3d063ab0320f65d554e0326a4b45f/index.html#L27
Сделайте телефон ссылкой
Slider
-
https://github.com/Viklysx/testrep/blob/343f0f6266fc2678e77fa60dcaee6d846247e11d/js/slider.js#L59
нужно classList.remove('active')
https://github.com/Viklysx/testrep/blob/343f0f6266fc2678e77fa60dcaee6d846247e11d/js/slider.js#L66
нужно classList.add('active') -
https://github.com/Viklysx/testrep/blob/343f0f6266fc2678e77fa60dcaee6d846247e11d/js/slider.js#L64
Нужно убрать эти проверки и передавать в функциюindex
вместоid
, т.е.
slide(index) {
sld_1.src = variants[index].img;
slides[index].classList.add("active");
...
}
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.