vinpasso / bridgempp-bot Goto Github PK

Also in ParrotBot.java line 58 you can remove the empty string from the stringbuilder's constructed as it also has an empty constructor.

All href links are using relative paths i.e. /wiki/Banana instead of http://en.wikipedia.org/wiki/Banana and are therefore useless

?calc 0x3e3
"0x3e3" = :1:1 Missing space after numeric literal 0xMath.E
^ in at line number 1 at column number 1

but the expected output would be:
995

Parrot bot name generation should be weighted in favor of vowels in order to make name generation more realistic

Throws an unknownhost exception
I would post a stacktrace but I cant seem to scroll back further on tmux

Just check if the values of the array after split are empty or not before adding/outputting.

Or replace all double spaces with single ones before splitting.

...instead of writing each line into an own message

IMO both bots should only use 1 package per bot as it clutters up the Packages list of IDEs (at least the package explorer from eclipse) if you have the following package list:

bots.CalcBot
bots.CalcBot.calc
bots.CalcBot.logger
bots.NewsBot
bots.NewsBot.logger
bots.NewsBot.news
bots.ParrotBot
bots.WikiHelpBot

Just annoying and can be abused ;)

Otherwise it may result in a little bit of overhead ;)