vint21h / nagios-check-hddtemp Goto Github PK

It would be great if this plugin could output critical and warning thresholds in performance data string.

Without it I am unable to show critical and warning lines in grafana, when chart is fed with data from icinga2 plugin.

Unable to Install nagios-check-hddtemp

Error in nagios-check-hddtemp setup command: package_data must be a dictionary mapping package names to lists of wildcard patterns

Install Log:

pip install nagios-check-hddtemp
Downloading/unpacking nagios-check-hddtemp
Downloading nagios-check-hddtemp-0.6.0.tar.gz
Running setup.py egg_info for package nagios-check-hddtemp
error in nagios-check-hddtemp setup command: package_data must be a dictionary mapping package names to lists of wildcard patterns
Complete output from command python setup.py egg_info:
error in nagios-check-hddtemp setup command: package_data must be a dictionary mapping package names to lists of wildcard patterns

Command python setup.py egg_info failed with error code 1 in /tmp/pip-build-root/nagios-check-hddtemp
Storing complete log in /root/.pip/pip.log

Expected Behavior

It should be possible to specify the thresholds (warning and critical temperature) as ranges.

Current Behavior

An error if thrown if you try, e.g.: error: argument -w/--warning: invalid int value: '35:40'

Steps to Reproduce

1. Call ./check_hddtemp.py -w 35:40 ....

Context (Environment)

I'm trying to set lower and upper limits, as too low temperatures can be a problem as well.

Detailed Description

The format plugins should(?) support is described here: https://nagios-plugins.org/doc/guidelines.html#THRESHOLDFORMAT

Expected Behavior

The output should (optionally) be altered in a way that the first line contains a short summary only, details can follow in subsequent lines.

Current Behavior

The output is a huge blob in a single line, in particular with a lot of disks and when using stable disk paths like /dev/disk/by-id/....

Context (Environment)

I do not know which environments this plugin targets, I can only speak for my setup using Icinga(web). Icingaweb shows the first line as plugin status, only if you click to see the details, all lines are shown. If everything is in one line, and with the current verbosity, it looks pretty bad, actually the layout is somewhat broken.

Possible Implementation

A new or alternative output could look like this:

OK/WARNING/CRITICAL: [maybe disk count], [maybe temperature/range y°C - z°C if there are non-sleeping devices], [maybe a short warning/count if something is wrong] <-- that line should be really short in particular if all is fine
<one line per disk, shouldn't probably be too verbose either>

Any plans to add perf data to this plugin? If not, I can try to hack it in and do a PR, but python isn't exactly where I'm a ninja.