vint21h / nagios-check-supervisord Goto Github PK

Hi,

Although we can patch it, we would love an option to return state critical when the connection is refused or timed out:

check_supervisord.py -s 127.0.0.1 -p 9001
ERROR: Server communication problem. [Errno 111] Connection refused
echo $?
3

Would be great if it was 2 instead of 3.

Unknown is not bad enough for us, on critical we take special actions, that is why. We saw other nagios checks supplying similar functionality trough a parameter.

If a program is "starting", currently the script will exit with a WARNING exit code. In most cases it may be desirable to accept a "starting" program as normal behaviour. Example:

WARNING: something curiously with 'example-api-client_01': (STARTING), 'example-api-client_00': OK, 'example-api-default_00': OK, 'example-api-default_01': OK, 'example-api-default_02': OK, 'example-api-high_00': OK, 'example-api-high_01': OK

Would it be possible to add an option for --starting-state-exit-code, in a similar fashion to --stopped-state-exit-code?

If no supervisord programs are defined, currently the script will exit with the UNKOWN exit code. I believe it may be useful to set the desired --no-progams-defined-status via an argument. In some cases it may be desirable to raise a WARNING or CRITICAL, in other cases it may be expected and thus should result in OK state.