Comments (2)
hayakawa16
commented on June 12, 2024
Found a bug in ROfFxDetector. The incrementing of TallyCount was occurring within the fx loop so that the resulting output was (number of fx) x (actual TallyCount).
Moved the incrementing line outside of loop.
from vts.
hayakawa16
commented on June 12, 2024
Since TallyCount was not part of any unit tests, I have now added the output of TallyCount to SimulationOutput for unit testing. I added unit tests for all detectors and found that T(fx) and Flu(x,y,z,omega) calculated TallyCount in error. I also found an inconsistency in the detector names in SimulationOutput Flu(x,y,z,omega) used to be called flu_xyzo, however, the rest of the detectors with omega dependence used "w" as the symbol for omega or flu_xyzw. So this output change was made.
from vts.
Related Issues (20)
- CI/CD - Github Actions to build Vts.sln and run Vts.Library.sln Tests upon PR submission
- Fix the SonarCloud issues in IForwardSover HOT 4
- Add ability to angle SurfaceFiberDetector
- Fix the 5 SonarCloud Bugs
- Fix bugs, security issues and maintenance issues in MCCL and MCPP
- Fix the bug in EllipsoidTissueRegion
- Reconfigure the detectors to use global code for the Binary Serializers HOT 65
- Fix the cognitive complexity issues from the Sonar Cloud analysis HOT 5
- Bug in 2 of the Detectors TransmittedMTOfXAndYAndSubregionHistDetector and ReflectedMTOfXAndYAndSubregionHistDetector HOT 2
- Preparation for the November release
- Vts Code and Scripting changes in preparation for Polyglot notebooks
- Add ability to use layered concentric infinite cylinders with refractive index mismatch HOT 2
- Move the FemModeling and MGRTE into a separate repository HOT 2
- Non-flat layered tissues for MCCL HOT 31
- Replace Moq with NSubstitute
- Add resiliency to CustomBinaryStreamWriterOfT HOT 1
- SDA forward solvers need check on optical properties to make sure solution is valid HOT 4
- .NET Polyglot Notebook and Jupyter Notebook samples HOT 17
- RangeOfT enhancements for simplicity to consumers HOT 8
- Publish static web hosted documentation to Github Pages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vts.