Giter VIP home page Giter VIP logo

avalonstudio.shell's Introduction

AvalonStudio.Shell

Reusable Shell components from AvalonStudio.

avalonstudio.shell's People

Contributors

flaviushouk avatar jmacato avatar jp2masa avatar lontivero avatar molnard avatar nitanmarcel avatar nopara73 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

avalonstudio.shell's Issues

Is the usage limited?

Is the usage of this limited in terms on who can use it? For example if I want to do my own app am I allowed to use this library? Not for commercial use of course.

Change the Extensions directory to be under the BaseDirectory

I created a Windows installer with Wix and I noticed that the software wasn't working. The reason being is that you can never work next to the exe, since that is located in the Program Files, which needs admin access and the software as launched it doesn't have that.

So, in AvalonStudio.Shell, the Extensions folder couldn't be created, thus the software failed to launch. The code below does this in AvalonStudio.

public static string ExecutionPath => Path.GetDirectoryName(Assembly.GetEntryAssembly().Location);

public static string ExtensionsFolder => Path.Combine(ExecutionPath, "Extensions");

I suggest changing the second line to this:

public static string ExtensionsFolder => Path.Combine(BaseDirectory, "Extensions");

Since I have no idea what that does, my question is: is it safe to change this? (I didn't test.)
Related issue: WalletWasabi/WalletWasabi#686

ModalDialogViewModelBase improvement

  • Make CancelCommand virtual

  • Add something like virtual OnShown or observable property. I would like to start my operations at that phase. Now if I create a dialog and call Close before the call of ShowDialogAsync then dialogCloseCompletionSource will generate NRE.

System.Reflection.TargetInvocationException after starting

All nuget packages have been restored after cloning repository. .net Core 2.2 is installed and all single projects of the solution build without any error message but when i try to start the example app then an exception is throwing!

grafik

Sample app needs update after Dock update

Right now there's a problem with View location, as it tries to find view by string replacement in AvaloniaStudioDocumentTab type name from DockExtensions.

I'm interested in this project and may help with development, but since the sample app doesn't really work, it's hard to get a grip of functionality.

While at it, I think a NuGet.config with appropriate feeds added would be nice, since otherwise this project can't be built from fresh clone.

Aaand there's no License. :)

Awesome work!

There is no Theme.xaml file

There is no such theme in AvalonStudio.Shell/Themes/ folder

which is needed in ShellExampleApp/App.paml for example.

Another problem is when I tried to customize platform-specific window (from this advice AvaloniaUI/Avalonia#776)

  1. I added AvalonStudio.Shell 0.9.0-preview7 package

  2. Added styles in App.xaml
    <StyleInclude Source="avares://AvalonStudio.Shell/Themes/BaseDark.xaml"/> <StyleInclude Source="avares://AvalonStudio.Shell/Themes/Accents/DarkAccent.xaml"/> <StyleInclude Source="avares://AvalonStudio.Shell/Icons/Icons.xaml"/> <StyleInclude Source="avares://AvalonStudio.Shell/Controls/MetroWindowTheme.paml" /> <StyleInclude Source="avares://AvalonStudio.Shell.Extensibility/Controls/ControlTheme.paml" /> <StyleInclude Source="avares://AvalonStudio.Shell/Styles/GlobalStyles.xaml" />

  3. And derived MainWindow from AvalonStudio.Shell.Controls.MetroWindow

This is work on window, but doesn't work on mac
dotnet App.dll
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
at AvalonStudio.Shell.Controls.MetroWindow..ctor()
at App.Views.MainWindow..ctor() in \Projects\App\Views\MainWindow.xaml.cs:line 9
at App.App.OnFrameworkInitializationCompleted() in \Projects\App\App.xaml.cs:line 14
at Avalonia.Controls.AppBuilderBase1.Setup() at Avalonia.Controls.AppBuilderBase1.SetupWithLifetime(IApplicationLifetime lifetime)
at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T builder, String[] args, ShutdownMode shutdownMode)
at NTS.Desktop.Program.Main(String[] args) in \Projects\App\Program.cs:line 12
Abort trap: 6

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.