vkorn / go-miio Goto Github PK

What's the purpose of cutting the last char here? It causes the response JSON to be invalid when sending a get_status command.

Failed to un-marshal response: unexpected end of JSON input

It works as expected if I remove that line.

Hi vkorn,

Thanks for the library! I noticed that in long-running programs the library locks itself up. After some research, I realised that you have an UpdateChan in vacuum.go:98 that you fill up in vacuum.go:207. It is never read from, though.

I would have sent a pull request removing the channel, but I am not sure what the goal of the channel was. So maybe you can check it out and remove it if you don't intend to use it. If you wish, I can do this, too.

Best
Tom