vkz / bemhtml-syntax Goto Github PK

• implement
• add tests

Is it ok to throw error or do we want some compiler magic to handle these?

• Problem is with non-standard args to applyCtx:

block dropdown-menu {
    elem menu, default: {
        applyCtx(this._inDropdownMenu = true, {
            block: 'bla'
        });
    }
}

• Problem with computed prop in the arg to applyNext:

block button, mod round yes {
    default: applyNext(
      this.ctx.mods['only-icon'] = 'bla'
   )
}

^^ @veged @arikon @tadatuta

• implement
• add tests

• assertHasBlock assert that every template has sub-predicate matching block
• assertNoThisElem assert there're no predicates matching this.elem bem/bem-xjst#89
• applySetsMode assert that every apply sets the mode as its first argument bem/bem-xjst#91
• applyCheckFields warn when apply assigns block, elem, mods, elemMods bem/bem-xjst#73
• returnFromDef ensure there's always return in def mode. Insert return '' when there is none
• assertNoBuf assert this._buf is never used in templates

Guess it could be very useful for migration to bem-xjst-next.

Related bem/bem-xjst#121

• implement
• add tests

Input file suggest-item_type_nav with BEMHTML:

block suggest-item, mod type nav {
    default: {
        var url = this.ctx.data[4];
        applyNext({_url: (url.match(/^\w[\w-]*:\/\//g) ? '' : 'http://') + url});
    }
}

Run [email protected]:

$ bemhtml-syntax -i suggest-item_type_nav

Actual:

block('suggest-item').mod('type', 'nav')(
    def()(function() {
        var url = this.ctx.data[4];
        return applyNext({
            _url: (url.match('^\w[\w-]*:\/\/' // regexp turned to string
                g) ? '' : 'http://') + url 
        });
    }))

Expected:

block('suggest-item').mod('type', 'nav')(
    def()(function() {
        var url = this.ctx.data[4];
        return applyNext({
            _url: (url.match(/^\w[\w-]*:\/\//g) ? '' : 'http://') + url
        });
    }))

Discuss with Mishanga

• implement
• add tests

Either in this order in the API or as pre- and post- processing steps invoked from Transformer grammar:

• ometa DropNotElem
• ometa CollapseSub
• ometa Transformer

• implement
• should only be changed at top-level inside template body, DO NOT replace in closures
• add test

before

block my-block, this._.isSimple(this.ctx): {
  return BEMHTML.apply(bla, a = 1);
}

after

block('my-block').match(function() {
    return this._.isSimple(this.ctx)
})(function() {
    return this.reapply(bla, a = 1);
})

• implement
• add tests

• add a post-compilation pass that removes excessive \n in #spacesAndComments
• each sub-template should start on a separate line

see https://github.yandex-team.ru/lego/islands/pull/509
Compatibility with the latest bem-xjst should be available with relevant flag in the API

• assert that every template has sub-predicate matching block
• assert there're no predicates matching this.elem bem/bem-xjst#89
• assert that every apply sets the mode as its first argument bem/bem-xjst#91
• warn when apply assigns block, elem, mods, elemMods bem/bem-xjst#73
• convert def() + applyCtx with this.ctx inside into wrap() see article7 in https://github.yandex-team.ru/lego/islands/pull/509
• ensure there's always return in def mode. Insert return '' when there is none
• assert this._buf is never used in templates

• implement
• add tests

• implement
• add tests

• implement forced elemMatch
• throw when bem-xjst4 compatible flag {elemMatch: false}
• add tests