vmadalin / android-modular-architecture Goto Github PK

📚 Sample Android Components Architecture on a modular word focused on the scalability, testability and maintainability written in Kotlin, following best practices using Jetpack.

Home Page: https://proandroiddev.com/android-components-architecture-in-a-modular-word-7414a0631969

License: Apache License 2.0

Kotlin 99.83% Shell 0.17%

kotlin clean-architecture clean-code testing component-architecture architecture solid-principles mvvm-architecture android-architecture android

android-modular-architecture's Introduction

Hi, I'm Madalin 👋

The Programming and Computer Science are my passions. I'm a Mobile Software Developer with over 6 years of experience. Enthusiast on clean, modular and components architecture, focused on make software design more understandable, maintainable, scalable, robust, and last and not least testable. Applying design patterns, SOLID principles and good practices, making the code not only to compile.

I love collaborating with open source, keep me update with the community tendencies, writing technical articles, make personal projects and participating in hackathons or any type of challenges.

Honors & Awards:

🥇 Contributor of the year on Android Development 2020
Apps projects:

Stats:

Personal info:

android-modular-architecture's People

Contributors

Stargazers

Watchers

Forkers

omeryounus developersancho loreeen jmfayard ebnrdwan mozesi fdbshh ludugz 0rp3u leviaran sunnykinger iqbaal23 sachinshelke juechemparathy frank1234 pelingcinar mohdfarhanakram iamrare tamsir tchigher matrixy onguyenducmanh nidbhardwaj 13316989184 diegaspar saonam lyrl eis6aer hhy5277 yudikarma luclx freedomchuks mokhtarawy felipe00 ganeshvl realityexpander jp1017 degea9 victorhvs-iabcd jpicklyk cmforks michalharakal amoskorir iamkosgei maxrun brandhill pizzamarinara sarweshkumar trantuyen poojasngh432 99kyuu shakil807g cumasoyak toru0239 faiz786 frontrider tidoemanuele seohyeonbin ivamks mwshubham gauravrai1 rarj siddhant23 yutingms boriskunda rdw1226 king-of-spades eighthgene rizmaulana codeangi andhikaputra004 balao7 firozanawar nathantran-zl ofir-bar5 mkamals1989 lamvann mistrydarshan99 rforrizwan55 roger8b mbeelal demd10 paulnjoroge789016 tata8k emrisb fajarnuha paroskwan abdul6basit laura-argueta benyam7 n-balashov mishoku alexisrodriguez11 nirocknrk kemalamru muhammadfaheem-pycom bukajsytlos lduncandroid kpuneet dianamelga

android-modular-architecture's Issues

How to create a release apk that can be installed on device

Description

I'm trying to use this project as a sort of bootstrap for a new android project, when a signed release apk is created by android studio and installed it crashes instantly due to being unable to find the dynamic module fragments.

Basic Information

OS version: Linux
App version: android studio 3.5.3

Details

Using android studios Build -> generate signed apk -> normal apk
If you install that generated apk it will crash with a classpath issue with Coil, if you fix that (I added it to core's dependencies) then you get

Process: com.vmadalin.android, PID: 18602
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.vmadalin.android/com.vmadalin.android.SampleMainActivity}: android.view.InflateException: Binary XML file line #10: Binary XML file line #10: Error inflating class fragment
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3430)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3614)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:86)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2199)
        at android.os.Handler.dispatchMessage(Handler.java:112)
        at android.os.Looper.loop(Looper.java:216)
        at android.app.ActivityThread.main(ActivityThread.java:7625)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:987)
     Caused by: android.view.InflateException: Binary XML file line #10: Binary XML file line #10: Error inflating class fragment
     Caused by: android.view.InflateException: Binary XML file line #10: Error inflating class fragment
     Caused by: androidx.fragment.app.Fragment$e: Unable to instantiate fragment com.vmadalin.dynamicfeatures.home.ui.HomeFragment: make sure class name exists

I assumed as all dynamic modules are set to install time delivery a monolith apk should work. I also tried creating an aab, using bundletool to create a universal apk and installing that but I ended up with the same error.

What is the correct way to do a release APK?

Migrating from Fabric to Firebase

Description

I wanted to request that you migrate your code from Fabric to Firebase.

Basic Information

Device type: Android
OS version:
App version:

Build process

Hi,

I am not able to build this project in Android Studio 3.5.2

It doesn't seem to trigger the build in the right order and the order is not clear from your instructions. Do i need to initiate a gradle build manually for the modules in the right order ?

If so, that is the order and the suggested command ?

Thanks

No cancellation method for coroutines

First off all, thank you for this great repository with latest Android frameworks. I noticed that there is no cancel call for coroutine scopes. Is this caused for memory leaks?

[ClassNotFoundException] Release build crashing

Description

After running assembleRelease gradle task and installing app-prod-release.apk/app-dev-release.apk the app is crashing with below exception.
I suspect the proguard-rules.pro should contain a keep rule for "coil.util.CoilContentProvider"

[Edit]
add
-keep class coil.util.CoilContentProvider
to proguard-rules.pro file in ":commons:ui"

add
consumerProguardFiles("proguard-rules.pro")
to defaultConfig in buildSrc package commons

does not resolve the issue.

Basic Information

Device type: Pixel 3a emulator
OS version: Android 10 (Api 29)
App version: 1.0

Details

2020-10-05 15:03:00.786 13091-13091/com.vmadalin.android.dev E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.vmadalin.android.dev, PID: 13091
    java.lang.RuntimeException: Unable to get provider coil.util.CoilContentProvider: java.lang.ClassNotFoundException: Didn't find class "coil.util.CoilContentProvider" on path: DexPathList[[zip file "/data/app/~~jPJiP2XBCKXTWxQ3bLufAA==/com.vmadalin.android.dev-1EJOzTC0mWHGgspZplp8Yg==/base.apk"],nativeLibraryDirectories=[/data/app/~~jPJiP2XBCKXTWxQ3bLufAA==/com.vmadalin.android.dev-1EJOzTC0mWHGgspZplp8Yg==/lib/x86, /system/lib, /system_ext/lib]]
        at android.app.ActivityThread.installProvider(ActivityThread.java:7244)
        at android.app.ActivityThread.installContentProviders(ActivityThread.java:6780)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6697)
        at android.app.ActivityThread.access$1300(ActivityThread.java:237)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "coil.util.CoilContentProvider" on path: DexPathList[[zip file "/data/app/~~jPJiP2XBCKXTWxQ3bLufAA==/com.vmadalin.android.dev-1EJOzTC0mWHGgspZplp8Yg==/base.apk"],nativeLibraryDirectories=[/data/app/~~jPJiP2XBCKXTWxQ3bLufAA==/com.vmadalin.android.dev-1EJOzTC0mWHGgspZplp8Yg==/lib/x86, /system/lib, /system_ext/lib]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:207)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at android.app.AppComponentFactory.instantiateProvider(AppComponentFactory.java:147)
        at androidx.core.app.CoreComponentFactory.instantiateProvider(Unknown Source:0)
        at android.app.ActivityThread.installProvider(ActivityThread.java:7228)

[TODO] Outdated dependencies.

Description

The project's dependencies, e.g. AGP, seem to be outdated. Any plans on updating these?

Project doesn't compile and give 6 errors

Description

Downloaded the latest Master branch and got a marvel API key. Then I was prompted to update to Android Studio 4.0 which is still in early phases. After that I got 6 compile errors and tried to downgrade gradle. This project is not compiling!

Basic Information

Device type: Mac
OS version: OSX Catalina
App version:

Details

https://imgshare.io/images/2020/01/05/123.png

Repository is not glued to Interface

Thank you for the great sample. I wonder why You do not have an interface for MarvelRepository or any other Repositories in your core module. You are following SOLID principles, and that is D is SOLID to follow dependency inversion.

High-level modules should not depend on low-level modules. Both should depend on abstractions (e.g., interfaces)

Using interfaces will also simplify unit testing.

Were there any specific reason that you did not use interface for Repository?

Question about code coverage

Description

Can you elaborate on how you exclude the app directory from your code coverage in codecov?

Basic Information

Device type: Android
OS version:
App version: latest

Details

I see that in your diagram you don't have things like SampleMainActivity tested because they are excluded from the graph?

I was wonder how you did this because I see no ignore flags in your codecov/config.yml nor are there any exclusions in your jacoco configurations, at least that I can find!

Thanks!

Could not find com.vanniktech:gradle-android-junit-jacoco-plugin:0.16.0-SNAPSHOT.

I am getting this issue after building the application i am new to kotlin can anyone help me solving this issue

PayPal donation link doesn't work.

Description

PayPal donation link doesn't work.
Please update the PayPal link at FUNDING.yml
Thank you

Passing NavController to ViewModel issue

Passing NavController to ViewModel is probably a wrong approach in here:
https://github.com/VMadalin/android-modular-architecture/blob/master/features/home/src/main/kotlin/com/vmadalin/dynamicfeatures/home/ui/HomeViewModel.kt#L43
My opinion is this and the listener should be exists in the Fragment and viewModel when it is needed

[KaptException] Can't get project to build

Description

I can't get the project to build. Please see below stack trace.
Any idea on how to solve this issue?
Thanks null

Basic Information

Device type: -
OS version: -
App version: 1.0

Details

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':commons:ui:kaptDevDebugKotlin'

........

Caused by: java.util.ServiceConfigurationError: javax.annotation.processing.Processor: android.databinding.annotationprocessor.ProcessDataBinding Unable to get public no-arg constructor
	at kotlin.collections.CollectionsKt___CollectionsKt.toCollection(_Collections.kt:1155)
	at kotlin.collections.CollectionsKt___CollectionsKt.toMutableList(_Collections.kt:1188)
	at kotlin.collections.CollectionsKt___CollectionsKt.toList(_Collections.kt:1179)
	at org.jetbrains.kotlin.kapt3.base.ProcessorLoader.doLoadProcessors(ProcessorLoader.kt:80)
	at org.jetbrains.kotlin.kapt3.base.ProcessorLoader.loadProcessors(ProcessorLoader.kt:45)
Caused by: java.util.ServiceConfigurationError: javax.annotation.processing.Processor: android.databinding.annotationprocessor.ProcessDataBinding Unable to get public no-arg constructor

	at org.jetbrains.kotlin.kapt3.base.Kapt.kapt(Kapt.kt:42)
	... 29 more
Caused by: java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
	... 35 more
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.JAXBException
	... 35 more

Question: Migration to koin or Gson

Is there any ongoing thinking to refractor/migrate the project to Koin/ Moshi. As Moshi seems to be GSON 3.0 and possibly Koin will replace dagger in the near future.

Material Theming Issues in Modules

After adding Material theming, the dynamic libraries don't pick the custom theme.

Details

Add

theme.xml
type.xml
shape.xml

Reference Custom Theme in theme.xml in one of the module.
Rebuild and run the app.
Theme doesn't not reflect.

How to inject shared one instance of ViewModule to different fragments?

is it possible to inject the same veivmodel into different fragments? I mean BaseFragment<FragmentSomeBinding, SharedViewModel>

Why are there folders named "kotlin" instead of "java"

I'm curious about your project structure. Why are there folders named "kotlin" instead of "java"? Like app/src/main/kotlin/com.xx. I can't create a project like this using AS.

Originally posted by @oOJohn6Oo in #20 (comment)

Why not Hilt?

Why don't you use Hilt? Google says

Dagger and Hilt code can coexist in the same codebase. However, in most cases it is best to use Hilt to manage all of your usage of Dagger on Android.

I don't understand how id(BuildPlugins.NAVIGATION_SAFE_ARGS) works

Description

Trying to use this as the base for a new project, but I can't get past this line in app/build.gradle.kts

    id(BuildPlugins.NAVIGATION_SAFE_ARGS)

I get the following error when syncing gradle files

org.gradle.internal.exceptions.LocationAwareException: Build file '/home/calin/Projects/reasig/android/app/build.gradle.kts' line: 1
Plugin [id: 'androidx.navigation.safeargs.kotlin'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (plugin dependency must include a version number for this source)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.resolveToFoundResult(DefaultPluginRequestApplicator.java:214)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.lambda$resolvePluginRequests$4(DefaultPluginRequestApplicator.java:146)
	at org.gradle.util.CollectionUtils.collect(CollectionUtils.java:207)
	at org.gradle.util.CollectionUtils.collect(CollectionUtils.java:201)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.resolvePluginRequests(DefaultPluginRequestApplicator.java:144)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.applyPlugins(DefaultPluginRequestApplicator.java:84)
	at org.gradle.kotlin.dsl.provider.PluginRequestsHandler.handle(PluginRequestsHandler.kt:48)
	at org.gradle.kotlin.dsl.provider.StandardKotlinScriptEvaluator$InterpreterHost.applyPluginsTo(KotlinScriptEvaluator.kt:198)
	at org.gradle.kotlin.dsl.execution.Interpreter$ProgramHost.applyPluginsTo(Interpreter.kt:360)

Please update project to Firebase Crashlytics

Hi,
Please update code for firebase crashlytics code as fabric moved to firebase.

Dependency Generator generates tasks in every module

Description

Dependency Generator generates tasks in every module resulting graph is generated in every module build, I think its better to keep it lean and generate task only on rootProject

and also it'd be awesome if we could add custom generator task that has local module filter

Basic Information

Device type:
OS version:
App version:

Details

Question about using plugin in the id of plugins

Description

In regards to this project it is a great learning tool and I was curious to walk through it! My question is in the BuildPlugins file you set all the plugins to use plugins.xxxx. for example BuildPlugins.detekt, yet when I try to build it says that it cannot find a plugin with an id plugin.detekt. But if I use the following: io.gitlab.arturbosch.detekt it is found and moves to the next error in the build. Can you elaborate on that?

Thank you so much

Possible Build Failure

https://github.com/VMadalin/kotlin-sample-app/blob/3df81dd8c557a2cf787df9a0dbd4722e5aab3a3d/commons/views/src/main/kotlin/com/vmadalin/commons/views/ProgressBarDialog.kt#L62

As per the source code:

 /**
     * Returns a localized string from the application's package's
     * default string table.
     *
     * @param resId Resource id for the string
     * @return The string data associated with the resource, stripped of styled
     *         text information.
     */
    @NonNull
    public final String getString(@StringRes int resId) {
        return getResources().getString(resId);
    }

I guess calling the line viewBinding.message = context.getString(messageRes) will result in build failure.

Client: To Do Android; Version: 2.84.435.00build#: 296;UserId: 557e48c1ce0abcc6; SessionId: fbf16673-ab70-461e-8724-46e0390f6b24; DeviceId: 5fd89bee22b2edb9

vmadalin / android-modular-architecture Goto Github PK

android-modular-architecture's Introduction

Hi, I'm Madalin 👋

Honors & Awards:

Stats:

Personal info:

android-modular-architecture's People

Contributors

Stargazers

Watchers

Forkers

android-modular-architecture's Issues

Description

Basic Information

Details

Description

Basic Information

Description

Basic Information

Details

Description

Description

Basic Information

Details

Description

Basic Information

Details

Description

Description

Basic Information

Details

Material Theming Issues in Modules

Details

Description

Description

Basic Information

Details

Description

Recommend Projects

Recommend Topics

Recommend Org