voku / email-check Goto Github PK

Hi,

please remove miam.kd2.org from your "domainsTemporary.php" file as it is our internal email server, and is not publicly accessible, and does not provide temporary emails either.

Thank you.

Wouldn't it be a viable case for a valid email with a correct MX record, but no A-record? Email will be received that way.

It's an edge case, but wouldn't it be more correct to change
return !\checkdnsrr($domain . '.', 'MX') || !\checkdnsrr($domain, 'A');
to
return !\checkdnsrr($domain . '.', 'MX');

in the code here ?

What is this feature about (expected vs actual behaviour)?

Currently, the isValid callback always converts the local and domain part into Punycode.

However, lots of environments don't support Punycode and we'd like to validate email addresses such that special characters like German umlauts or other accented character would be recognized as invalid.

I'll be posting a PR in a minute to fix this.

Does it take minutes, hours or days to fix?

Minutes.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency phpunit/phpunit to v11

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

in .gitignore, line 3

.idea is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

/nbproject/private/

.idea

# composer
vendor
composer.lock

Posted from SensioLabsInsight

It looks like you have taken Michael Rushton's regex pattern as used in PHP, but you forgot to add the copyright notice?

 * Michael's regex carries this copyright:

523 *
524 * Copyright © Michael Rushton 2009-10
525 * http://squiloople.com/
526 * Feel free to use and redistribute this code. But please keep this copyright notice.

What is this feature about (expected vs actual behaviour)?

RFC 7505 specifies "null MX" for when a domain explicitly does not support email.

Even if a null MX record is set this check will still return that the address is valid.

How can I reproduce it?

$emailCheck = EmailCheck::isValid("[email protected]", false, false, false,  true);

// expected false
// got true

Does it take minutes, hours or days to fix?

In isDnsError instead of using checkdnsrr it could use dns_get_record and then check the priority.

Any additional information?