vortechsa / refinery Goto Github PK

https://docs.github.com/en/actions/publishing-packages/publishing-java-packages-with-gradle

Describe the bug

Unit Test had Error in StringCellParserTest.kt on Non English Environments.

because, Dec(December) is only used in English.

In Spanish: "Dic" (diciembre)
In French: "Déc" (décembre)
In German: "Dez" (Dezember)
In Italian: "Dic" (dicembre)
In Korean: "12"

> Task :test

StringCellParserTest > should try to parse to string or return null if failed to do that() FAILED
    org.opentest4j.AssertionFailedError at StringCellParserTest.kt:30

StringCellParserTest > should parse to string() FAILED
    org.opentest4j.AssertionFailedError at StringCellParserTest.kt:18

67 tests completed, 2 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

Expected behaviour
Unit Test was Passed.

Actual behaviour
Unit Test was Failure.

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.

Currently, it is not possible to ignore some columns that are not valuable or should not be extracted.
Aparently, in some files we have garbage columns that are defined, but never fulfilled

Describe the solution you'd like

Add ability to ignore such columns with some pattern

Describe alternatives you've considered

Currently, it is required to describe all the columns, otherwise, the exception will be thrown

Additional context

It should be possible to reuse the current columns matching mechanism (i.e. reuse AbstractHeaderCell and it's subclasses)

Is your feature request related to a problem? Please describe.
Complex metadata structure parser

Describe the solution you'd like
A solution that parses when complex metadata in horizontal and vertical directions coexists

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Example_Complex_Metadata.xls

Is your feature request related to a problem? Please describe.

Parsing data horizontally direction

Describe the solution you'd like

Parsing data horizontally direction

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Currently, there is an assumption that the header cell is containing only string cell values
However, we might have the numeric values and formulas there as well (highly unlikely, though)

Feature requirements

In some cases we have the situations when the rows are prefilled with some prefilled values like

None
NaN
-

etc

That means that these rows does not contain any useful information
Currently, if we want to skip this row the exception needs to be thrown. That means the exception manager will be polluted with tons of parsing exceptions. However, that is not an exception — it's an expected situation and should be handled appropriately.

Suggested implementation

Add the open function into RowParser that enables to skip the rows under some condition (e.g. column has None value)