voryx / thruwaycommon Goto Github PK

Messages should be reimplemented as immutable objects:

• no setters
• all properties passed through constructor/use static factory methods (like createFromJson)
• add with* copy methods

Messages should be much more strict. See autobahn/python as an example.

Hello, I am using eligible option when I am publishing messages. Here https://github.com/voryx/Thruway/blob/master/src/Transport/InternalClientTransportProvider.php#L49 is all message converted to stdClass by json_decode(json_encode($msg)) and when is message recreated here https://github.com/voryx/ThruwayCommon/blob/master/src/Message/PublishMessage.php#L159, there is a problem with this condition

$this->eligible = isset($options->eligible) && is_array($options->eligible) ? $options->eligible : null;

because $options->eligible is stdClass and not an array, eligible property is not set and messages are then broadcasted to everyone.
I think it's bug. How that can be fixed? If you give me some details please I can submit a PR.
Thank you!