voucherifyio / voucherify-android-sdk Goto Github PK

Make sure that Track Custom Event method is supported: https://docs.voucherify.io/v2018-08-01/reference#create-custom-event

• customer and event are required
• metadata is optional
• referral is optional

Drop API version support for other versions than 2018-08-01 and latest

non Android with JUnit + Mockito,
Android with Robolectric + JUnit

Travis, Circle CI, Jenkins or something similar

I accidentally put Testing7fjWdr with space at the beggining into our input. We could trim the input before sending via REST so we can avoid those types of errors.

maybe it would be helpful to catch regression.

Make sure that developer using the SDK is able to pass error property for Validation Rules when creating or updating Validation Rule.
Make sure that error property is correctly mapped when developer is using this SDK to get Validation Rule.
Update README file to include information about custom error messages.

More information can be found in documentation under following links:
https://docs.voucherify.io/reference#section-custom-error-messages-with-validation-rules
https://docs.voucherify.io/reference#the-validation-rule-object
https://docs.voucherify.io/reference#create-validation-rules

Make sure that the following methods are provided:

• Server side: Promotions.ListAllTiers(?is_avai=able=true/false); https://docs.voucherify.io/v2018-08-01/reference#list-promotion-tiers
• Client side: Promotions.ListAllTiers(?is_avai=able=true/false); https://docs.voucherify.io/v2018-08-01/reference#list-promotion-tiers-client-side

Make sure that the following methods can work with extended Order Item model:

• Order; https://docs.voucherify.io/v2018-08-01/reference#the-order-object

• Order Items; https://docs.voucherify.io/v2018-08-01/reference#the-order-item-object\

• Create Order; https://docs.voucherify.io/v2018-08-01/reference#create-order

• Update Order; https://docs.voucherify.io/v2018-08-01/reference#update-order

• Validate Voucher; https://docs.voucherify.io/v2018-08-01/reference#validate-voucher

• Validate Voucher (client side); https://docs.voucherify.io/v2018-08-01/reference#vouchers-validate

• Validate Promotions; https://docs.voucherify.io/v2018-08-01/reference#validate-promotions-1

• Redeem Voucher; https://docs.voucherify.io/v2018-08-01/reference#redeem-voucher

• Redeem Voucher (client side); https://docs.voucherify.io/v2018-08-01/reference#redeem-voucher-client-side

• Redeem Promotion; https://docs.voucherify.io/v2018-08-01/reference#redeem-promotion

Close the issue if no operation is needed or provide a solution with next release.

• simplify structure,
• use retrofit2 features,

Redemption:

• Redeem Voucher (client), added reward property Docs

Events:

• Track Event (client), added loyalty property Docs

Consents namespace:

• List Consents: GET /consents - Docs
• List Consents (Client): GET /consents - Docs

Customers namespace:

• Update Customer's Consents: PUT /customers/{id}/consents - Docs
• Update Customer's Consents (Client): PUT /customers/{id}/consents - Docs

http://vincentbrison.com/2014/07/19/how-to-improve-quality-and-syntax-of-your-android-code/