Comments (4)
beerlington
commented on August 16, 2024
2
I'm on the fence on this one. It doesn't seem like JaSerializer is doing anything wrong by including the version and any client that consumes then JSON:API should be able to just ignore it in the response if it's not using it. I don't think this is a compelling enough reason to make the version optional, but I'll leave this issue open for comments.
from ja_serializer.
beerlington
commented on August 16, 2024
I'm interested in keeping with the spec, but I'm curious what the use case would be. If JaSerializer only supports 1.0, why would you want that optional?
from ja_serializer.
tzumby
commented on August 16, 2024
I may have jumped the gun when I created this issue :)
The reason I would want this optional is because I'm working with a json-api that is not following the spec and breaks if you provide a version object. The obvious solution is to get the API to follow spec. I just happened to see that the version is optional and wanted to see your opinion about allowing that. This may not be worth it on a second thought.
from ja_serializer.
denniscastro
commented on August 16, 2024
If you have an application with legacy code and his tests and the consumer application (SPA) are strictcs, it's better that the version member be optional.
from ja_serializer.
Related Issues (20)
- Considering migrating to Jason? HOT 4
- How to get a custom attribute value formatter to work properly. HOT 4
- Remove Poison dependency
- Can not start app without poison
- Association links instead of data HOT 2
- phoenix 1.4.4 app errors due to Poison being required despite trying to use Jason HOT 3
- Omitting prev/next links when higher than total page number
- Offer camelCase keys
- Links won't use the page_base_url HOT 7
- cannot use relationship named `location` HOT 1
- Using JaSerializer.PhoenixView results in no function clause matching in Plug.Conn.resp/3 HOT 2
- EctoErrorSerializer doesn't render errors from relationships and embedded objects HOT 4
- deep_format_keys implementation & mix release duplication error HOT 3
- Missing documentation for testing Phoenix controller responses HOT 2
- Serializer not loaded relationships model HOT 4
- Sparse field param for function based attribute breaks HOT 3
- Should links be output for an empty relationship? HOT 3
- Type ignored on relationship definition HOT 5
- Is it possible to use ja_serializer with a newly generated Phoenix 1.7.7 app? HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ja_serializer.