Sparse field param for function based attribute breaks about ja_serializer HOT 3 OPEN

P.S. If it helps, I also have a workaround. In controller, I apply this transformation to the sparse fields params:

  defp underscore(nil), do: nil

  defp underscore(string) when is_binary(string), do: String.replace(string, "-", "_")

  defp underscore(%{} = map) do
    map
    |> Enum.map(fn {key, value} ->
      {key, underscore(value)}
    end)
    |> Enum.into(%{})
  end

Used like this:

    render(conn, "index.json",
      data: some_data,
      opts: [
        fields: underscore(params["fields"])
      ]
    )

from ja_serializer.

@elvanja sorry I haven't had a chance to look at this yet. It seems like this should affect any sparse field name that needs to get converted from dashes to underscore. If the regular (non-custom) property name has an underscore, does that break too?

from ja_serializer.

Hi! Sure, no problemo, it is not an emergency 😄
And yes, the non-custom properties also break, on main record or on relations.

from ja_serializer.