Giter VIP home page Giter VIP logo

Comments (5)

foundObjects avatar foundObjects commented on July 30, 2024 1

@foundObjects There you go I merged the new dialog #131!

Thanks! Sorry for the nitpick, I just figured if I'm confused by the behaviour someone else probably will be too.

Cheers!

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

It deletes it after the popup disappear normally. Are you sure you just did not wait for that popup to disappear?

from protonplus.

foundObjects avatar foundObjects commented on July 30, 2024

It deletes it after the popup disappear normally. Are you sure you just did not wait for that popup to disappear?

Ah, that's exactly what's happening, thanks!

Nitpick incoming:

I feel like that dialog would be less confusing if it had an explicit "OK" or "Proceed" button so it was more clear that deletion will happen after the dialog closes? As of now the X is basically acting like an OK button if you don't want to wait for the dialog to timeout.

Anyway, thanks, now I understand what's going on.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

Yeah you're right, I guess I could use the dialog as a way to confirm you really want to delete the tool and the x would cancel it instead. Thank you for your input!

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

@foundObjects There you go I merged the new dialog #131!

from protonplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.