Giter VIP home page Giter VIP logo

Comments (7)

ecabott avatar ecabott commented on July 30, 2024 1

Instead of listing every detected client on left side like steam, lutris, etc, make it a drop down menu where it lists all the detected clients. Then on the left side below the selected client, show installed protons of the selected client.
aa
Kind of like this.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024 1

Must have messed something up in the last update for the installed only option not working. As for your idea, I will try it to see if I like it or not. I'll keep you up to date.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024 1

image

Here's a sneak peak :)

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

Could you make a quick drawing of what you would want the UI to look like? I can't seem to picture what you said in my head so that would help me a lot.

from protonplus.

ChrisLauinger77 avatar ChrisLauinger77 commented on July 30, 2024

Installed only does also not work for me. It just shows the spinner and nothing happens.
I like the propsed idea.

from protonplus.

ChrisLauinger77 avatar ChrisLauinger77 commented on July 30, 2024

Awesome !

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

So after working on this I came to the realization that we can't really know what's installed that way since we don't know from what runner the release is from. For Proton-GE it's easy since the name is straightforward, but for the majority of them it's not. I could of course add some separators and titles so that you know where it comes from, but that would make that part of the UI really heavy in my opinion.

On top of that it would require me to rewrite a lot of the backend so that the releases from the sidebar are the same and not a copy since otherwise there's no way for the release in the sidebar to know that it was deleted from the right part and vice-versa. The other option would be to add some timers that would check on each side if they're still installed, but that would be heavy on the system for not a lot of gains.

All of that to say that I will not be following with that request since I have other projects I want to work on and don't want to spend days rewriting the backend another time.

I kept the code in https://github.com/Vysp3r/ProtonPlus/tree/sidebar-rework in case anyone want to finish it or if I feel like working on it at some point.

Forgot to say that I fixed the installed releases not loading and will post an update soon for that.

from protonplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.