2 code errors in Ex. 3 of ARIA2: Identifying a required field with the aria-required property about wcag HOT 11 CLOSED

I agree about the aria-required. This should be moved to the radiogroup.

Input elements don't need an id so I see no need to add that to the input
element.

On Wed, Apr 29, 2015 at 12:10 PM, dmargaretosIBM [email protected]
wrote:

ARIA2: Identifying a required field with the aria-required property.
http://www.w3.org/TR/WCAG20-TECHS/ARIA2.html

Code error 1: The 3rd example shows individual radio button with the
aria-required property. I believe this is incorrect. According to the ARIA
spec ( http://www.w3.org/WAI/PF/aria/states_and_properties#aria-required),
"aria-required" is not supported on role="radio" (it should be on the
element with role="radiogroup").
Code error 2: Also noticed that the id is left off of the element.

Existing and corrected code samples provided:

Existing code sample for Example 3:
Account Number

Please send an alert when balance exceeds $3,000.

• Yes
• No

Here is how I think Example 3 should be constructed ("id" added to the
input element; moved "aria-required" to radiogroup):
Account Number

Please send an alert when balance exceeds $3,000.

• Yes
• No

end

—
Reply to this email directly or view it on GitHub
#90.

from wcag.

Anyone want to do a pull request with the fixes?

from wcag.

Which branch?

On Wed, Apr 29, 2015 at 12:41 PM, Andrew Kirkpatrick <
[email protected]> wrote:

Anyone want to do a pull request with the fixes?

—
Reply to this email directly or view it on GitHub
#90 (comment).

from wcag.

Working-Branch-for-Q3-2015

from wcag.

Can you (or should I) fix the readme in that branch which says
"
WCAG (Web Content Accessibility Guidelines) - Branch for production of Jan
2015 review versions

Please do not submit any new pull requests against this branch."

On Wed, Apr 29, 2015 at 12:44 PM, Andrew Kirkpatrick <
[email protected]> wrote:

Working-Branch-for-Q3-2015

—
Reply to this email directly or view it on GitHub
#90 (comment).

from wcag.

Thanks for the heads up - I made the changes.

from wcag.

Actually, I do think we need the id on the element:

1. The for attribute is supposed to use the element id that it's bound to: http://www.w3schools.com/tags/att_label_for.asp
2. WCAG technique requires the use of the for and id attributes to explicitly associate the label with the form control: http://www.w3.org/TR/WCAG20-TECHS/H44.html
   Feel free to contact me if you want to discuss.
   Many thanks.

from wcag.

Sorry - didn't mean to close the issue.

from wcag.

you are right. I missed that is was being labelled using for... I'll fix
both but the code sample needs a bunch of changes for the styling now that
aria-required is being moved.

On Wed, Apr 29, 2015 at 12:59 PM, dmargaretosIBM [email protected]
wrote:

Actually, I do think we need the id on the element:

1. The for attribute is supposed to use the element id that it's bound to:
   http://www.w3schools.com/tags/att_label_for.asp
2. WCAG technique requires the use of the for and id attributes to
   explicitly associate the label with the form control:
   http://www.w3.org/TR/WCAG20-TECHS/H44.html
   Feel free to contact me if you want to discuss.
   Many thanks.

—
Reply to this email directly or view it on GitHub
#90 (comment).

from wcag.

Oops I accidentally pushed this fix to the working branch.
Andrew - can you let me know how I should proceed?

from wcag.

James, since this was a small change and the group approved it with a couple of changes we didn't need to change the target for the pull request.

This issue is resolved by these commits:
4e7c715
c7ae7bb

from wcag.