List of Errors

• #12
  deadline return book by 1pm
deadline return book /by
deadline
• #5
• #4
• #6
• #3
• #8
• #9

In line with best practices & OOP design, the entire code in main() of Duke should be broken up into its constituent parts

commands not recognized by Duke/Jarvis:

• listtt,
• hello, ...

In the first user input prompt from Jarvis, the "bye" exit command is not recognized & Jarvis addresses the user as "bye"

Examples of misspelled commands include:

• markk
• unmmark

Instead of having TaskList as an ArrayList variable located in Duke.java, it would be better to have TaskList as a standalone class, so that we can add features such as "successful task add" & custom print messages.

A fancy name could be TaskMaster

As an example,

public class TaskMaster {
    List<Task> taskList = new ArrayList<>(); 
}

Commands are incomplete & missing key information. Some examples include:

• todo when it should be todo buy coffee
• deadline return book /by when it should be deadline return book /by Monday, 1pm

@waffledood We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Naming boolean variables/methods

Example from src/main/java/duke/command/FindCommand.java lines 35-35:

        boolean tasksMatchingSearchKey = false;

Example from src/main/java/duke/command/MarkCommand.java lines 14-14:

    private boolean mark;

Example from src/main/java/duke/gui/MainWindow.java lines 25-25:

    private boolean firstUserChat = true;

Suggestion: Follow the given naming convention for boolean variables/methods (e.g., use a boolean-sounding prefix).You may ignore the above if you think the name already follows the convention (the script can report false positives in some cases)

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

Example from src/main/java/duke/command/Command.java lines 30-36:

    /**
     * A method that performs the logic associated with user-request command, using
     * TaskList, Ui & Storage.
     * @param taskList The TaskList containing current tasks.
     * @param ui The Ui object interacting with the user.
     * @param storage The Storage object for loading & saving of user's tasks.
    */

Example from src/main/java/duke/command/CommandType.java lines 32-36:

    /**
     * Initialize the CommandType Enum, by passing in the user input String.
     * @param commandString String representing the user's input.
     * @param regex The regex associated with the CommandType.
     */

Example from src/main/java/duke/command/CommandType.java lines 42-47:

    /**
     * Method to retrieve the CommandType Enum associated with the user's input.
     * @param commandString User input String
     * @return Enum representing the CommandType.
     * @throws DukeException Error if the user input String is an unrecognized command.
     */

Suggestion: Ensure method/class header comments follow the format specified in the coding standard, in particular, the phrasing of the overview statement

Aspect: Recent Git Commit Message (Subject Only)

possible problems in commit 95f8dd0:

Merge branch 'Level-10' of https://github.com/waffledood/ip into Level-10

• Longer than 72 characters

Suggestion: Follow the given conventions for Git commit messages for future commits (no need to modify past commit messages).

ℹ️ The bot account @nus-se-bot used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact [email protected] if you want to follow up on this post.

With regards to Parser.java as a utility class, more helpful information on how a utility class is written can be found at this StackOverflow post.

This is a bug! Even though the tasks have been marked/unmarked in the tasks.txt file, they are being indicated as all unmarked.

In line with best practices & usability across different classes, consider housing the indentation formatting & style in a single static/helper class. Something like Format.java

public class Format {
    String indentationBase = "\t";
    String indentationText = "\t  ";
    String indentationTaskStatus = "\t    ";    

    private Format() {} 
    
    public static String indentBase() {
        return this.indentationBase;
    }
}

Refer to StackOverflow post

The TODO, EVENT, DEADLINE Enums all run the same block of code, as shown belo. For brevity, use // Fallthrough for the first 2 cases

The DukeException is caught but nothing was done!

Things to do!

• Improve design & look of Duke (implement a .css file)
• Set stage title for Duke, refer to link

@waffledood We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, so that you can avoid similar problems in your tP code (which will be graded more strictly for code quality).

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Naming boolean variables/methods

Example from src/main/java/duke/command/FindCommand.java lines 35-35:

        boolean tasksMatchingSearchKey = false;

Example from src/main/java/duke/command/MarkCommand.java lines 14-14:

    private boolean mark;

Example from src/main/java/duke/gui/Main.java lines 21-21:

    private boolean repeatingReminders = true;

Suggestion: Follow the given naming convention for boolean variables/methods (e.g., use a boolean-sounding prefix).You may ignore the above if you think the name already follows the convention (the script can report false positives in some cases)

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

Example from src/main/java/duke/command/Command.java lines 30-36:

    /**
     * A method that performs the logic associated with user-request command, using
     * TaskList, Ui & Storage.
     * @param taskList The TaskList containing current tasks.
     * @param ui The Ui object interacting with the user.
     * @param storage The Storage object for loading & saving of user's tasks.
    */

Example from src/main/java/duke/command/CommandType.java lines 32-36:

    /**
     * Initialize the CommandType Enum, by passing in the user input String.
     * @param commandString String representing the user's input.
     * @param regex The regex associated with the CommandType.
     */

Example from src/main/java/duke/command/CommandType.java lines 42-47:

    /**
     * Method to retrieve the CommandType Enum associated with the user's input.
     * @param commandString User input String
     * @return Enum representing the CommandType.
     * @throws DukeException Error if the user input String is an unrecognized command.
     */

Suggestion: Ensure method/class header comments follow the format specified in the coding standard, in particular, the phrasing of the overview statement.

Aspect: Recent Git Commit Message (Subject Only)

No easy-to-detect issues 👍

Aspect: Binary files in repo

No easy-to-detect issues 👍

❗ You are not required to (but you are welcome to) fix the above problems in your iP, unless you have been separately asked to resubmit the iP due to code quality issues.

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact [email protected] if you want to follow up on this post.

This error occurs when the user marks/unmarks tasks that do not exist. Examples include:

• mark 1 when the list is empty
• unmark 4 when the list is only of size 1

Relevant files:

• MarkCommand.java
• Task.java → throw DukeException("Task already marked as done/undone!")