walmartlabs / circus-handlebars Goto Github PK

Please change Handlebars.default to Handlebars['default'] in handlebars-shim.js.

We should be able to apply our config to objects or arrays.

Exporting helpers and partials that are used in templates might lead to unexpected behavior and is a bit coincidental for defining an API. It feels like it's much safer to only export helpers that are explicitly included via the helper! and partial! loaders but this could introduce problems due to helpers being registered on the shared helpers object, regardless of if they are registered in the component's exports or not.

1. if a helper is referenced incorrecly (mispelled or the helper is missing)

/Media/Projects/wm/zeus/chrome/node_modules/pack/node_modules/circus-handlebars/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:243
      throw new Exception("You specified knownHelpersOnly, but used the unknow
            ^
Error: You specified knownHelpersOnly, but used the unknown helper foo - 3:7

makes me think that I need to find some knownHelpers config reference rather than look at my template and make sure that the helper reference matches the file name - it would also be helpful if the name of the template that contained the invalid helper reference was mentioned in the log.

2. it would be helpful to check for specific references where the "handlebars" module can't be found and provide some kind of log message indicating that "handlebars/runtime" should be referenced instead (like if you need a reference to Handlebars.SafeString)