wangsijie / pdf2jpg Goto Github PK

Thanks for the library!

Can you allow the scale variable to be an optional, defaulted parameter?

I would submit a PR but others are blocked from creating branches.

index.js

const scale = 1; // Remove this line

.
.
.

async function app(pdfData, options = { scale: 1 }) { // Add parameter with same default value of 1
    const doc = await pdfjsLib.getDocument(pdfData).promise;
    const draw = new Draw();
    for (let i = 0; i < doc.numPages; i++) {
        const page = await doc.getPage(i + 1);
        const viewport = page.getViewport({ scale: options.scale }); // Use options
        .
        .
        .

using https://commons.wikimedia.org/wiki/File:ABC_de_l%27%C3%89lecteur.pdf as an example,
when calling the API as follows

const jpgBuffer = await pdf2jpg(buffer, { scale: 1, page: 1 })

the generated image is mostly black. A small yellow square is at the bottom. (the first page).
This seems to come from index.js line 65:

height += Math.ceil(viewport.height);

which I think is supposed to be

height = Math.ceil(viewport.height);

vertical-horizontal.pdf

还没有详细测试一页一页输出能否自动识别页面方向。

would be nice to just convert a singe page instead of the whole pdf

{page: pages.length}

如果能自定义页码范围就更好了，如：

{page: [2, pages.length -1]}

我知道可以自己写循环，但需要直接引用 pdfjs-dist，提供个接口显然更方便。