Giter VIP home page Giter VIP logo

core-archived's People

Contributors

adamwathan avatar bradstinson avatar dresfdez avatar ericlbarnes avatar gazard7 avatar hpetru avatar jesseobrien avatar jyggen avatar kukunin avatar metalmatze avatar mpmont avatar rtablada avatar spamoom avatar srcr avatar stefanheimann avatar stevetan86 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

core-archived's Issues

Title attributes on content editor.

The title attributes to the content editor buttons are irrelevant and/or missing completely. It would be nice if each button was given a title which is the action of the button. This improves a11y and reduces ambiguity as to what the buttons do.

[Proposal] Auto-save

I am thinking that the current working document for a user could be stored in cache under the key wardrobe::username-curent.

In reality we could just dump the input as a raw Input array? Then have a query

if CachedPost
   populateWithCachedPost
else
   populateWithNull

@ericbarnes what are you thinking from the JS side. You tell me what you want the data to look like and I will try my darndest to make it happen

Read More section

I think there was a request for this on the beta repo.

I'm thinking to use the same tag as tumblr <!-- more --> and have a button on the toolbar. This would be seen as a HTML comment so there wouldn't be a need for parsing it out of the content.

The question becomes whether we want to store a short attribute in the DB or parse it on runtime?

Shouldn't take but a few lines to implement it either way.

[Proposal] Auto-Page Routing

A configurable way to add auto-routed pages.

Example Theme Structure

index.blade.php
layout.blade.php
pages/
--about.blade.php
--contact.blade.php

Password Reset still not working.

/wardrobe/login/remind

Submitted form and I got a fatal exception
http://local.sheldonkotyk.com/wardrobe/login/remind


Symfony \ Component \ Debug \ Exception \ FatalErrorException
Class 'Wardrobe\Core\Controllers\Password' not found

open: /Users/sheldon/Workspace/sheldonkotyk.com/vendor/wardrobe/core/src/Wardrobe/Core/Controllers/LoginController.php
/**
* Send an email to reset your password.
*/
public function remindSend()
{
$credentials = array('email' => Input::get('email'));

    return Password::remind($credentials, function($message, $user)
    {
        $message->subject('Reset your password');

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)

  • Installing intervention/image (1.4.4)
    Downloading: 100%
  • Removing wardrobe/core (dev-master 8ec214e)
  • Installing wardrobe/core (dev-master 1f7ddde)
    Downloading: 100%

intervention/image suggests installing intervention/imagecache (Caching extension for the Intervention Image library)
Writing lock file
Generating autoload files
Generating optimized class loader

[Proposal] Upgrade Notifications

For mass appeal (and even niche appeal), Wardrobe CMS could benefit from having a notification of when Wardrobe/Core or Laravel/Framework are behind in a minor revision.

I am working on a package we should be able to integrate easily to allow for version comparison and manipulation.

From there we can build an API to check against when a user accesses the admin panel.

recompile less and coffee

Is there a built in command to do the recompilation of these two assets?
If I made changes what's the best way to recompile this?

Preview on existing posts not functioning

When attempting to view previews of existing posts, previews are empty. Will start digging into this magic of local storage to see if I can't start pub when a preview link is clicked?

how would I overwrite changes to wardrobe core?

I have a couple things I need to change to properly integrate this, namely the table names used in the models and a couple other things across models/views/controllers. Where would I make these changes? If I make it directly in the vendor directory it will get overwritten when I do a composer update.

What makes most sense to me would be to clone the repo and make changes there then I can pull changes and merge them with mine. The question is where would I clone this too?
Workbench directory?

Auth Connection set

I need to figure out the best way to work around setting the auth connection for applications where there is auth used in other DB connections...

Error with wardrobe.per_page

Haven't researched where else this issue occurs, but in PostController::index(), the Config::get() method is not properly retrieving the per_page configuration.

delete/deleting model events are not getting called

I'm just not understanding why my delete and deleting events are not getting called while created event is! To create and delete the posts I'm doing it from the base UI.

class Post extends BaseModel implements CommentableModelInterface {

    public static function boot() {
        static::created(function($obj) {
               // this gets called on create
        });
        static::deleting(function($obj) {
         // this does not get called on delete
        });
        static::deleted(function($obj) {
         // this does not get called on delete
        });
    }


I tried seeing if it might be a problem with the chainning

changed

Post::where('id', $id)->where('user_id', $user->id)->delete();

to

$post = Post::where('id', $id)->where('user_id', $user->id);
$post->delete();

The problem is still there. Any idea?

Cookie jar has not been set.

I did a fresh install and loged in after installing without the remember me function.
The i clicked logout and got the message.

vendor\wardrobe\core\src\Wardrobe\Core\Controllers\LoginController.php
/**
* Log out the user
*/
public function destroy()
{
    $this->auth->logout();
    return Redirect::to('wardrobe/login');
}

Refactor post_view

Eric Todo - Post view is getting long and rather confusing. It needs to be refactored to simplify everything.

Wardrobe::posts() does not work properly

When i am on the index page like http://localhost/?page=1or loaclhost, i get all posts with Wardrobe::posts().

But if i am on page 2, like http://localhost/?page=2 i won't get any posts back.

I looked into the code and you call active with (in my case) 1 post per page, shouldn't it call all() on the repository?

View [themes.default.atom] not found.

I installed the cms with the style "blocky" and added a new entry.
Then i called localhost/rss and get this message:

View [themes.default.atom] not found.

It also seems that the different atom files in the themes folder are messed up.

Clearing Local Storage Before Save

Currently, Local Storage is being dumped before a confirmation of save is sent.

This usually isn't a problem, but I have had multiple times where either my session timesout or I switch networks while working on an article. Then when I hit post, the local storage dumps and the post is lost.

I can't remember how this is being handled right now, but the dump should probably wait for the return of a promise from the server.

[Proposal] Theme views alternative...

Wardrobe allows the user to specify the 'theme' he wants to use, this ended up in the need of setting the 'current' theme in various places (Controllers, views), by either calling the Config or using a custom helper function (theme_view).

Laravel View allows us to define a custom namespace, which would result in a much cleaner approach and, as @ericbarnes mentioned in IRC, allow us to introduce cascading theme views in the future.

So, the idea is to declare a 'wardrobe' namespace which would point to the theme the user has choosen. Some examples:

Routes

Route::get('/about', function()
{
    return View::make('wardrobe::about');
});

Route::get('/tags', function()
{
    return View::make('wardrobe::tags');
});

View:

@extends('wardrobe::layout')

@section('title')
  {{ site_title() }}
@stop

@section('content')
    <section class="home">
        @foreach ($posts as $post)
      @include('wardrobe::inc.post')
    @endforeach

    {{ $posts->links() }}
    </section>
@stop

Controller

    public function tag($tag)
    {
        $posts = $this->posts->activeByTag($tag, Config::get('wardrobe.per_page'));

        return View::make('wardrobe::archive', compact('posts', 'tag'));
    }

    public function show($slug)
    {
        $post = $this->posts->findBySlug($slug);

        if ( ! $post)
                    return App::abort(404, 'Page not found');

        return View::make('wardrobe::post', compact('post'));
    }

Hope the explanation is clear enough.

Theme config not working

I have config.php file inside my folder theme, with following content:

<?php
    return array(
        'top_link_tags' => array(
            'tutorial'  => 'Tutorial',
            'showcase'  => 'Showcase'
        ),
    );

But calling {{ Config::get('theme.top_link_tags') }} from my layout.blade.php produce nothing.

Make theme view files non-public?

Why are the theme view files in the public folder? Is it not possible to keep them in the app/view folder? Just wondering for security reasons for the rare case where your view files may have sensitive information or Blade comments in them.

Image dragging not working on localhost

There seems to be a problem with image drag and drop when running on localhost. The image get copied in the folder but the markdown isn't generated. Although it works in production. I'm not sure what could cause this or if this only happens to me but I wanted to point it out.

Integration with existing site

All the Wardrobe examples I've seen have Wardrobe installed into it's own standalone Laravel installation. Can Wardrobe be easily installed into an existing Laravel installation that already has hundreds of routes and controllers, etc? Is it flexible for this? Or best at leaving standalone?

Add the options for themes to manipulate the post content

I have created a new theme so far and wanted to integrate prettify for the codepreview.
In order to do that every <pre><code> needs to be changed to <pre class="prettyprint linenums"><code>.

So i would suggest an option for the theme to do a str_replace or something similar to the parsed content.

This could be done directly in the view but i think that shoul belong somewhere else.

Fatal Error when email/name set as NULL.

Swift_TransportException
Cannot send message without a sender address

app/config/mail.php was still set as NULL NULL.

I didn't realize that it was mandatory as the instructions looked like this setting was optional.

|--------------------------------------------------------------------------
| Global "From" Address
|--------------------------------------------------------------------------
|
| You may wish for all e-mails sent by your application to be sent from
| the same address. Here, you may specify a name and address that is
| used globally for all e-mails that are sent by your application.
|
*/

When trying to artisan wardrobe:config errors are produced

Trying to install wardrobe in an existing laravel application I get this error:

{"error":{"type":"ErrorException","message":"Argument 2 passed to Illuminate\Auth\Guard::__construct() must be an instance of Illuminate\Session\Store, instance of Illuminate\Session\SessionManager given, called in /home/ebon/uacs/vendor/wardrobe/core/src/Wardrobe/Core/Facades/Wardrobe.php on line 62 and defined","file":"/home/ebon/uacs/vendor/laravel/framework/src/Illuminate/Auth/Guard.php","line":76}}

(where /home/ebon/uacs is the directory the laravel application is hosted in)

Logout issues

RIght now if you click on logout, it will add wardrobe to the url and throw a HTTP not found error.

typo in console/config

Just a small issue, with the config, theres a typo.

on line 15 in wardrobe/core/src/Wardrobe/Core/Console/ConfigCommand.php

protected $name = 'wardrobe:cofig';

should probably be 'config'

Im sorry i cannot make a pr, im very busy atm.

Is there an easy way to disable internal wardrobe auth?

I've taken a brief look at some of the wardrobe source, but cannot see an easy way to disable internal wardrobe authentication. My application already has a sufficient authentication system, and I'd prefer to use that.

/wardrobe/login hardcoded instead of using admin prefix

Look here: https://github.com/wardrobecms/core/blob/master/src/Wardrobe/Core/Controllers/LoginController.php#L63

It hardcodes the route as wardrobe/login instead of calling on the prefix value set in /app/config/packages/wardrobe/core/routes.php. I changed my prefix from wardrobe to admin and that is how I came across this bug.

I thought maybe I could just change it to

...(Config::get('core::routes.admin_group_rules') . '/login');

But that doesn't work I guess since you are trying to call a config value from within the package source. I'm not sure how to fix this to make it dynamically use the prefix value.

Post 'status' changes to draft after you click publish.

After you publish a post, the status automatically changes to draft. I discovered this after opening a post and making multiple edits, saving each time.

To recreate:
Create a new post
Add content
Hit publish (notice the button changes to 'save' instead of 'publish')
View live article in a new tab.
Edit the content
Hit save.
Refresh article tab, article is no longer live.

I guess the assumed functionality would be to maintain the current status upon each save.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.