Giter VIP home page Giter VIP logo

classiccastbars's Introduction

ClassicCastbars

Customizable castbars for Classic & Retail World of Warcraft. Type "/castbar" to open the options panel.
Includes optional party & nameplate castbars, school lockout alerts, and basic channel + uninterruptible cast state tracking for Classic Era.

Note: This addon is now in maintenance mode, expect less frequent updates.

Classic Era 1.15.0+

This addon is no longer needed for Classic Era to see target castbars. You may disable this addon now and enable castbars in Blizzard Options -> Interface -> Show Enemy Cast Bar instead.

For anyone still using it for castbar customizations, make sure you're using version 1.7.2+ to support the new built in cast events.

Links

License

Copyright (C) 2024 Wardz | MIT License.

classiccastbars's People

Contributors

alexzaworski avatar revinderdev avatar wardz avatar wolfcon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

classiccastbars's Issues

Cast bar doesn't react to cast interrupts

What is the problem? Is there any Lua errors?
Cast bar doesn't react to cast interrupts.

What steps will reproduce the problem?
Your target starts casting spell and then interrupts it, but castbar are still being displayed the cast.

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yep

Was it working in a previous version? If yes, which was the last good one?
Nope

Any additional info? If you play on a non english client, please include your locale:
Im playing EN and RU locales

Player castbar doesn't change color on successful cast

What is the problem? Is there any Lua errors?
As the titles states the player castbar doesn't change color for successful casts (by default green). However, target and focus target castbars do.

Console doesn't print any errors

What steps will reproduce the problem?
Just conduct a cast

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes

Is this for Classic or TBC client?
TBC

Any additional info? If you play on a non-english client, please include your locale type:
En client

Pushback

What is the problem? Is there any Lua errors?
The pushback mechanic uses wrong values.

What steps will reproduce the problem?
Tested with player casting event "UNIT_SPELLCAST_DELAYED".

Does the issue still occur when all addons except ClassicCastbars are disabled?
yes

Was it working in a previous version? If yes, which was the last good one?
no

Any additional info? If you play on a non english client, please include your locale:
https://wow.gamepedia.com/index.php?title=Interrupt&oldid=305918

Game doesn't recognize the addon

Your last build is not recognized by my wow client, the file is named correctly in the addons folder ("ClassicCastBars"), my client is in english text , french dialog setup

Can't move Nameplate Castbar

Can't move Nameplate Castbar now that I'm trying to set it up for another fresh character.
I remember moving mine prior to TBC launch. I'm not that great witch codes and stuff but i think i get this LUA error(2pages):

Message: Frame is not movable
Time: Sat Aug 14 04:13:39 2021
Count: 1
Stack: Frame is not movable
[string "=[C]"]: ?

Locals: (*temporary) = {
0 =
animationGroup = {
}
parent = NamePlate1 {
}
Border = {
}
Flash = {
}
showCastbar = true
_data =

{
}
Background = {
}
Icon = {
}
startChannelColor =
{
}
finishedCastColor =
{
}
isTesting = true
nonInterruptibleColor =
{
}
tooltip = {
}
Text = {
}
fade = {
}
unitID = "nameplate-testmode"
currWidth = 135
Timer = {
}
BorderShield = {
}
Spark = {
}
startCastColor =
{
}
flashColorSameAsStart = true
finishedColorSameAsStart = true
failedCastColor =
{
}
}
(*temporary) = "LeftButton"

Message: ...nterface\AddOns\ClassicCastbars_Options\TestMode.lua:17: Action[FrameMeasurement] failed because[Can't measure restricted regions]: attempted from: NamePlate1:GetCenter().
Time: Sat Aug 14 04:13:39 2021
Count: 1
Stack: ...nterface\AddOns\ClassicCastbars_Options\TestMode.lua:17: Action[FrameMeasurement] failed because[Can't measure restricted regions]: attempted from: NamePlate1:GetCenter().
[string "=[C]"]: in function `GetCenter'
[string "@interface\AddOns\ClassicCastbars_Options\TestMode.lua"]:17: in function <...nterface\AddOns\ClassicCastbars_Options\TestMode.lua:16>
[string "@interface\AddOns\ClassicCastbars_Options\TestMode.lua"]:45: in function <...nterface\AddOns\ClassicCastbars_Options\TestMode.lua:31>

Locals: (*temporary) = NamePlate1 {
0 =
driverFrame = NamePlateDriverFrame {
}
UnitFrame = {
}
GetAdditionalInsetPadding = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:337
ApplyOffsets = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:318
NugPlateHeaders =

{
}
NCIconsCount = 0
template = "NamePlateUnitFrameTemplate"
TPFrame = ThreatPlatesFrameNamePlate1 {
}
TimeSinceLastUpdate = 0
OnSizeChanged = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:322
OnRemoved = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:305
OnAdded = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:295
GetPreferredInsets = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:348
NCIcons =
{
}
namePlateUnitToken = "nameplate1"
OnOptionsUpdated = defined @interface\AddOns\Blizzard_NamePlates\Blizzard_NamePlates.lua:312
}

Castbars Not Functioning

What is the problem? Is there any Lua errors?
When a mob starts to cast something, i get an error and the addon no longer functions. See copied error

Date: 2020-04-02 09:38:21
ID: 1
Error occured in: Global
Count: 2
Message: ..\AddOns\ClassicCastbars\ClassicCastbars.lua line 99:
attempt to call field 'UnitAuraWithBuffs' (a nil value)
Debug:
ClassicCastbars\ClassicCastbars.lua:99: CheckCastModifier()
ClassicCastbars\ClassicCastbars.lua:136: StartCast()
ClassicCastbars\ClassicCastbars.lua:156: StartAllCasts()
ClassicCastbars\ClassicCastbars.lua:209:
ClassicCastbars\ClassicCastbars.lua:170
(tail call): ?
(tail call): ?
Locals:
self = {
NAME_PLATE_UNIT_REMOVED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:441
StoreCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:170
CreateOrUpdateSecureFocusButton = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:425
PLAYER_ENTERING_WORLD = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:323
SkinPlayerCastbar = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:338
ToggleUnitEvents = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:291
CheckCastModifier = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:68
DeleteCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:213
NAME_PLATE_UNIT_ADDED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:430
DisplayCastbar = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:239
SetBorderShieldStyle = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:76
AnchorManager =

{
}
SetFocusDisplay = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:474
StartCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:128
SetCastbarFonts = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:194
CreateFadeAnimationGroup = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:212
SetCastbarIconAndText = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:56
activeFrames =
{
}
CastPushback = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:230
StopCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:140
GROUP_ROSTER_UPDATE = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:452
GetCastbarFrame = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:29
SetTargetCastbarPosition = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:42
PLAYER_TARGET_CHANGED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:423
db =
{
}
PLAYER_GUID = "Player-4372-00618E47"
ClearFocus = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:457
activeTimers =
{
}
ZONE_CHANGED_NEW_AREA = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:338
SetCastbarStatusColorsOnDisplay = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:226
GROUP_JOINED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:452
0 =
UNIT_AURA = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:408
SetLSMBorders = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:169
defaultConfig =
{
}
StartAllCasts = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:151
SetCastbarStyle = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:110
HideCastbar = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:275
StopAllCasts = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:161
GetUnitType = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:57
COMBAT_LOG_EVENT_UNFILTERED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:486
}
unitID = "target"
cast =
{
isPlayer = false
maxValue = 2.500000
timeStart = 1728735.783000
unitGUID = "Creature-0-4380-0-3-1834-000005E760"
spellID = 25292
endTime = 1728738.283000
icon = 135920
spellName = "Holy Light"
}
libCD =
{
Register = defined @interface\AddOns\ZPerl\Libs\LibClassicDurations\core.lua:690
dataVersions =
{
}
guidAccessTimes =
{
}
GetAuraDurationByUnit = defined @interface\AddOns\ZPerl\Libs\LibClassicDurations\core.lua:665
Talent = defined @interface\AddOns\ZPerl\Libs\LibClassicDurations\core.lua:159
enableEnemyBuffTrack
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
Atlas, vv1.47.00.11303.00
AtlasClassicWoW, vv1.47.00.11303.00
AtlasLootClassic, vv1.4.7
AtlasLootClassicData, vv1.4.7
AtlasLootClassicDungeonsAndRaids, vv1.4.7
AucAdvanced, v8.2.6430 (SwimmingSeadragon)
AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
AucStatSimple, v8.2.6399 (SwimmingSeadragon)
AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
Bartender4, v4.9.0
ClassicCastbars, vv1.3.2
ClassicCastbarsOptions, v
Coordinates, v2.1.0
DBMCore, v1.13.42
DBMDefaultSkin, v
DBMStatusBarTimers, v
Enchantrix, v8.2.6428 (SwimmingSeadragon)
EnchantrixBarker, v8.2.6469 (SwimmingSeadragon)
ExoLink, v1.0.1
ExoLinkBIS, v1.0.1
ExtendedCharacterStats, v2.2.1
GatherMate2, v1.45.5
GroupCalendar, v
HideRaidManager, v1.0
honorspy, v1.7.3
Informant, v8.2.6374 (SwimmingSeadragon)
LeatrixPlus, v1.13.56
NugEnergy, v1.13.14
OmniCC, v8.3.5
Pawn, v2.3.24
Questie, v5.10.0 0 fd3ff918
Recount, vv1.13.4a
SlideBar, v8.2.6375 (SwimmingSeadragon)
Stubby, v8.2.6376 (SwimmingSeadragon)
ThreatClassic2, v2.12
TomCats, v0.0.2
WeaponSwingTimer, v4.1.0
ZPerl, v5.9.3
ZPerlArcaneBar, v
ZPerlParty, v
ZPerlPartyPet, v
ZPerlPlayer, v
ZPerlPlayerBuffs, v
ZPerlPlayerPet, v
ZPerlRaidAdmin, v
ZPerlRaidFrames, v
ZPerlRaidHelper, v
ZPerlRaidPets, v
ZPerlTarget, v
ZPerlTargetTarget, v
BlizRuntimeLib_enUS v1.13.4.11304
(ck=656)

What steps will reproduce the problem?

Does the issue still occur when all addons except ClassicCastbars are disabled?

Any additional info? If you play on a non English client, please include your locale:

Uninterruptible Not Showing

What is the problem? Is there any Lua errors? I know you say that the addon will learn for the future, but it is not. You also show what Uninterruptible will look like (the original animation) and that does not happen.

What steps will reproduce the problem?

Does the issue still occur when all addons except ClassicCastbars are disabled? Yes

Is this for Classic or TBC client? TBC

Any additional info? If you play on a non-english client, please include your locale type:

Castbar does not show on NAXX LAST BOSS (Kel'Thuzad)

What is the problem? Is there any Lua errors?

Castbar is working most of the time, it is working on everything (healer cast / mage cast), but it just does not work on
Kel'Thuzad boss.

What steps will reproduce the problem?
idk

Does the issue still occur when all addons except ClassicCastbars are disabled?
i tried to reinstall it, but it does not work.

Any additional info? If you play on a non-english client, please include your locale type:
yes, I'm playing other language wow classic (Chinese) for a year+. I never have a problem with it.

No castbars shown at all - even on default settings.

What is the problem? Is there any Lua errors?
No.

What steps will reproduce the problem?
Basically have someone else cast something - enemy or friend.

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes.

Was it working in a previous version? If yes, which was the last good one?
No.

Any additional info? If you play on a non english client, please include your locale:
I was testing it during the stresstest and even on default settings it didn't show any castbars - neither on the nameplates, nor below the target-frame.

Screenshot:
https://i.imgur.com/6CpkaAS.jpg

does not work with zperl unite frames

What is the problem? Is there any Lua errors?
does not work with zperl unite frames anymore but only on other players works for mobs fine starts working only when i disable whole zperl addon with all options was working fine yesterday any ideas what should i do? got this erro anytime other player casts spell
Message: Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:99: attempt to call field 'UnitAuraWithBuffs' (a nil value)
Time: Fri Apr 3 13:44:21 2020
Count: 2
Stack: Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:99: attempt to call field 'UnitAuraWithBuffs' (a nil value)
Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:99: in function CheckCastModifier' Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:136: in function StartCast'
Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:156: in function `StartAllCasts'
Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:209: in function <Interface\AddOns\ClassicCastbars\ClassicCastbars.lua:170>
(tail call): ?
(tail call): ?

Locals: self = {
NAME_PLATE_UNIT_REMOVED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:441
StoreCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:170
CreateOrUpdateSecureFocusButton = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:425
PLAYER_ENTERING_WORLD = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:323
SkinPlayerCastbar = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:338
ToggleUnitEvents = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:291
CheckCastModifier = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:68
DeleteCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:213
NAME_PLATE_UNIT_ADDED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:430
DisplayCastbar = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:239
SetBorderShieldStyle = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:76
AnchorManager =

{
}
SetFocusDisplay = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:474
StartCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:128
SetCastbarFonts = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:194
CreateFadeAnimationGroup = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:212
SetCastbarIconAndText = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:56
activeFrames =
{
}
CastPushback = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:230
StopCast = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:140
GROUP_ROSTER_UPDATE = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:452
GetCastbarFrame = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:29
SetTargetCastbarPosition = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:42
PLAYER_TARGET_CHANGED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:423
db =
{
}
PLAYER_GUID = "Player-4465-0085515F"
ClearFocus = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:457
activeTimers =
{
}
ZONE_CHANGED_NEW_AREA = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:338
SetCastbarStatusColorsOnDisplay = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:226
GROUP_JOINED = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:452
0 =
UNIT_AURA = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:408
SetLSMBorders = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:169
defaultConfig =
{
}
StartAllCasts = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:151
SetCastbarStyle = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:110
HideCastbar = defined @interface\AddOns\ClassicCastbars\core/Frames.lua:275
StopAllCasts = defined @interface\AddOns\ClassicCastbars\ClassicCastbars.lua:161
GetUnitType = d

What steps will reproduce the problem?
did reinstal both addons

Does the issue still occur when all addons except ClassicCastbars are disabled?
no

Any additional info? If you play on a non English client, please include your locale:

Preventing me to click enter battleground

1x [ADDON_ACTION_FORBIDDEN] AddOn 'ClassicCastbars' tried to call the protected function 'AcceptBattlefieldPort()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: in function AcceptBattlefieldPort' FrameXML\StaticPopup.lua:689: in function OnAccept'
FrameXML\StaticPopup.lua:5003: in function `StaticPopup_OnClick'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>

Texture selector for the bar?

Awesome addon! Works great and getting that level of sophistication that takes it to a new level with the configuration options.
Would love the ability to modify the Status bar texture (and ideally the font) based on LSM... Is that a possible addition?

Unable to open options

The addon shows the enemy cast bars, but using /castbars or /castbar does not bring up any options at all, instead I get that it is an invalid command.

Also does not show up under Interface -> Addons in game

Bad border on player castbar

What is the problem? Is there any Lua errors?
The border castbar for player displays with incorrect inset (and seems to be too thick)
image
In this example player's castbar as same size as target's one
(I may not be caused by custom UF because it's just a reskin on blizzard's one)
What steps will reproduce the problem?
Just configure player castbar

Add isInterruptible() function

Any chance you could implement a function that I can call from my own addon to see if the currently casted spell of that unit is interruptible?

API

HI,

could you add an API to use the data in a other Addon?

Like ClassicCastbars:GeCastbarDataByUnit(UnitGUID) and return the values.
Also for the callback events

Extract cast tracking to library

This is probably a fairly substantial task but it would be super useful to have your casting data usable as a library, similar to LibThreatClassic2, or LibClassicCasterino (which unfortunately is not receiving many updates). Something akin to this would mean other addons could utilise the same data and not have to re-invent the wheel and increase addon bloat.

[Lua error]

What is the problem? Is there any Lua errors?
1x ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-79.lua:840: Method settMiddleHideCombat doesn't exist in handler for type func
[C]: ?
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-79.lua:840: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:664>
[C]: ?
...assicCastbars_Options\Libs\AceGUI-3.0\AceGUI-3.0-41.lua:72: in function <...assicCastbars_Options\Libs\AceGUI-3.0\AceGUI-3.0.lua:70>
...assicCastbars_Options\Libs\AceGUI-3.0\AceGUI-3.0-41.lua:306: in function `Fire'
...nc\libs\AceGUI-3.0-41\widgets\AceGUIWidget-CheckBox.lua:68: in function <...nc\libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:57>

Any additional info? If you play on a non English client, please include your locale:

It occurred while configuring NovaWorldBuff (more specifically : while checking "buff drop warning").

I was not able to reproduce it.

Bad detection of NPC's Pets as Player's Pets, and wrong pushbacks applied to a Pets

What is the problem? Is there any Lua errors?
The code uses this to know if a player is NPC or Player:

local bit_band = _G.bit.band
...
local COMBATLOG_OBJECT_TYPE_PLAYER_OR_PET = _G.COMBATLOG_OBJECT_TYPE_PLAYER + _G.COMBATLOG_OBJECT_TYPE_PET
...
local isPlayer = bit_band(srcFlags, COMBATLOG_OBJECT_TYPE_PLAYER_OR_PET) > 0
...

But this is wrong. This does not mean: A player unit and player's pets units, this means: A player unit, player's pets units and NPC's pets units

This is because COMBATLOG_OBJECT_TYPE_PET is also present for NPC's pets. For COMBATLOG_OBJECT_TYPE_PET, is also needed to test if the COMBATLOG_OBJECT_CONTROL_PLAYER flag is present.

This can be fixed with something like this:

local bit_band = _G.bit.band
...
local isPlayer =(bit_band(srcFlags, COMBATLOG_OBJECT_TYPE_PLAYER) > 0) or ((bit_band(srcFlags, COMBATLOG_OBJECT_TYPE_PET) > 0) and (bit_band(srcFlags, COMBATLOG_OBJECT_CONTROL_PLAYER) > 0))
...

It seems more messy but it's a right way to check this.

BUT one more thing!! in this section of code:

...
function addon:COMBAT_LOG_EVENT_UNFILTERED()
    ...
    elseif eventType == "SWING_DAMAGE" or eventType == "ENVIRONMENTAL_DAMAGE" or eventType == "RANGE_DAMAGE" or eventType == "SPELL_DAMAGE" then
        if bit_band(dstFlags, COMBATLOG_OBJECT_TYPE_PLAYER_OR_PET) > 0 then -- is player
            return self:CastPushback(dstGUID)
        end
    end
end
...

In this section of code a pushback is applied to a Players and Pets. Pets are never affected by pushbacks, even player's pets (I personally test it in my imp). So the correct code here is:

...
function addon:COMBAT_LOG_EVENT_UNFILTERED()
    ...
    elseif eventType == "SWING_DAMAGE" or eventType == "ENVIRONMENTAL_DAMAGE" or eventType == "RANGE_DAMAGE" or eventType == "SPELL_DAMAGE" then
        if bit_band(dstFlags, COMBATLOG_OBJECT_TYPE_PLAYER) > 0 then -- is player
            return self:CastPushback(dstGUID)
        end
    end
end
...

What steps will reproduce the problem?
Hit pet of NPC and see how wrong pushback is applied.

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes

Was it working in a previous version? If yes, which was the last good one?
I don't know.

Any additional info? If you play on a non english client, please include your locale:
Spanish locale.

Uninterruptible border shield size issue

Current behavior:
image
The picture is taken from the Blackwing Warlocks in Blackwing Lair. Their shadowbolt cannot be interrupted, so the Uninterruptible border shield is displayed on their cast.
I have increased the size of the spell icon on my targets castbar, and now it doesnt fit inside the shield.

This issue is not specific to this monster or this particular spell. It applies to all uninterruptible casts with my setting for increased spell size icon. The screenshot is just an example of what it looks like

Intended behavior:
When the spell icon on target castbar is increased, the border shield should grow to match the new size setting

Spell Text Anchor point

Is your feature request related to a problem? No

Describe the solution or feature you'd like:
The anchor point (alignment) of text at the moment is centered, so when moving text to the left or right within a casting bar text grows outside the bar.

If we allow the anchor point of spell text to be set left, right or center the text can grow from those points. This will enable the placement of text to the left, right or center of a cast bar preventing text from growing outside the bar when placed relative.

Any additional context: N/A

Elvui

Is their anyway to connect this to elvui? and move it where you want?

Conflict with Luna Unit Frames

When I am trying to use this addon with LUF, the enemy castbar works as intended, but the player castbar dissapears. I don't even use their player unit frame, it's disabled. Please help. :)

Party castbars showing up in raid

Sometimes the party castbars will show in raid, in the position they would normally be at in a party, but it's not at all consistent.

I'm using Blizzard Raid Frames, and can't see to find a pattern for when it happens.

No castbars for the Hunter's "Aimed Shot" abilities.

ClassicCastbars v1.0.9

The addon does not create a castbar for the Hunter's "Aimed Shot" ability (Rank 1 - 4). I cannot verify if this issue also affects the higher ranks (Rank 5 - 6).

I am unsure if this has been an issue in previous versions of the addon. "Aimed Shot" seems to be the only ability that is affected, as the addon is working without any issue for other items and abilities (Mount, Hearthstone, Profession crafting etc.)

InFlight Timers

Is your feature request related to a problem?
No

Describe the solution or feature you'd like:
Would like to show InFlight Timers for when party members on on a taxi as their Cast Bar.

Any additional context:

I've made a request to the addon Author for InFlight (https://www.wowinterface.com/downloads/info11178-InFlight.html#info), seems like comments section is the only way to get a hold of them.

Tho Im sure other addons are out there that do the same.

Combo addon issue

ClassicCastBars is working so very well on its own!!!! I love it!

However, it does not appear to work with Dominos addon for UI manipulation.

I already reported this to the Dominos developer. I am hoping the two of you can get together to get these working together :)

Font outline option

Can you add font outline option for cast names, please? It's hard to read on some bar color without black outline.
For example on that color:
1111

Wrong cast times with Curse of Tongues, wrongly applied new cast time to the current casting spell

I'm using the last ClassicCastbars version atm, v1.1.2, but these bugs also occur in previous versions.

What is the problem? Is there any Lua errors?
No Lua errors. The problem are two bugs related with cast times when some cast speed reduction debuff is present. I only test this with "Curse of Tongues (rank 1)" (I don't have the rank 2 yet), what is a 50% cast speed reduction, I don't know if this also happens with rank 2 and other similar spells as rogue poisons. The two bugs:

1.- The new cast time calculated seems to be wrong, the addon calculates a slower casting time than it really is.

2.- The addon wrongly readjust the cast time of the current casting spell when the debuff is applied, this behaviour is wrong, when some is casting a spell and receive a cast speed modifier it doesn't apply to the current casting spell.

I think some short clips are very explanatory:

The addon works well without debuffs:
https://gfycat.com/evergreenpastelbarracuda-warthunder

The addon calculating wrongs cast times with Curse of Tongues (rank 1), 50% cast speed reduction:
https://gfycat.com/athleticaromaticbrant

The addon readjusting the cast time of current casting spell when receive a Curse of Tongues debuff:
https://gfycat.com/unhappyflamboyantdarklingbeetle

What steps will reproduce the problem?
Put a cast speed reduction debuff in a player/mob and let it cast something.

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes

Was it working in a previous version? If yes, which was the last good one?
No, I have not tried all versions, but it didn't work well in sine other older versions of the addon.

Any additional info? If you play on a non english client, please include your locale:
I play in Spanish language, I have not tried if these bugs also happens with a other client/locale languages.

Player Castbar issue

What is the problem? Is there any Lua errors?
Every time I bring out my pet or put my pet away, for my hunter. my cast bar gets reset to the default position. Same thing happens on my priest when I mind control someone. So I'm guessing the pet nameplate is what's causing the reset

No Lua errors

123
456

What steps will reproduce the problem?
Put pet away
move plater castbar
pull pet out
player castbar will be in default location

Does the issue still occur when all addons except ClassicCastbars are disabled?
yes

Any additional info? If you play on a non-english client, please include your locale type:

Certain actions cause Lua errors.

What is the problem? Is there any Lua errors?
Performing certain actions cause the following Lua error to pop out repeatedly, as long as action is being performed: Interface\AddOns\ClassicCastbars\core/Frames.lua:279: attempt to index a nil value

What steps will reproduce the problem?
Activating the torch switch in Jandice Barov's room.
Looting the Skin of Shadow in Ilucia Barov's room.

Does the issue still occur when all addons except ClassicCastbars are disabled?
Haven't tried yet due to position of known trigger, will try when a more accessible reproduction step is found.

Any additional info? If you play on a non English client, please include your locale:
Nil.

Add more crowdControls spells

Is your feature request related to a problem?
No.

Describe the solution or feature you'd like:
I see that in Data.lua exist a variable namespace.crowdControls that have a list of crowd controls spell debuffs, with the purpose of stop the casting bar if one of these crow crontrols affect a unit.

I have expanded this list by adding a good number of crowd control spells, especially NPC spells.

I know that I have to be careful, because when SPELL_AURA_APPLIED of COMBAT_LOG_EVENT_UNFILTERED is triggered, the name of the spell debuff will be compared and not the spellId, so I have been verifying that these spells debuffs do not cause conflict with other ones that have the same spell name but do not cause effects of loss of control and I have been removing them. I think I have done well, but maybe I was wrong, I hope not, an additional review would not hurt. This is the final list in Data.lua:

...
-- List of crowd controls.
-- We want to stop the castbar when these auras are detected
-- as SPELL_CAST_FAILED is not triggered when an unit gets CC'ed.
namespace.crowdControls = {
    [GetSpellInfo(5211)] = 1,       -- Bash
    [GetSpellInfo(24394)] = 1,      -- Intimidation
    [GetSpellInfo(853)] = 1,        -- Hammer of Justice
    [GetSpellInfo(22703)] = 1,      -- Inferno Effect (Summon Infernal)
    [GetSpellInfo(408)] = 1,        -- Kidney Shot
    [GetSpellInfo(12809)] = 1,      -- Concussion Blow
    [GetSpellInfo(20253)] = 1,      -- Intercept Stun
    [GetSpellInfo(20549)] = 1,      -- War Stomp
    [GetSpellInfo(2637)] = 1,       -- Hibernate
    [GetSpellInfo(3355)] = 1,       -- Freezing Trap
    [GetSpellInfo(19386)] = 1,      -- Wyvern Sting
    [GetSpellInfo(118)] = 1,        -- Polymorph
    [GetSpellInfo(28271)] = 1,      -- Polymorph: Turtle
    [GetSpellInfo(28272)] = 1,      -- Polymorph: Pig
    [GetSpellInfo(20066)] = 1,      -- Repentance
    [GetSpellInfo(1776)] = 1,       -- Gouge
    [GetSpellInfo(6770)] = 1,       -- Sap
    [GetSpellInfo(1513)] = 1,       -- Scare Beast
    [GetSpellInfo(8122)] = 1,       -- Psychic Scream
    [GetSpellInfo(2094)] = 1,       -- Blind
    [GetSpellInfo(5782)] = 1,       -- Fear
    [GetSpellInfo(5484)] = 1,       -- Howl of Terror
    [GetSpellInfo(6358)] = 1,       -- Seduction
    [GetSpellInfo(5246)] = 1,       -- Intimidating Shout
    [GetSpellInfo(6789)] = 1,       -- Death Coil
    [GetSpellInfo(9005)] = 1,       -- Pounce
    [GetSpellInfo(1833)] = 1,       -- Cheap Shot
    [GetSpellInfo(16922)] = 1,      -- Improved Starfire
    [GetSpellInfo(19410)] = 1,      -- Improved Concussive Shot
    [GetSpellInfo(12355)] = 1,      -- Impact
    [GetSpellInfo(20170)] = 1,      -- Seal of Justice Stun
    [GetSpellInfo(15269)] = 1,      -- Blackout
    [GetSpellInfo(18093)] = 1,      -- Pyroclasm
    [GetSpellInfo(12798)] = 1,      -- Revenge Stun
    [GetSpellInfo(5530)] = 1,       -- Mace Stun
    [GetSpellInfo(19503)] = 1,      -- Scatter Shot
    [GetSpellInfo(605)] = 1,        -- Mind Control
    [GetSpellInfo(7922)] = 1,       -- Charge Stun
    [GetSpellInfo(18469)] = 1,      -- Counterspell - Silenced
    [GetSpellInfo(15487)] = 1,      -- Silence
    [GetSpellInfo(18425)] = 1,      -- Kick - Silenced
    [GetSpellInfo(24259)] = 1,      -- Spell Lock
    [GetSpellInfo(18498)] = 1,      -- Shield Bash - Silenced
    [GetSpellInfo(2878)] = 1,       -- Turn Undead
    [GetSpellInfo(710)] = 1,        -- Banish

    -- ITEMS
    [GetSpellInfo(13327)] = 1,      -- Reckless Charge
    [GetSpellInfo(1090)] = 1,       -- Sleep
    [GetSpellInfo(5134)] = 1,       -- Flash Bomb Fear
    [GetSpellInfo(19821)] = 1,      -- Arcane Bomb Silence
    [GetSpellInfo(4068)] = 1,       -- Iron Grenade
    [GetSpellInfo(19769)] = 1,      -- Thorium Grenade
    [GetSpellInfo(13808)] = 1,      -- M73 Frag Grenade
    [GetSpellInfo(4069)] = 1,       -- Big Iron Bomb
    [GetSpellInfo(12543)] = 1,      -- Hi-Explosive Bomb
    [GetSpellInfo(4064)] = 1,       -- Rough Copper Bomb
    [GetSpellInfo(12421)] = 1,      -- Mithril Frag Bomb
    [GetSpellInfo(19784)] = 1,      -- Dark Iron Bomb
    [GetSpellInfo(4067)] = 1,       -- Big Bronze Bomb
    [GetSpellInfo(4066)] = 1,       -- Small Bronze Bomb
    [GetSpellInfo(4065)] = 1,       -- Large Copper Bomb
    [GetSpellInfo(13237)] = 1,      -- Goblin Mortar
    [GetSpellInfo(835)] = 1,        -- Tidal Charm
    [GetSpellInfo(13181)] = 1,      -- Gnomish Mind Control Cap
    [GetSpellInfo(12562)] = 1,      -- The Big One
    [GetSpellInfo(15283)] = 1,      -- Stunning Blow (Weapon Proc)
    [GetSpellInfo(56)] = 1,         -- Stun (Weapon Proc)
    [GetSpellInfo(26108)] = 1,      -- Glimpse of Madness
    [GetSpellInfo(8345)] = 1,       -- Control Machine (Gnomish Universal Remote trinket)
    [GetSpellInfo(13235)] = 1,      -- Forcefield Collapse (Gnomish Harm Prevention Belt)
    [GetSpellInfo(15753)] = 1,      -- Linken's Boomerang (trinket)
    [GetSpellInfo(15535)] = 1,      -- Enveloping Winds (Six Demon Bag trinket)
    [GetSpellInfo(28406)] = 1,      -- Polymorph Backfire
    [GetSpellInfo(16600)] = 1,      -- Might of Shahram (Blackblade of Shahram sword)
    [GetSpellInfo(13907)] = 1,      -- Smite Demon (Enchant Weapon - Demonslaying)
    [GetSpellInfo(15822)] = 1,      -- Dreamless Sleep Potion
    [GetSpellInfo(16053)] = 1,      -- Dominion of Soul (Orb of Draconic Energy)
    [GetSpellInfo(21330)] = 1,      -- Corrupted Fear (Deathmist Raiment set)
    
    -- NPCS
    [GetSpellInfo(3242)] = 1,       -- Ravage
    [GetSpellInfo(3271)] = 1,       -- Fatigued
    [GetSpellInfo(5708)] = 1,       -- Swoop
    [GetSpellInfo(11430)] = 1,      -- Slam
    [GetSpellInfo(17276)] = 1,      -- Scald
    [GetSpellInfo(18812)] = 1,      -- Knockdown
    [GetSpellInfo(3442)] = 1,       -- Enslave
    [GetSpellInfo(20683)] = 1,      -- Highlord's Justice
    [GetSpellInfo(17286)] = 1,      -- Crusader's Hammer
    [GetSpellInfo(3109)] = 1,       -- Presence of Death
    [GetSpellInfo(3143)] = 1,       -- Glacial Roar
    [GetSpellInfo(3263)] = 1,       -- Touch of Ravenclaw
    [GetSpellInfo(5106)] = 1,       -- Crystal Flash
    [GetSpellInfo(6266)] = 1,       -- Kodo Stomp
    [GetSpellInfo(6730)] = 1,       -- Head Butt
    [GetSpellInfo(6982)] = 1,       -- Gust of Wind
    [GetSpellInfo(7961)] = 1,       -- Azrethoc's Stomp
    [GetSpellInfo(8151)] = 1,       -- Surprise Attack
    [GetSpellInfo(3635)] = 1,       -- Crystal Gaze
    [GetSpellInfo(21188)] = 1,      -- Stun Bomb Attack
    [GetSpellInfo(16451)] = 1,      -- Judge's Gavel
    [GetSpellInfo(3589)] = 1,       -- Deafening Screech
    [GetSpellInfo(4320)] = 1,       -- Trelane's Freezing Touch
    [GetSpellInfo(6942)] = 1,       -- Overwhelming Stench
    [GetSpellInfo(8715)] = 1,       -- Terrifying Howl
    [GetSpellInfo(8817)] = 1,       -- Smoke Bomb
    [GetSpellInfo(25772)] = 1,      -- Mental Domination
    [GetSpellInfo(15859)] = 1,      -- Dominate Mind
    [GetSpellInfo(24753)] = 1,      -- Trick
    [GetSpellInfo(19408)] = 1,      -- Panic
    [GetSpellInfo(23364)] = 1,      -- Tail Lash
    [GetSpellInfo(19364)] = 1,      -- Ground Stomp
    [GetSpellInfo(19369)] = 1,      -- Ancient Despair
    [GetSpellInfo(19641)] = 1,      -- Pyroclast Barrage
    [GetSpellInfo(19393)] = 1,      -- Soul Burn
    [GetSpellInfo(20277)] = 1,      -- Fist of Ragnaros
    [GetSpellInfo(19780)] = 1,      -- Hand of Ragnaros
    [GetSpellInfo(18431)] = 1,      -- Bellowing Roar
    [GetSpellInfo(22289)] = 1,      -- Brood Power: Green
    [GetSpellInfo(22291)] = 1,      -- Brood Power: Bronze
    [GetSpellInfo(22561)] = 1,      -- Brood Power: Green
    [GetSpellInfo(19872)] = 1,      -- Calm Dragonkin
    [GetSpellInfo(22274)] = 1,      -- Greater Polymorph
    [GetSpellInfo(23310)] = 1,      -- Time Lapse
    [GetSpellInfo(23174)] = 1,      -- Chromatic Mutation
    [GetSpellInfo(23171)] = 1,      -- Time Stop (Brood Affliction: Bronze)
    [GetSpellInfo(22667)] = 1,      -- Shadow Command
    [GetSpellInfo(23603)] = 1,      -- Wild Polymorph
    [GetSpellInfo(23182)] = 1,      -- Mark of Frost
    [GetSpellInfo(25043)] = 1,      -- Aura of Nature
    [GetSpellInfo(24811)] = 1,      -- Draw Spirit
    [GetSpellInfo(25806)] = 1,      -- Creature of Nightmare
    [GetSpellInfo(6253)] = 1,       -- Backhand
    [GetSpellInfo(6466)] = 1,       -- Axe Toss
    [GetSpellInfo(8242)] = 1,       -- Shield Slam
    [GetSpellInfo(8285)] = 1,       -- Rampage
    [GetSpellInfo(6524)] = 1,       -- Ground Tremor
    [GetSpellInfo(6607)] = 1,       -- Lash
    [GetSpellInfo(7399)] = 1,       -- Terrify
    [GetSpellInfo(8150)] = 1,       -- Thundercrack
    [GetSpellInfo(11020)] = 1,      -- Petrify
    [GetSpellInfo(11641)] = 1,      -- Hex
    [GetSpellInfo(17307)] = 1,      -- Knockout
    [GetSpellInfo(16075)] = 1,      -- Throw Axe
    [GetSpellInfo(16104)] = 1,      -- Crystallize
    [GetSpellInfo(11836)] = 1,      -- Freeze Solid
    [GetSpellInfo(29419)] = 1,      -- Flash Bomb
    [GetSpellInfo(6304)] = 1,       -- Rhahk'Zor Slam
    [GetSpellInfo(6435)] = 1,       -- Smite Slam
    [GetSpellInfo(6432)] = 1,       -- Smite Stomp
    [GetSpellInfo(228)] = 1,        -- Polymorph: Chicken
    [GetSpellInfo(8040)] = 1,       -- Druid's Slumber
    [GetSpellInfo(7967)] = 1,       -- Naralex's Nightmare
    [GetSpellInfo(7139)] = 1,       -- Fel Stomp
    [GetSpellInfo(7621)] = 1,       -- Arugal's Curse
    [GetSpellInfo(7803)] = 1,       -- Thundershock
    [GetSpellInfo(7074)] = 1,       -- Screams of the Past
    [GetSpellInfo(8281)] = 1,       -- Sonic Burst
    [GetSpellInfo(8359)] = 1,       -- Left for Dead
    [GetSpellInfo(9256)] = 1,       -- Deep Sleep
    [GetSpellInfo(12946)] = 1,      -- Putrid Stench
    [GetSpellInfo(3636)] = 1,       -- Crystalline Slumber
    [GetSpellInfo(10093)] = 1,      -- Harsh Winds
    [GetSpellInfo(21808)] = 1,      -- Summon Shardlings
    [GetSpellInfo(21869)] = 1,      -- Repulsive Gaze
    [GetSpellInfo(12888)] = 1,      -- Cause Insanity
    [GetSpellInfo(12480)] = 1,      -- Hex of Jammal'an
    [GetSpellInfo(12890)] = 1,      -- Deep Slumber
    [GetSpellInfo(25774)] = 1,      -- Mind Shatter
    [GetSpellInfo(15471)] = 1,      -- Enveloping Web
    [GetSpellInfo(3609)] = 1,       -- Paralyzing Poison
    [GetSpellInfo(17492)] = 1,      -- Hand of Thaurissan
    [GetSpellInfo(14870)] = 1,      -- Drunken Stupor
    [GetSpellInfo(13902)] = 1,      -- Fist of Ragnaros
    [GetSpellInfo(6945)] = 1,       -- Chest Pains
    [GetSpellInfo(3551)] = 1,       -- Skull Crack
    [GetSpellInfo(15618)] = 1,      -- Snap Kick
    [GetSpellInfo(16508)] = 1,      -- Intimidating Roar
    [GetSpellInfo(16497)] = 1,      -- Stun Bomb
    [GetSpellInfo(17405)] = 1,      -- Domination
    [GetSpellInfo(16798)] = 1,      -- Enchanting Lullaby
    [GetSpellInfo(12734)] = 1,      -- Ground Smash
    [GetSpellInfo(17293)] = 1,      -- Burning Winds
    [GetSpellInfo(16869)] = 1,      -- Ice Tomb
    [GetSpellInfo(22856)] = 1,      -- Ice Lock
    [GetSpellInfo(16838)] = 1,      -- Banshee Shriek
}
...

As a summary, 2 player spells, 10 items spells and 106 NPC spells have been added.

Gold border texture

It'd be nice to have a gold varient of the default texture to match the nameplates like in this screenshot
WoWScrnShot_010519_212523 jpg c142478477f20c970ff15e75391d09f8

Thank you!

Implement and contribute to LibClassicCasterino

There is a library which detects spell casts by units called LibClassicCasterino. It is implemented by e.g. Details Damage Meter, Quartz casting bar, etc. Currently ClassicCastbars has its own database of spell casts, interrupts, delays, etc.

In order for all these addons to have the same information, it would be good, if ClassicCastbars would also implement this library and even more important provide the additional information about interrupts and delays to the library.

Sacrifice does not display

When fighting Zevrim Thornhuf it shows the Intense Pain cast correctly. But when he starts to cast sacrifice it doesn't show up on CCB. This is very frustrating when farming dm east solo.

Otherwise great addon :)
Greetings

Disable Castbars on Friendly Nameplates

Is your feature request related to a problem?
It's not related to a bug.

Describe the solution or feature you'd like:
I would like the option to disable castbars for Friendly Nameplates.

Any additional context:
Willing to help test if needed.

Can't move player castbar if disable "auto position"

What is the problem? Is there any Lua errors?
None

What steps will reproduce the problem?
Enable player castbar, toggle test, disable "auto position"

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes.

Was it working in a previous version? If yes, which was the last good one?
Feature nonexistent.

Any additional info? If you play on a non english client, please include your locale:
europe

Castbar Player doesn't render properly after a reload UI, with the option "Cast Bar Underneath"

Bug reproduced in v1.1.1 and v1.1.2

What is the problem? Is there any Lua errors?
The option "Cast Bar Underneath" doesn't work properly after a reload UI. The cast bar stops being properly rendered in the interface. There's no Lua error.

What steps will reproduce the problem?
After activating the castbar for the player, which works perfectly fine, I activate the option "Cast Bar Underneath":
WoWScrnShot_102319_211440

Once it's done, it's working fine:
WoWScrnShot_102319_211457

But if you restart the game, or even simply do a reload UI, this is what you end up with:
WoWScrnShot_102319_211526

At that point, it even shows on the "Toggle Testing Player" bar:
WoWScrnShot_102319_211552

If I just disable the option "Cast Bar Underneath" after that, this is what I get:
WoWScrnShot_102319_211610

Once the option is disabled and the interface reloaded, I'm back to normal:
WoWScrnShot_102319_211624

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes, it does.

Was it working in a previous version? If yes, which was the last good one?
I started using ClassicCastbars from the v1.1.1, and the bug already existed at that point. I don't know about older versions.

Lua error

What is the problem? Is there any Lua errors?
Lua error when enabling/disabling Castbar Nameplate

1x ...\ClassicCastbars_Options\ClassicCastbars_Options-v1.4.0.lua:90: attempt to call method 'DisableBlizzardCastbar' (a nil value)
...\ClassicCastbars_Options\ClassicCastbars_Options-v1.4.0.lua:90: in function <...\ClassicCastbars_Options\ClassicCastbars_Options.lua:87>
[C]: ?
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua:51: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:49>
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-81.lua:847: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:668>
[C]: ?
BagSync\libs\AceGUI-3.0\AceGUI-3.0-41.lua:72: in function <BagSync\libs\AceGUI-3.0\AceGUI-3.0.lua:70>
BagSync\libs\AceGUI-3.0\AceGUI-3.0-41.lua:306: in function `Fire'
...nc\libs\AceGUI-3.0-41\widgets\AceGUIWidget-CheckBox.lua:68: in function <...nc\libs\AceGUI-3.0\widgets\AceGUIWidget-CheckBox.lua:57>

Is this for Classic or TBC client?
Classic ERA

ClassicCastbars API

Is your feature request related to a problem?
Yes

Describe the solution or feature you'd like:
I would like to have a function in ClassicCastbars that sends back the cast object as such:

function addon:UnitCastingInfo(unitID)
if not activeTimers[UnitGUID(unitID)] then return end
return activeTimers[UnitGUID(unitID)]
end

I tried to add ClassicCastbars as dependency and add the function to the main lua in your addon just to test, then call from my addon:

local cast = ClassicCastbars.UnitCastingInfo("target")

But its always nil

Any additional context:
I am a complete WoW addon noob just trying to get by in the world

Target castbar texture - out of border

What is the problem? Is there any Lua errors?
As seen below, the castbar texture is getting out of its border.

castbar_texture

What steps will reproduce the problem?
Using the default castbar texture and default border - no custom textures in Interface folder.

Does the issue still occur when all addons except ClassicCastbars are disabled?
Yes.

Was it working in a previous version? If yes, which was the last good one?
It's like this since I've used the addon first time (~2 months ago).

Any additional info? If you play on a non english client, please include your locale:
No extra stuff.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.